<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[1552] sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-json-api.php: WordCamp JSON API: Whitelist `/posts/types` and `/posts/types/<type>` routes.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/1552">1552</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/1552","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>iandunn</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-05-07 20:22:00 +0000 (Thu, 07 May 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>WordCamp JSON API: Whitelist `/posts/types` and `/posts/types/<type>` routes.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordcamporgpublic_htmlwpcontentmupluginswcorgjsonapiphp">sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-json-api.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordcamporgpublic_htmlwpcontentmupluginswcorgjsonapiphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-json-api.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-json-api.php 2015-05-07 19:49:49 UTC (rev 1551)
+++ sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-json-api.php 2015-05-07 20:22:00 UTC (rev 1552)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -34,8 +34,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> '/posts/(?P<id>\d+)' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> array( array( $wp_json_posts, 'get_post' ), WP_JSON_Server::READABLE ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- // todo Add /posts/types too, because it's useful for debugging and there's no harm. It has a different array structure than the current ones, though, so this will need some work.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '/posts/types' => array(
+ array( array( $wp_json_posts, 'get_post_types' ), WP_JSON_Server::READABLE ),
+ ),
+ '/posts/types/(?P<type>\w+)' => array(
+ array( array( $wp_json_posts, 'get_post_type' ), WP_JSON_Server::READABLE ),
+ ),
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> return $whitelisted_endpoints;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -175,7 +179,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> case 'wcb_session':
</span><span class="cx" style="display: block; padding: 0 10px"> $speaker_id = get_post_meta( $prepared_post['ID'], '_wcpt_speaker_id', true );
</span><span class="cx" style="display: block; padding: 0 10px"> $speaker = $wp_json_posts->get_post( $speaker_id );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $prepared_post['speaker'] = is_a( $speaker, 'WP_JSON_Response' ) ? $speaker : null;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $prepared_post['speaker'] = is_a( $speaker, 'WP_JSON_Response' ) ? $speaker : null; // todo Add multiple speakers when upgrade to v2 of the API bug, see #1020-meta
</ins><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -274,6 +278,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'wp_json_server_before_serve', 'wcorg_json_avoid_nested_callback_conflicts', 11 ); // after the default endpoints are added in `json_api_default_filters()`
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> /*
</span><span class="cx" style="display: block; padding: 0 10px"> * WP-CLI Commands
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -292,6 +297,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $start_timestamp = microtime( true );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // These calls are not formatted in a more compact way because we don't want to short-circuit any of them if one fails
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $this->post_types_exposed() ) {
+ $errors = true;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $this->post_meta_exposed() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $errors = true;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -307,6 +316,53 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Check if any sensitive post types are being exposed.
+ *
+ * See note in post_meta_exposed() about test data.
+ *
+ * @return bool
+ */
+ protected function post_types_exposed() {
+ $errors = false;
+
+ WP_CLI::line();
+ WP_CLI::line( 'Checking post types.' );
+
+ // Check Central and a normal site, because they can have different types loaded
+ $post_types_endpoints = array(
+ 'http://central.wordcamp.org/wp-json/posts/types',
+ 'http://europe.wordcamp.org/2014/wp-json/posts/types',
+ );
+
+ $whitelisted_post_types = array(
+ 'post', 'page', 'attachment', 'revision', 'wcb_speaker', 'wcb_session', 'wcb_sponsor', 'mes',
+ 'mes-sponsor-level', 'wordcamp'
+ );
+
+ foreach ( $post_types_endpoints as $request_url ) {
+ $request_url = apply_filters( 'wcorg_json_api_verify_data_scrubbed_url', $request_url ); // Use this filter to override the URLs with corresponding endpoints on your sandbox
+ $response = json_decode( wp_remote_retrieve_body( wp_remote_get( $request_url ) ) );
+
+ if ( empty( $response->post->slug ) ) {
+ $errors = true;
+ WP_CLI::warning( "Unable to retrieve post types from $request_url", false );
+ continue;
+ }
+
+ foreach ( $response as $post_type ) {
+ if ( in_array( $post_type->slug, $whitelisted_post_types ) ) {
+ WP_CLI::line( "{$post_type->slug} is whitelisted." );
+ } else {
+ $errors = true;
+ WP_CLI::warning( "{$post_type->slug} is being exposed at $request_url" );
+ }
+ }
+ }
+
+ return $errors;
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Check if any sensitive post meta is being exposed.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * If this were a proper test we'd insert the data into a test db during setup rather than relying on the
</span></span></pre>
</div>
</div>
</body>
</html>