<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[1058] sites/trunk/wordpress.org/public_html/style/trac/trac-security.js: Update Trac security script.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/1058">1058</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/1058","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>nacin</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2014-12-22 00:03:06 +0000 (Mon, 22 Dec 2014)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Update Trac security script. props jorbin, fixes <a href="http://meta.trac.wordpress.org/ticket/265">#265</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlstyletractracsecurityjs">sites/trunk/wordpress.org/public_html/style/trac/trac-security.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlstyletractracsecurityjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/style/trac/trac-security.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/style/trac/trac-security.js 2014-12-19 21:57:26 UTC (rev 1057)
+++ sites/trunk/wordpress.org/public_html/style/trac/trac-security.js 2014-12-22 00:03:06 UTC (rev 1058)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,50 +1,70 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/* global wp */
+window.wp = window.wp || {};
+
</ins><span class="cx" style="display: block; padding: 0 10px"> (function($) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var badwords, intersect;
- badwords = [
- 'sql', 'trojan', 'rce', 'permissions', 'exploit', 'exploits', 'csrf', 'xss', 'sqli',
- 'scripting', 'vulnerability', 'vulnerabilities', 'capability', 'capabilities', 'intrusion',
- 'intrusions', 'cve', 'disclosure', 'hash', 'security', 'leakage', 'privilege', 'privileges',
- 'escape', 'unescape', 'escaped', 'unescaped', 'escapes', 'escaping', 'unescaping', 'esc_',
- 'sanitize', 'unsanitize', 'sanitizes', 'unsanitizes', 'sanitized', 'unsanitized', 'sanitization',
- 'valid', 'invalid', 'validate', 'validates', 'validation',
- 'compromise', 'escalation', 'injection', 'forgery', 'password', 'passwords'
- ];
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var propertyform = $( '#propertyform' ),
+ submit = propertyform.find( 'input[type="submit"]' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- intersect = function(a, b) {
- return $.grep(a, function(i) {
- return $.inArray(i, b) > -1;
- });
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $( document.body ).hasClass( 'security' ) ) {
+ return;
+ }
+
+ wp.trac_security = {
+ badwords : [
+ 'sql', 'trojan', 'rce', 'permissions', 'exploit', 'exploits', 'csrf', 'xss', 'sqli',
+ 'scripting', 'vulnerability', 'vulnerabilities', 'capability', 'capabilities', 'intrusion',
+ 'intrusions', 'cve', 'disclosure', 'hash', 'security', 'leakage', 'privilege', 'privileges',
+ 'escape', 'unescape', 'escaped', 'unescaped', 'escapes', 'escaping', 'unescaping', 'esc_',
+ 'sanitize', 'unsanitize', 'sanitizes', 'unsanitizes', 'sanitized', 'unsanitized', 'sanitization',
+ 'valid', 'invalid', 'validate', 'validates', 'validation',
+ 'compromise', 'escalation', 'injection', 'forgery', 'password', 'passwords',
+ ],
+
+ intersect : function(a, b) {
+ return $.grep(a, function(i) {
+ return $.inArray(i, b) > -1;
+ });
+ },
+
+ has_overlap : function(str, arr){
+ var words = str.toLowerCase().replace(/[^a-z|\s]/g, '').split(' '),
+ overlap = this.intersect( words, arr);
+
+ return ( overlap.length !== 0 );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $(document).ready( function() {
- var propertyform = $( '#propertyform' ),
- submit = propertyform.find( 'input[type="submit"]' );
- $( '#field-summary, #field-description' ).on( 'keyup', function() {
- var words, overlap;
- words = $(this).val().toLowerCase().split( /[^a-z]/ );
- overlap = intersect( badwords, words );
-
- if ( overlap.length === 0 ) {
- submit.prop( 'disabled', false );
- $( '#security-question' ).hide();
- return;
- }
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function show_box() {
+ // We have a potential problem here
+ submit.prop( 'disabled', true );
+ if ( $( '#security-question' ).length !== 0 ) {
+ // We've already created the checkbox
+ $( '#security-question' ).show();
+ } else {
+ // We need to add the checkbox
+ $( '.buttons' ).before( '<p id="security-question"><label><input type="checkbox" name="sec_question" />' +
+ ' I am <strong>not</strong> reporting a security issue</label>' +
+ ' — <a href="http://make.wordpress.org/core/handbook/reporting-security-vulnerabilities/">report security issues to security@wordpress.org</a></p>' );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // We have a potential problem here
- submit.prop( 'disabled', true );
- if ( $( '#security-question' ).length !== 0 ){
- // We've already created the checkbox
- $( '#security-question' ).show();
- } else {
- // We need to add the checkbox
- $( '.buttons' ).before( '<p id="security-question"><label><input type="checkbox" name="sec_question" />' +
- ' I am <strong>not</strong> reporting a security issue</label>' +
- ' — <a href="http://make.wordpress.org/core/handbook/reporting-security-vulnerabilities/">report security issues to security@wordpress.org</a></p>' );
- }
- });
- propertyform.on( 'change', '#security-question input', function() {
- submit.prop( 'disabled', ! $(this).is( ':checked' ) );
- });
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
+
+ function hide_box() {
+ $( 'input[name="submit"]' ).prop( 'disabled', false );
+ $( '#sec_question' ).hide();
+ }
+
+ jQuery( '#field-summary, #field-description, #field-keywords' ).on( 'keyup', function() {
+ var entry = $(this).val();
+
+ if ( wp.trac_security.has_overlap( entry, wp.trac_security.badwords ) ) {
+ show_box();
+ } else {
+ hide_box();
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> });
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-})(jQuery);
</del><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ propertyform.on( 'change', '#security-question input', function() {
+ submit.prop( 'disabled', ! $(this).is( ':checked' ) );
+ });
+}(jQuery));
</ins></span></pre>
</div>
</div>
</body>
</html>