<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[773] sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer: Code Reference: fixes for, and selective activation of, handbooks</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://meta.trac.wordpress.org/changeset/773">773</a></dd>
<dt>Author</dt> <dd>coffee2code</dd>
<dt>Date</dt> <dd>2014-07-30 22:08:42 +0000 (Wed, 30 Jul 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Code Reference: fixes for, and selective activation of, handbooks

* Landing page:
  * Permit members of site to access the page
  * Set proper links to handbooks
  * Don't display the page content
* Redirect naked '/handbook/' requests to home page
* Remove 'Handbook' from handbook breadcrumbs
* Base site section title for handbooks on is_post_type_archive()</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperfunctionsphp">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/functions.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperinctemplatetagsphp">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperpagehomelandingphp">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/page-home-landing.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperfunctionsphp"></a>
<div class="modfile"><h4>Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/functions.php (772 => 773)</h4>
<pre class="diff"><span>
<span class="info">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/functions.php        2014-07-30 21:45:47 UTC (rev 772)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/functions.php   2014-07-30 22:08:42 UTC (rev 773)
</span><span class="lines">@@ -48,6 +48,7 @@
</span><span class="cx">  add_action( 'widgets_init', __NAMESPACE__ . '\\widgets_init' );
</span><span class="cx">  add_action( 'pre_get_posts', __NAMESPACE__ . '\\pre_get_posts' );
</span><span class="cx">  add_action( 'template_redirect', __NAMESPACE__ . '\\redirect_single_search_match' );
</span><ins>+       add_action( 'template_redirect', __NAMESPACE__ . '\\redirect_handbook' );
</ins><span class="cx">   add_action( 'wp_enqueue_scripts', __NAMESPACE__ . '\\theme_scripts_styles' );
</span><span class="cx">  add_filter( 'post_type_link', __NAMESPACE__ . '\\method_permalink', 10, 2 );
</span><span class="cx">  add_filter( 'term_link', __NAMESPACE__ . '\\taxonomy_permalink', 10, 3 );
</span><span class="lines">@@ -62,6 +63,7 @@
</span><span class="cx">  //add_filter( 'comments_open', '__return_false' );
</span><span class="cx"> 
</span><span class="cx">  add_filter( 'breadcrumb_trail_items',  __NAMESPACE__ . '\\breadcrumb_trail_items', 10, 2 );
</span><ins>+       add_filter( 'breadcrumb_trail_items',  __NAMESPACE__ . '\\breadcrumb_trail_remove_handbook', 10, 2 );
</ins><span class="cx"> 
</span><span class="cx">  treat_comments_as_examples();
</span><span class="cx"> }
</span><span class="lines">@@ -98,6 +100,23 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> /**
</span><ins>+ * Removes the 'Handbook' segment of the breakcrumb, when present.
+ *
+ * There is no handbook page or listing at present.
+ *
+ * @param  array $items The breadcrumb trail items
+ * @param  array $args  Original arg
+ * @return array
+ */
+function breadcrumb_trail_remove_handbook( $items, $args ) {
+       if ( false !== strpos( $items[1], '>Handbook</a>' ) ) {
+               array_splice( $items, 1, 1 );
+       }
+
+       return $items;
+}
+
+/**
</ins><span class="cx"> * handbook post_type filter function
</span><span class="cx"> */
</span><span class="cx"> function filter_handbook_post_types( $types ) {
</span><span class="lines">@@ -473,6 +492,16 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> /**
</span><ins>+ * Redirects a naked handbook request to home.
+ */
+function redirect_handbook() {
+       if ( 'handbook' == get_query_var( 'name' ) && ! get_query_var( 'post_type ' ) ) {
+               wp_redirect( home_url() );
+               exit();
+       }
+}
+
+/**
</ins><span class="cx">  * Makes phpDoc @link references clickable.
</span><span class="cx">  *
</span><span class="cx">  * Handles these five different types of links:
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperinctemplatetagsphp"></a>
<div class="modfile"><h4>Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php (772 => 773)</h4>
<pre class="diff"><span>
<span class="info">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php        2014-07-30 21:45:47 UTC (rev 772)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php   2014-07-30 22:08:42 UTC (rev 773)
</span><span class="lines">@@ -335,16 +335,20 @@
</span><span class="cx">   * @return string
</span><span class="cx">   */
</span><span class="cx">  function get_site_section_title() {
</span><ins>+               if ( is_post_type_archive( array( 'plugin-handbook' ) ) ) {
+                       return __( 'Plugin Handbook', 'wporg' );
+               }
+
+               if ( is_post_type_archive( array ( 'theme-handbook' ) ) ) {
+                       return __( 'Theme Handbook', 'wporg' );
+               }
+
</ins><span class="cx">           $parts = explode( '/', $_SERVER['REQUEST_URI'] );
</span><span class="cx">          switch ( $parts[1] ) {
</span><span class="cx">                  case 'reference':
</span><del>-                               return 'Code Reference';
-                       case 'theme-handbook':
-                               return 'Theme Handbook';
-                       case 'plugin-handbook':
-                               return 'Plugin Handbook';
</del><ins>+                                return __( 'Code Reference', 'wporg' );
</ins><span class="cx">                   default:
</span><del>-                               return 'Developer Resources';
</del><ins>+                                return __( 'Developer Resources', 'wporg' );
</ins><span class="cx">           }
</span><span class="cx">  }
</span><span class="cx"> 
</span><span class="lines">@@ -800,4 +804,4 @@
</span><span class="cx">          return is_user_member_of_blog();
</span><span class="cx">  }
</span><span class="cx"> 
</span><del>-}
</del><ins>+}
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperpagehomelandingphp"></a>
<div class="modfile"><h4>Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/page-home-landing.php (772 => 773)</h4>
<pre class="diff"><span>
<span class="info">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/page-home-landing.php        2014-07-30 21:45:47 UTC (rev 772)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/page-home-landing.php   2014-07-30 22:08:42 UTC (rev 773)
</span><span class="lines">@@ -8,8 +8,10 @@
</span><span class="cx">  */
</span><span class="cx"> 
</span><span class="cx"> // Temporarily redirect to reference until other section become live, justifying a main landing page.
</span><del>-wp_redirect( get_permalink( get_page_by_path( 'reference' ) ) );
-exit();
</del><ins>+if ( ! is_user_member_of_blog() ) {
+       wp_redirect( get_permalink( get_page_by_path( 'reference' ) ) );
+       exit();
+}
</ins><span class="cx"> 
</span><span class="cx"> get_header(); ?>
</span><span class="cx"> 
</span><span class="lines">@@ -22,12 +24,12 @@
</span><span class="cx">                                  <div class="widget box box-left transparent">
</span><span class="cx">                                          <h3 class="widget-title"><div class="dashicons dashicons-welcome-widgets-menus"></div><?php _e( 'Themes', 'wporg' ); ?></h3>
</span><span class="cx">                                          <p class="widget-description"><?php _e( 'Want to know all there is to know about theming and WordPress?', 'wporg' ); ?></p>
</span><del>-                                               <a href="#" class="themes-go get-started go button"><?php _e( 'Develop Themes ', 'wporg' ); ?><span class="dashicons dashicons-arrow-right-alt2"></span></a>
</del><ins>+                                                <a href="<?php esc_attr_e( get_post_type_archive_link( 'theme-handbook' ) ); ?>" class="themes-go get-started go button"><?php _e( 'Develop Themes ', 'wporg' ); ?><span class="dashicons dashicons-arrow-right-alt2"></span></a>
</ins><span class="cx">                                   </div>
</span><span class="cx">                                  <div class="widget box box-right transparent">
</span><span class="cx">                                          <h3 class="widget-title"><div class="dashicons dashicons-admin-plugins"></div><?php _e( 'Plugins', 'wporg' ); ?></h3>
</span><span class="cx">                                          <p class="widget-description"><?php _e( 'Ready to dive deep into the world of plugin authoring?', 'wporg' ); ?></p>
</span><del>-                                               <a href="#" class="plugins-go get-started go button"><?php _e( 'Develop Plugins ', 'wporg' ); ?><span class="dashicons dashicons-arrow-right-alt2"></span></a>
</del><ins>+                                                <a href="<?php esc_attr_e( get_post_type_archive_link( 'plugin-handbook' ) ); ?>" class="plugins-go get-started go button"><?php _e( 'Develop Plugins ', 'wporg' ); ?><span class="dashicons dashicons-arrow-right-alt2"></span></a>
</ins><span class="cx">                                   </div>
</span><span class="cx">                          </div>
</span><span class="cx">                  </div><!-- /topic-guide -->
</span><span class="lines">@@ -46,7 +48,7 @@
</span><span class="cx">                          </div>
</span><span class="cx">                  </div><!-- /new-in-guide -->
</span><span class="cx"> 
</span><del>-
</del><ins>+<?php /*
</ins><span class="cx">                   <main id="main" class="site-main section" role="main">
</span><span class="cx"> 
</span><span class="cx">                                  <?php while ( have_posts() ) : the_post(); ?>
</span><span class="lines">@@ -71,8 +73,8 @@
</span><span class="cx">                                  <?php endwhile; // end of the loop. ?>
</span><span class="cx"> 
</span><span class="cx">                  </main><!-- #main -->
</span><ins>+*/ ?>
</ins><span class="cx"> 
</span><del>-
</del><span class="cx">                   <div class="search-guide section light-gray clear">
</span><span class="cx">                          <div class="inner-wrap three-columns">
</span><span class="cx">                                  <div class="widget box">
</span></span></pre>
</div>
</div>

</body>
</html>