<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[689] sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/function-reference.js: Code Reference: JS tweaks: proper variable naming, correct inline docs regarding height calculation; adjust expanded height.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://meta.trac.wordpress.org/changeset/689">689</a></dd>
<dt>Author</dt> <dd>coffee2code</dd>
<dt>Date</dt> <dd>2014-06-07 18:07:05 +0000 (Sat, 07 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Code Reference: JS tweaks: proper variable naming, correct inline docs regarding height calculation; adjust expanded height. props atimmer</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperjsfunctionreferencejs">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/function-reference.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperjsfunctionreferencejs"></a>
<div class="modfile"><h4>Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/function-reference.js (688 => 689)</h4>
<pre class="diff"><span>
<span class="info">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/function-reference.js 2014-06-06 21:52:44 UTC (rev 688)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/function-reference.js 2014-06-07 18:07:05 UTC (rev 689)
</span><span class="lines">@@ -4,15 +4,15 @@
</span><span class="cx"> * Handles all interactivity on the single function page
</span><span class="cx"> */
</span><span class="cx"> ( function( $ ) {
</span><del>- var $sourceContent, $sourceCodeContainer, $sourceCodeTable, $showCompleteSource, $lessCompleteSource, $sourceCollapsedHeight;
</del><ins>+ var $sourceContent, $sourceCodeContainer, $sourceCodeTable, $showCompleteSource, $lessCompleteSource, sourceCollapsedHeight;
</ins><span class="cx">
</span><span class="cx"> function toggleCompleteSource( e ) {
</span><span class="cx"> e.preventDefault();
</span><span class="cx">
</span><span class="cx"> if ( $showCompleteSource.is(':visible') ) {
</span><del>- var heightGoal = $sourceCodeTable.height() + 37; // takes into consideration potential x-scrollbar
</del><ins>+ var heightGoal = $sourceCodeTable.height() + 45; // takes into consideration potential x-scrollbar
</ins><span class="cx"> } else {
</span><del>- var heightGoal = $sourceCollapsedHeight;
</del><ins>+ var heightGoal = sourceCollapsedHeight;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $sourceCodeContainer.animate( { height: heightGoal + 'px' } );
</span><span class="lines">@@ -32,14 +32,14 @@
</span><span class="cx">
</span><span class="cx"> $sourceCodeTable = $sourceContent.find( 'table' );
</span><span class="cx">
</span><del>- // 1em (margin) + 20 * 17px. Lines are 1.1em which rounds to 17px: calc( 1em + 17px * 20 ).
</del><ins>+ // 1em (margin) + 10 * 17px + 10. Lines are 1.1em which rounds to 17px: calc( 1em + 17px * 10 + 10 ).
</ins><span class="cx"> // Extra 10px added to partially show next line so it's clear there is more.
</span><del>- $sourceCollapsedHeight = 196;
</del><ins>+ sourceCollapsedHeight = 196;
</ins><span class="cx">
</span><del>- if ( ( $sourceCollapsedHeight - 12 ) < $sourceCodeTable.height() ) {
</del><ins>+ if ( ( sourceCollapsedHeight - 12 ) < $sourceCodeTable.height() ) {
</ins><span class="cx">
</span><span class="cx"> // Do this with javascript so javascript-less can enjoy the total sourcecode
</span><del>- $( '.source-code-container' ).css( { height: $sourceCollapsedHeight + 'px' } );
</del><ins>+ $( '.source-code-container' ).css( { height: sourceCollapsedHeight + 'px' } );
</ins><span class="cx">
</span><span class="cx"> $showCompleteSource = $( '.show-complete-source' );
</span><span class="cx"> $lessCompleteSource = $( '.less-complete-source' );
</span></span></pre>
</div>
</div>
</body>
</html>