<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[638] sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer: Code Reference: Separate get_current_version() into functions to retrieve actual version and one to retrieve its term object.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://meta.trac.wordpress.org/changeset/638">638</a></dd>
<dt>Author</dt> <dd>coffee2code</dd>
<dt>Date</dt> <dd>2014-05-23 05:48:41 +0000 (Fri, 23 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Code Reference: Separate get_current_version() into functions to retrieve actual version and one to retrieve its term object. See <a href="http://meta.trac.wordpress.org/ticket/484">#484</a>.
* get_current_version() now returns a string of the actual version of parsed WP code (or best effort)
* Prefer 'wp_parser_imported_wp_version' option value as set in newer version of parser
* Add get_current_version_term() to return wp-parser-since term object for the major version of parsed WP code
* Add argument to permit get_current_version_term() to return term object for actual version</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperinctemplatetagsphp">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperpagereferencelandingphp">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/page-reference-landing.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperinctemplatetagsphp"></a>
<div class="modfile"><h4>Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php (637 => 638)</h4>
<pre class="diff"><span>
<span class="info">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php 2014-05-22 16:31:20 UTC (rev 637)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php 2014-05-23 05:48:41 UTC (rev 638)
</span><span class="lines">@@ -249,21 +249,49 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><del>- * Get current (latest) since major version (X.Y.0) term object.
</del><ins>+ * Get current version of the parsed WP code.
</ins><span class="cx"> *
</span><del>- * @return object
</del><ins>+ * Prefers the 'wp_parser_imported_wp_version' option value set by more
+ * recent versions of the parser. Failing that, it checks the
+ * WP_CORE_LATEST_RELEASE constant (set on wp.org) though this is not
+ * guaranteed to be the latest parsed version. Failing that, it uses a
+ * hardcoded value, which isn't guaranteed either.
+ *
+ * @return string
</ins><span class="cx"> */
</span><span class="cx"> function get_current_version() {
</span><ins>+ $current_version = get_option( 'wp_parser_imported_wp_version' );
</ins><span class="cx">
</span><del>- $current_version = defined( 'WP_CORE_LATEST_RELEASE' ) ? WP_CORE_LATEST_RELEASE : '3.9';
- $version_parts = explode( '.', $current_version, 3 );
- if ( count( $version_parts ) == 2 ) {
- $version_parts[] = '0';
- } else {
- $version_parts[2] = '0';
</del><ins>+ if ( empty( $current_version ) ) {
+ $current_version = defined( 'WP_CORE_LATEST_RELEASE' ) ? WP_CORE_LATEST_RELEASE : '3.9.1';
</ins><span class="cx"> }
</span><del>- $current_version = implode( '.', $version_parts );
</del><span class="cx">
</span><ins>+ return $current_version;
+ }
+
+ /**
+ * Get current (latest) version of the parsed WP code as a wp-parser-since
+ * term object.
+ *
+ * By default returns the major version (X.Y.0) term object because minor
+ * releases rarely add enough, if any, new things to feature.
+ *
+ * @param boolean $ignore_minor Use the major release version X.Y.0 instead of the actual version X.Y.Z?
+ * @return object
+ */
+ function get_current_version_term( $ignore_minor = true ) {
+ $current_version = get_current_version();
+
+ if ( $ignore_minor ) {
+ $version_parts = explode( '.', $current_version, 3 );
+ if ( count( $version_parts ) == 2 ) {
+ $version_parts[] = '0';
+ } else {
+ $version_parts[2] = '0';
+ }
+ $current_version = implode( '.', $version_parts );
+ }
+
</ins><span class="cx"> $version = get_terms( 'wp-parser-since', array(
</span><span class="cx"> 'number' => '1',
</span><span class="cx"> 'order' => 'DESC',
</span><span class="lines">@@ -568,5 +596,4 @@
</span><span class="cx"> return strcmp( $a->post_name, $b->post_name );
</span><span class="cx"> }
</span><span class="cx">
</span><del>-}
-
</del><ins>+}
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperpagereferencelandingphp"></a>
<div class="modfile"><h4>Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/page-reference-landing.php (637 => 638)</h4>
<pre class="diff"><span>
<span class="info">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/page-reference-landing.php 2014-05-22 16:31:20 UTC (rev 637)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/page-reference-landing.php 2014-05-23 05:48:41 UTC (rev 638)
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx">
</span><span class="cx"> <div class="new-in-guide section two-columns clear">
</span><span class="cx"> <div class="widget box gray">
</span><del>- <h3 class="widget-title"><?php $version = DevHub\get_current_version(); printf( __( 'New in WordPress %s:', 'wporg' ), $version->name ); ?></h3>
</del><ins>+ <h3 class="widget-title"><?php $version = DevHub\get_current_version_term(); printf( __( 'New in WordPress %s:', 'wporg' ), $version->name ); ?></h3>
</ins><span class="cx"> <div class="widget-content">
</span><span class="cx"> <ul class="unordered-list no-bullets">
</span><span class="cx"> <?php
</span></span></pre>
</div>
</div>
</body>
</html>