<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[372] sites/trunk/trac.wordpress.org: Trac: Define bug gardeners by a more specific permission.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://meta.trac.wordpress.org/changeset/372">372</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2014-02-04 22:08:20 +0000 (Tue, 04 Feb 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Trac: Define bug gardeners by a more specific permission.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunktracwordpressorgconfnotificationsini">sites/trunk/trac.wordpress.org/conf/notifications.ini</a></li>
<li><a href="#sitestrunktracwordpressorgconfworkflowcoreini">sites/trunk/trac.wordpress.org/conf/workflow-core.ini</a></li>
<li><a href="#sitestrunktracwordpressorgtemplatessitehtml">sites/trunk/trac.wordpress.org/templates/site.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunktracwordpressorgconfnotificationsini"></a>
<div class="modfile"><h4>Modified: sites/trunk/trac.wordpress.org/conf/notifications.ini (371 => 372)</h4>
<pre class="diff"><span>
<span class="info">--- sites/trunk/trac.wordpress.org/conf/notifications.ini 2014-02-04 18:41:27 UTC (rev 371)
+++ sites/trunk/trac.wordpress.org/conf/notifications.ini 2014-02-04 22:08:20 UTC (rev 372)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> [blackmagic]
</span><del>-cc.hide = true
</del><ins>+cc.disable = true
</ins><span class="cx">
</span><span class="cx"> [components]
</span><span class="cx"> blackmagic.* = enabled
</span></span></pre></div>
<a id="sitestrunktracwordpressorgconfworkflowcoreini"></a>
<div class="modfile"><h4>Modified: sites/trunk/trac.wordpress.org/conf/workflow-core.ini (371 => 372)</h4>
<pre class="diff"><span>
<span class="info">--- sites/trunk/trac.wordpress.org/conf/workflow-core.ini 2014-02-04 18:41:27 UTC (rev 371)
+++ sites/trunk/trac.wordpress.org/conf/workflow-core.ini 2014-02-04 22:08:20 UTC (rev 372)
</span><span class="lines">@@ -13,28 +13,28 @@
</span><span class="cx">
</span><span class="cx"> assign = new -> assigned
</span><span class="cx"> assign.operations = set_owner
</span><del>-assign.permissions = TICKET_ADMIN
</del><ins>+assign.permissions = TICKET_EDIT_DESCRIPTION
</ins><span class="cx"> assign.default = -10
</span><span class="cx">
</span><span class="cx"> reassign = assigned,accepted,reopened -> assigned
</span><span class="cx"> reassign.operations = set_owner
</span><del>-reassign.permissions = TICKET_ADMIN
</del><ins>+reassign.permissions = TICKET_EDIT_DESCRIPTION
</ins><span class="cx"> reassign.default = -10
</span><span class="cx">
</span><span class="cx"> accept = new,reviewing,assigned,accepted,reopened -> accepted
</span><span class="cx"> accept.operations = set_owner_to_self
</span><del>-accept.permissions = TICKET_ADMIN
</del><ins>+accept.permissions = TICKET_EDIT_DESCRIPTION
</ins><span class="cx"> accept.default = -11
</span><span class="cx">
</span><span class="cx"> review = new,assigned,reopened -> reviewing
</span><span class="cx"> review.operations = set_owner
</span><del>-review.permissions = TICKET_ADMIN
</del><ins>+review.permissions = TICKET_EDIT_DESCRIPTION
</ins><span class="cx"> review.default = -12
</span><span class="cx">
</span><span class="cx"> reassign_reviewing = reviewing -> reviewing
</span><span class="cx"> reassign_reviewing.name = reassign review
</span><span class="cx"> reassign_reviewing.operations = set_owner
</span><del>-reassign_reviewing.permissions = TICKET_ADMIN
</del><ins>+reassign_reviewing.permissions = TICKET_EDIT_DESCRIPTION
</ins><span class="cx"> reassign_reviewing.default = -12
</span><span class="cx">
</span><span class="cx"> # Closing a ticket
</span><span class="lines">@@ -57,7 +57,7 @@
</span><span class="cx"> fix = new,reviewing,assigned,accepted,reopened -> closed
</span><span class="cx"> fix.name = close
</span><span class="cx"> fix.operations = set_resolution
</span><del>-fix.permissions = TICKET_ADMIN
</del><ins>+fix.permissions = TICKET_EDIT_DESCRIPTION
</ins><span class="cx"> fix.set_resolution = fixed
</span><span class="cx"> fix.default = -23
</span><span class="cx">
</span><span class="lines">@@ -74,11 +74,11 @@
</span><span class="cx"> change_resolution = closed -> closed
</span><span class="cx"> change_resolution.name = change the resolution, set
</span><span class="cx"> change_resolution.operations = set_resolution
</span><del>-change_resolution.permissions = TICKET_ADMIN
</del><ins>+change_resolution.permissions = TICKET_EDIT_DESCRIPTION
</ins><span class="cx"> change_resolution.default = -31
</span><span class="cx">
</span><span class="cx"> change_to_duplicate = closed -> closed
</span><span class="cx"> change_to_duplicate.name = mark as duplicate of #
</span><span class="cx"> change_to_duplicate.operations = set_duplicate
</span><del>-change_to_duplicate.permissions = TICKET_ADMIN
</del><ins>+change_to_duplicate.permissions = TICKET_EDIT_DESCRIPTION
</ins><span class="cx"> change_to_duplicate.default = -32
</span></span></pre></div>
<a id="sitestrunktracwordpressorgtemplatessitehtml"></a>
<div class="modfile"><h4>Modified: sites/trunk/trac.wordpress.org/templates/site.html (371 => 372)</h4>
<pre class="diff"><span>
<span class="info">--- sites/trunk/trac.wordpress.org/templates/site.html 2014-02-04 18:41:27 UTC (rev 371)
+++ sites/trunk/trac.wordpress.org/templates/site.html 2014-02-04 22:08:20 UTC (rev 372)
</span><span class="lines">@@ -7,6 +7,7 @@
</span><span class="cx"> scripts_version = '38'
</span><span class="cx"> project_slug = req.environ['HTTP_HOST'].split(':')[0].split('.')[0]
</span><span class="cx"> wporg_endpoint = '//make.wordpress.org/core/'
</span><ins>+ is_bug_gardener = 'TICKET_EDIT_DESCRIPTION' in perm(resource)
</ins><span class="cx">
</span><span class="cx"> if project_slug == 'core':
</span><span class="cx"> notifications_enabled = 1
</span><span class="lines">@@ -59,8 +60,6 @@
</span><span class="cx"> fields_map[ fields[i]['name'] ] = i
</span><span class="cx"> ?>
</span><span class="cx">
</span><del>-<script type="text/javascript" charset="utf-8" src="/chrome/common/js/jquery.js"></script>
-
</del><span class="cx"> <!--! styles and such -->
</span><span class="cx"> <head py:match="head" py:attrs="select('@*')">
</span><span class="cx"> ${select('*|comment()|text()')}
</span><span class="lines">@@ -165,7 +164,7 @@
</span><span class="cx"> </py:if>
</span><span class="cx">
</span><span class="cx"> <!--! force non-gardeners to preview before posting -->
</span><del>- <py:if test="not ( 'TICKET_ADMIN' in perm(resource) or 'Bug Gardener' in perm(resource) ) and not 'preview' in req.args">
</del><ins>+ <py:if test="not is_bug_gardener and not 'preview' in req.args">
</ins><span class="cx"> <py:match path="form[@id='propertyform']/div[@class='buttons']" once="true">
</span><span class="cx"> <div py:attrs="select('@*')">
</span><span class="cx"> <input type="submit" name="preview" value="Continue to Preview" />
</span><span class="lines">@@ -203,7 +202,7 @@
</span><span class="cx"> </py:if>
</span><span class="cx">
</span><span class="cx"> <!--! Remove 'Replace existing attachment of the same name' checkbox for non-gardeners -->
</span><del>-<py:if test="not ( 'TICKET_ADMIN' in perm(resource) or 'Bug Gardener' in perm(resource) )">
</del><ins>+<py:if test="not is_bug_gardener">
</ins><span class="cx"> <py:match path="form[@id='attachment']//div[@class='options']" py:strip="" />
</span><span class="cx"> </py:if>
</span><span class="cx">
</span><span class="lines">@@ -292,7 +291,7 @@
</span><span class="cx"> <!--! WP.org Global Footer -->
</span><span class="cx"> <xi:include href="wporg-footer.html" />
</span><span class="cx">
</span><del>- <script py:if="'TICKET_ADMIN' in perm(resource) or 'Bug Gardener' in perm(resource)">
</del><ins>+ <script py:if="is_bug_gardener">
</ins><span class="cx"> var wpBugGardener = true;
</span><span class="cx"> </script>
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>