[wp-meta] [Making WordPress.org] #3864: Plugin Directory: Submission check for existing slug needs improvement

Making WordPress.org noreply at wordpress.org
Tue Oct 9 22:20:56 UTC 2018


#3864: Plugin Directory: Submission check for existing slug needs improvement
------------------------------+--------------------
 Reporter:  Ipstenu           |      Owner:  (none)
     Type:  defect            |     Status:  new
 Priority:  normal            |  Milestone:
Component:  Plugin Directory  |   Keywords:
------------------------------+--------------------
 The submission form checks to see if a slug has been approved (so it will
 detect closed and disabled as well as approved and published). This
 prevents people from submitting Akismet over and over.

 But it has some flaws. Like it doesn't check REJECTED slugs. Normally this
 wouldn't matter, as slugs are renamed to `rejected-PLUGIN-rejected` in
 order to NOT lock up a slug. The problem here is that we didn't always.

 Example: Yoast SEO has the slug wordpress-seo, so logically it would get
 by with the slug yoast-seo (which doesn't exist
 http://wordpress.org/plugins/yoast-seo ). Except... They get in as yoast-
 seo-2 (yes, 2). That's because at one point we rejected a plugin with that
 slug in the period of time BEFORE we fixed the slugs.

 So there's a rejected yoast-seo with that slug and now everyone gets
 yoast-seo-2

 1) We should check rejected slugs too

 2) The slugger needs to be smarter and STOP if it ends with a hyphen and
 number (-2, -3, etc)

 I'm not worried about 'legit' plugins ending in a number like that as we
 don't generally accept those anyway, and we can fix the slug if we have
 to.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/3864>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list