[wp-meta] [Making WordPress.org] #3607: Change the way public query vars are added for the handbooks and searchform

[Making WordPress.org]

#3607: Change the way public query vars are added for the handbooks and searchform
---------------------------+-----------------------
 Reporter:  keesiemeijer   |      Owner:  (none)
     Type:  defect         |     Status:  new
 Priority:  normal         |  Milestone:
Component:  Developer Hub  |   Keywords:  has-patch
---------------------------+-----------------------
 The `query_vars` filter uses a numerically indexed array to store the
 public query vars. The handbook and the searchform are adding query vars
 as an associative array (with default values).

 The following patch adds the query vars in the proper way.

 This will not affect the way the query vars behave. Newly added query vars
 have a `falsy` value by default.

 The question is if we even need to add them. There are no custom rewrite
 rules that use these query vars, and we don't use them as query args in
 the front end.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/3607>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org