[wp-meta] [Making WordPress.org] #2850: Introducing a custom taxonomy "groups" for the speakers shortcode

Making WordPress.org noreply at wordpress.org
Tue Jun 6 23:05:04 UTC 2017

#2850: Introducing a custom taxonomy "groups" for the speakers shortcode
 Reporter:  Kau-Boy                  |       Owner:  coreymckrill
     Type:  enhancement              |      Status:  accepted
 Priority:  normal                   |   Milestone:
Component:  WordCamp Site & Plugins  |  Resolution:
 Keywords:  dev-feedback has-patch   |

Comment (by coreymckrill):

 Replying to [comment:3 Kau-Boy]:
 > - I used the same sanitization as you have done for `tracks`
 Looks good!
 > - I have never added a REST API parameter for a taxonomy and the
 sponsors CPT looks a lot more complex. I would be glad if we could work on
 that together at the WCEU Contributor Day, but it shouldn't be a blocker
 for this ticket, don't you think?
 Agreed, it's not a blocker. I'd be happy to work on it with you at WCEU
 Contributor Day, though I don't think it will be complex. At first glance
 it looks like you only need to add a couple of parameters to the
 `register_taxonomy` call.
 > - The term `groups` is generic, but as it's only used as the shortcode
 args name, it should not conflict with anything. Or am I missing
 something? The rewrite slug for the taxonomy is already `speaker-group`,
 so that should be safe.
 It looks like the `query_var` is also set to `group`. Also, this is very
 minor, but to be consistent with the other types and taxonomies, I think
 it would be better if the rewrite slug was `speaker_group` instead of

Ticket URL: <https://meta.trac.wordpress.org/ticket/2850#comment:6>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org

More information about the wp-meta mailing list