[wp-meta] [Making WordPress.org] #1173: 'Showcase' Not Responsive

Making WordPress.org noreply at wordpress.org
Thu Jul 20 10:24:12 UTC 2017


#1173: 'Showcase' Not Responsive
-------------------------------------------------+-------------------------
 Reporter:  atomicjack                           |       Owner:
     Type:  defect                               |      Status:  new
 Priority:  normal                               |   Milestone:
Component:  General                              |  Resolution:
 Keywords:  ui-feedback has-patch needs-testing  |
  has-screenshots 2nd-opinion                    |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:19 xkon]:
 > Some 1 line edits that are on archive.php are simply tab
 beautifications.

 It's still better to avoid formatting changes unrelated to the issue at
 hand, makes it easier to review the patch :)

 Looks like [attachment:1173.4.diff] reorganizes a lot of CSS rules just to
 put them in alphabetical order. I'd suggest only touching the styles that
 are necessary to fix responsiveness and avoid introducing new conventions
 if possible.

 In WordPress core logical ordering is preferred to an alphabetical one,
 see [https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/css/#property-ordering Property Ordering].

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/1173#comment:20>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list