[wp-meta] [Making WordPress.org] #496: Plugin Directory: Pagination issue in Popular Plugins section

[Making WordPress.org]

#496: Plugin Directory: Pagination issue in Popular Plugins section
------------------------------+------------------------------------
 Reporter:  SergeyBiryukov    |       Owner:  tellyworth
     Type:  defect            |      Status:  reopened
 Priority:  high              |   Milestone:  Plugin Directory v3.0
Component:  Plugin Directory  |  Resolution:
 Keywords:  has-patch         |
------------------------------+------------------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 @cantothemes reported a regression in
 [https://wordpress.slack.com/archives/C1LBM36LC/p1503898471000042
 #pluginreview]. https://wordpress.org/plugins/browse/popular/ still
 displays 3070 pages, leading to an error on 100+:
 {{{
 404 Not Found

 nginx
 }}}

 Caused by [5725]. [source:sites/trunk/wordpress.org/public_html/wp-
 content/plugins/plugin-directory/class-plugin-
 directory.php?rev=5841&marks=672#L662 Plugin_Directory::pre_get_posts()]
 sets `post_type` as an array, so once the `in_array()` check was removed,
 the filter no longer does the job.

 We could either revert [5725] and cast
 `$wp_query->query_vars['post_type']` to an array before comparing,  or
 just use a string in the first place. It looks like there's no need for it
 to be an array, so [attachment:496.2.diff] goes with the latter option and
 uses a strict check while we're at it.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/496#comment:29>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org