[wp-meta] [Making WordPress.org] #1462: Broken Gravatar on Trac

Making WordPress.org noreply at wordpress.org
Thu Nov 17 21:37:24 UTC 2016


#1462: Broken Gravatar on Trac
----------------------------+-----------------------
 Reporter:  SergeyBiryukov  |       Owner:
     Type:  defect          |      Status:  reopened
 Priority:  normal          |   Milestone:
Component:  Trac            |  Resolution:
 Keywords:                  |
----------------------------+-----------------------
Changes (by stephdau):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 @ocean90 : I think dot (.) is missing from the regex in r3140 (`str =
 re.sub(r'[^%a-z0-9\x80-\xff _-]', '', str) `), leading to the user
 `henry.wright` to get the Gravatar for `henrywright` on Trac:
 https://href.li/?https://core.trac.wordpress.org/ticket/38486

 The generated grav redirect URL is:
 https://href.li/?https://wordpress.org/grav-
 redirect.php?user=henrywright&s=96

 Leading to the wrong hash:
 https://secure.gravatar.com/avatar/0f6a8d63a73d65a3e5418b3040bc9b25?s=96&d=retro

 This was reported to us (Automattic) by the user.

 Looks like the Trac integration should match what `grav-redirect.php` is
 itself doing: `[^a-z0-9_. @-]`.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/1462#comment:12>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list