[wp-meta] [Making WordPress.org] #1524: WordPress.org SSO: custom template handling and CSS for login-related screens

[Making WordPress.org]

#1524: WordPress.org SSO: custom template handling and CSS for login-related
screens
--------------------------+---------------------------------------
  Reporter:  stephdau     |      Owner:  stephdau
      Type:  enhancement  |     Status:  assigned
  Priority:  normal       |  Component:  login.wordpress.org
Resolution:               |   Keywords:  has-screenshots has-patch
--------------------------+---------------------------------------
Changes (by stephdau):

 * owner:   => stephdau
 * status:  new => assigned


Comment:

 Replying to [comment:3 ocean90]:
 > I know it's WIP, but `login.scss` looks hard to maintain at its current
 state:
 > * Compass should be avoided, there is no real benefit of it.

 We were having the same conversation on our end, and we're dropping SASS
 in favor of pure CSS.


 > * Some CSS properties have missing vendor prefixes, some have to many.
 [https://github.com/postcss/autoprefixer Autoprefixer] can take care of
 it.

 Nice,thanks.


 > * The [https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/css/ CSS Coding Standards] should be followed like "each
 selector should be on its own line" or "property-value pairs should be on
 their own line".

 cc @mapk


 > I've noticed the `?screen=lostpassword` line in the second screenshot,
 IMO it should be just `/lostpassword` or `/recovery`.

 I was also thinking the same, and is on my plate for today, provided I
 already have handling for /oauth/*.

 Thanks for the feedback.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/1524#comment:11>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org