[wp-meta] [Making WordPress.org] #914: Re-enable skipping duplicate hooks when parsing

Making WordPress.org noreply at wordpress.org
Sun Mar 1 20:55:36 UTC 2015


#914: Re-enable skipping duplicate hooks when parsing
-------------------------+-------------------------------------
Reporter:  DrewAPicture  |      Owner:
    Type:  defect        |     Status:  new
Priority:  normal        |  Component:  developer.wordpress.org
Keywords:  has-patch     |
-------------------------+-------------------------------------
 == Background ==

 In mid-December 2014, the logic that skips parsing duplicate hooks in WP-
 Parser was [https://github.com/rmccue/WP-
 Parser/commit/45ff10ed656ad783b9e68f368d3b208040715170 disabled].
 WordPress core relies on skipping those duplicates so that references
 don't get overwritten with the "This action|filter is documented in ..."
 phrase instead of the intended hook doc.

 It was pointed out this morning by @adamsilverstein, that some references
 were overwritten with the duplicate comment when we re-parsed for 4.1 at
 the end of the year. For instance:
 https://developer.wordpress.org/reference/hooks/_wp_post_revision_field_field/

 == Next Steps ==

 In response to Adam's feedback, I [https://github.com/rmccue/WP-
 Parser/commit/a1e81d6a6b0aa9bb98b205ce9ad52fd94def2e68 added] a new filter
 to WP-Parser to allow us to re-enable skipping of duplicate hooks when
 parsing: `wp_parser_skip_duplicate_hooks`.

 Patch attached for the devhub theme.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/914>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list