[wp-hackers] post_name_check

[Jamie Talbot]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alex,

Yep, you're right, there was no checking to see if a post-name had been
specified.  Your solution is best, and only adds one line before the
post-name replacement replacement:

if ($specified = $_REQUEST['post_name']) return $id;

or somesuch.  Probably don't even need the assignment statement really.
 I think this should cover it:  Do nothing when the user has specified
the post-name themselves and assume they know what they're doing,
otherwise just sanitise the post title as usual.  Like you say, the
other two solutions seem a bit of an overkill.

Cheers for the info!

Jamie.


Alex King wrote:
> Hi Jamie--
> 
> I've run into a problem with Singular: it overwrites any selected post
> slug with the generated slug from the post title.
> 
> I'm looking at 3 possible solutions:
> 
> 1. Check for $_POST['post_name'] which should still be around. (I think
> this is best)
> 2. Retrieve both post_name and post_title and compare them before
> overwriting - could be complicated.
> 3. Retrieve post_name and do some regex to see if the last digit is a
> number, yada-yada-yada.
> 
> I'm going to implement #1 as #2 and 3 seem like poor solutions to me.
> Perhaps the rest of you have better ideas?
> 
> Cheers,
> --Alex
> 
> http://www.alexking.org/
> 
> 
> On Apr 12, 2005, at 5:08 AM, Jamie Talbot wrote:
> 
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Alex King wrote:
>> | Thanks Jamie. I guess this is easier to update than having to re-hack
>> | the source. :)
>> |
> 
> 
> _______________________________________________
> wp-hackers mailing list
> wp-hackers at lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-hackers
> 
> 
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCZNfkrovxfShShFARAskVAJ986ETBSjC6RxSq1N8J5/XIhvdPuwCeN9Mj
hCSrrzahLH/j1pFflWm38Bg=
=mEXg
-----END PGP SIGNATURE-----