<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[2371] 2013/codebykat/post-by-email/trunk: minor stuff and PHP 5.2 compat</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://gsoc.trac.wordpress.org/changeset/2371">2371</a></dd>
<dt>Author</dt> <dd>codebykat</dd>
<dt>Date</dt> <dd>2013-09-23 11:07:02 +0000 (Mon, 23 Sep 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>minor stuff and PHP 5.2 compat</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#2013codebykatpostbyemailtrunkclasspostbyemailadminphp">2013/codebykat/post-by-email/trunk/class-post-by-email-admin.php</a></li>
<li><a href="#2013codebykatpostbyemailtrunkclasspostbyemailphp">2013/codebykat/post-by-email/trunk/class-post-by-email.php</a></li>
<li><a href="#2013codebykatpostbyemailtrunkreadmemd">2013/codebykat/post-by-email/trunk/readme.md</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="2013codebykatpostbyemailtrunkclasspostbyemailadminphp"></a>
<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/class-post-by-email-admin.php (2370 => 2371)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/codebykat/post-by-email/trunk/class-post-by-email-admin.php 2013-09-23 09:15:19 UTC (rev 2370)
+++ 2013/codebykat/post-by-email/trunk/class-post-by-email-admin.php 2013-09-23 11:07:02 UTC (rev 2371)
</span><span class="lines">@@ -247,7 +247,7 @@
</span><span class="cx"> public function show_help_tabs( $screen, $tab ) {
</span><span class="cx"> printf(
</span><span class="cx"> '<p>%s</p>',
</span><del>- __( $tab['callback'][0]::$help_tabs[ $tab['id'] ]['content'], 'post-by-email' )
</del><ins>+ __( self::$help_tabs[ $tab['id'] ]['content'], 'post-by-email' )
</ins><span class="cx"> );
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="2013codebykatpostbyemailtrunkclasspostbyemailphp"></a>
<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/class-post-by-email.php (2370 => 2371)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/codebykat/post-by-email/trunk/class-post-by-email.php 2013-09-23 09:15:19 UTC (rev 2370)
+++ 2013/codebykat/post-by-email/trunk/class-post-by-email.php 2013-09-23 11:07:02 UTC (rev 2371)
</span><span class="lines">@@ -479,6 +479,7 @@
</span><span class="cx"> * @return object
</span><span class="cx"> */
</span><span class="cx"> protected function open_mailbox_connection( $connection_options ) {
</span><ins>+ $options = get_option( 'post_by_email_options' );
</ins><span class="cx"> if ( 'POP3' == $options['mailserver_protocol'] ) {
</span><span class="cx"> $this->protocol = 'POP3';
</span><span class="cx"> $connection = new Horde_Imap_Client_Socket_Pop3( $connection_options );
</span></span></pre></div>
<a id="2013codebykatpostbyemailtrunkreadmemd"></a>
<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/readme.md (2370 => 2371)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/codebykat/post-by-email/trunk/readme.md 2013-09-23 09:15:19 UTC (rev 2370)
+++ 2013/codebykat/post-by-email/trunk/readme.md 2013-09-23 11:07:02 UTC (rev 2371)
</span><span class="lines">@@ -3,6 +3,7 @@
</span><span class="cx"> **Tags:** post-by-email, email
</span><span class="cx"> **Requires at least:** 3.6
</span><span class="cx"> **Tested up to:** 3.7
</span><ins>+**Stable tag:** trunk
</ins><span class="cx"> **License:** GPLv2 or later
</span><span class="cx"> **License URI:** http://www.gnu.org/licenses/gpl-2.0.html
</span><span class="cx">
</span><span class="lines">@@ -19,7 +20,8 @@
</span><span class="cx"> Updates on the project can be found on the [Make WordPress Core blog](http://make.wordpress.org/core/tag/post-by-email/).
</span><span class="cx">
</span><span class="cx">
</span><del>-**Features**
</del><ins>+### Features ###
+
</ins><span class="cx"> * Supports IMAP or POP3 servers, with or without SSL
</span><span class="cx"> * Optional PIN-based authentication guards against email spoofing
</span><span class="cx"> * Uses WordPress's built-in roles to manage which users can post
</span><span class="lines">@@ -65,9 +67,9 @@
</span><span class="cx">
</span><span class="cx"> ### Instructions for specific email services ###
</span><span class="cx">
</span><del>-- Gmail: <a href="https://support.google.com/mail/troubleshooter/1668960?hl=en">This page</a> will walk you through enabling IMAP or POP3 access. When prompted to select an email client for configuration instructions, select "Other" to view the settings.
</del><ins>+- Gmail: <a href="https://support.google.com/mail/troubleshooter/1668960?hl=en">This page</a> will walk you through enabling IMAP or POP3 access. When prompted to select an email client for configuration instructions, select "Other" to view the settings.
</ins><span class="cx">
</span><del>-- Yahoo! Mail: Use these <a href="http://help.yahoo.com/kb/index?page=content&id=SLN4075">IMAP settings</a>; IMAP access should be enabled by default. Mail Plus subscribers can also use these <a href="http://help.yahoo.com/kb/index?locale=en_US&y=PROD_MAIL_ML&page=content&id=SLN4724">POP3 settings</a>.
</del><ins>+- Yahoo! Mail: Use these <a href="http://help.yahoo.com/kb/index?page=content&id=SLN4075">IMAP settings</a>; IMAP access should be enabled by default. Mail Plus subscribers can also use these <a href="http://help.yahoo.com/kb/index?locale=en_US&y=PROD_MAIL_ML&page=content&id=SLN4724">POP3 settings</a>.
</ins><span class="cx">
</span><span class="cx"> - Outlook.com (Hotmail) settings and instructions can be found on <a href="http://windows.microsoft.com/en-ca/windows/outlook/send-receive-from-app">this page</a>.
</span><span class="cx">
</span><span class="lines">@@ -81,7 +83,7 @@
</span><span class="cx"> No, emails are not "forwarded" to your blog. Just like any third-party mail client, Post By Email has to check for new messages, and will only do this once per hour (or when you click the "Check Now" button in the settings). In addition, because of how WordPress' task scheduling (wp_cron) works, this check will only be triggered when a page on your blog has been loaded. There is also sometimes a delay between when messages are sent and when they show up in the mailbox, especially with POP3 access.
</span><span class="cx">
</span><span class="cx"> ### I found a bug! ###
</span><del>-Oh no! I would like to know as much as possible about it so that I can fix it. For the information to include with a bug report, please see <a href="#reporting-bugs">Reporting Bugs</a>.
</del><ins>+Oh no! I would like to know as much as possible about it so that I can fix it. For the information to include with a bug report, please see the Reporting Bugs section in <a href="http://wordpress.org/plugins/post-by-email/other_notes/">Other Notes</a>.
</ins><span class="cx">
</span><span class="cx"> ### What does the error "Bad tagged response" mean? ###
</span><span class="cx"> This probably means you're trying to connect to a POP3 server over the IMAP port, or vice versa. Double-check your server URL, protocol and port number and try again.
</span><span class="lines">@@ -90,10 +92,10 @@
</span><span class="cx"> ## Screenshots ##
</span><span class="cx">
</span><span class="cx"> ###1. Main settings page###
</span><del>-
</del><ins>+
</ins><span class="cx">
</span><span class="cx"> ###2. The activity log###
</span><del>-
</del><ins>+
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx">
</span><span class="lines">@@ -105,7 +107,7 @@
</span><span class="cx">
</span><span class="cx"> To run the unit tests:
</span><span class="cx">
</span><del>-1. Set up the WordPress testing library as described in [Handbook: Automated Testing](http://make.wordpress.org/core/handbook/automated-testing/). You can also do this [using WP-CLI](http://wp-cli.org/blog/plugin-unit-tests.html).
</del><ins>+1. Set up the WordPress testing library as described in [Handbook: Automated Testing](http://make.wordpress.org/core/handbook/automated-testing/). You can also do this [using WP-CLI](http://wp-cli.org/blog/plugin-unit-tests.html).
</ins><span class="cx"> 1. From the plugin directory, run `WP_TESTS_DIR=/path/to/WordPress/test/install phpunit`
</span><span class="cx">
</span><span class="cx"> ### Manual Testing ###
</span><span class="lines">@@ -115,8 +117,7 @@
</span><span class="cx"> 1. Enter those settings into the Post By Email settings and save them.
</span><span class="cx"> 1. Navigate to the "Activity Log" tab and press the "Check Now" button. When the page reloads, you should see a new entry in the log file describing the results of the mail check.
</span><span class="cx">
</span><del>-**Caveat**
-There is sometimes a delay between sending an email and having it show up in the mailbox, especially with POP3. If you're using IMAP, you can connect using a third-party mail client to verify that messages have been received, then mark them as unread so Post By Email will pick them up.
</del><ins>+**Caveat:** There is sometimes a delay between sending an email and having it show up in the mailbox, especially with POP3. If you're using IMAP, you can connect using a third-party mail client to verify that messages have been received, then mark them as unread so Post By Email will pick them up.
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> ## Reporting Bugs ##
</span></span></pre>
</div>
</div>
</body>
</html>