<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[2369] 2013/codebykat/post-by-email/trunk: Better living through science (e.g.</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://gsoc.trac.wordpress.org/changeset/2369">2369</a></dd>

<dt>Author</dt> <dd>codebykat</dd>

<dt>Date</dt> <dd>2013-09-23 08:53:26 +0000 (Mon, 23 Sep 2013)</dd>

</dl>

<h3>Log Message</h3>

<pre>Better living through science (e.g. TESTS)</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#2013codebykatpostbyemailtrunkclasspostbyemailphp">2013/codebykat/post-by-email/trunk/class-post-by-email.php</a></li>

<li><a href="#2013codebykatpostbyemailtrunkpostbyemailphp">2013/codebykat/post-by-email/trunk/post-by-email.php</a></li>

<li><a href="#2013codebykatpostbyemailtrunkreadmemd">2013/codebykat/post-by-email/trunk/readme.md</a></li>

<li><a href="#2013codebykatpostbyemailtrunkreadmetxt">2013/codebykat/post-by-email/trunk/readme.txt</a></li>

<li><a href="#2013codebykatpostbyemailtrunkteststestpostbyemailphp">2013/codebykat/post-by-email/trunk/tests/test-post-by-email.php</a></li>

</ul>

<h3>Added Paths</h3>

<ul>

<li>2013/codebykat/post-by-email/trunk/tests/messages/</li>

<li><a href="#2013codebykatpostbyemailtrunktestsmessagesmessage_with_attachments">2013/codebykat/post-by-email/trunk/tests/messages/message_with_attachments</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="2013codebykatpostbyemailtrunkclasspostbyemailphp"></a>

<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/class-post-by-email.php (2368 => 2369)</h4>

<pre class="diff"><span>

<span class="info">--- 2013/codebykat/post-by-email/trunk/class-post-by-email.php       2013-09-23 03:01:27 UTC (rev 2368)

+++ 2013/codebykat/post-by-email/trunk/class-post-by-email.php  2013-09-23 08:53:26 UTC (rev 2369)

</span><span class="lines">@@ -24,7 +24,7 @@

</span><span class="cx">   *

</span><span class="cx">   * @var     string

</span><span class="cx">   */

</span><del>-       protected $version = '1.0.3';

</del><ins>+        protected $version = '1.0.4';

</ins><span class="cx"> 

</span><span class="cx">  /**

<span class="cx">   * Unique identifier for the plugin.

</span><span class="lines">@@ -244,9 +244,17 @@

</span><span class="cx">          $options['status'] = '';

</span><span class="cx">          update_option( 'post_by_email_options', $options );

</span><span class="cx"> 

</span><del>-               $this->connection = $this->open_mailbox_connection( $options );

</del><ins>+                $connection_options = array(

+                       'username' => $options['mailserver_login'],

+                       'password' => $options['mailserver_pass'],

+                       'hostspec' => $options['mailserver_url'],

+                       'port' => $options['mailserver_port'],

+                       'secure' => $options['ssl'] ? 'ssl' : false,

+               );

</ins><span class="cx"> 

</span><del>-               if (! $this->connection ) {

</del><ins>+                $this->connection = $this->open_mailbox_connection( $connection_options );

+

+               if ( ! $this->connection ) {

</ins><span class="cx">                   return;

</span><span class="cx">          }

</span><span class="cx"> 

</span><span class="lines">@@ -254,7 +262,7 @@

</span><span class="cx"> 

</span><span class="cx">          if ( 0 === sizeof( $uids ) ) {

</span><span class="cx">                  $this->save_log_message( __( 'There doesn&#8217;t seem to be any new mail.', 'post-by-email' ) );

</span><del>-                       $this->connection->shutdown();

</del><ins>+                        $this->close_connection();

</ins><span class="cx">                   return;

</span><span class="cx">          }

</span><span class="cx"> 

</span><span class="lines">@@ -444,7 +452,7 @@

</span><span class="cx">          // mark all processed emails as read

</span><span class="cx">          $this->mark_as_read( $uids, $options['delete_messages'] );

</span><span class="cx"> 

</span><del>-               $this->connection->shutdown();

</del><ins>+                $this->close_connection();

</ins><span class="cx">   }

</span><span class="cx"> 

</span><span class="cx">  /**

</span><span class="lines">@@ -470,21 +478,13 @@

</span><span class="cx">   *

</span><span class="cx">   * @return   object

</span><span class="cx">   */

</span><del>-       protected function open_mailbox_connection( $options ) {

-               $connection_options = array(

-                       'username' => $options['mailserver_login'],

-                       'password' => $options['mailserver_pass'],

-                       'hostspec' => $options['mailserver_url'],

-                       'port' => $options['mailserver_port'],

-                       'secure' => $options['ssl'] ? 'ssl' : false,

-               );

-

</del><ins>+        protected function open_mailbox_connection( $connection_options ) {

</ins><span class="cx">           if ( 'POP3' == $options['mailserver_protocol'] ) {

</span><ins>+                       $this->protocol = 'POP3';

</ins><span class="cx">                   $connection = new Horde_Imap_Client_Socket_Pop3( $connection_options );

</span><del>-                       $this->protocol = 'POP3';

</del><span class="cx">           } else {  // IMAP

</span><ins>+                       $this->protocol = 'IMAP';

</ins><span class="cx">                   $connection = new Horde_Imap_Client_Socket( $connection_options );

</span><del>-                       $this->protocol = 'IMAP';

</del><span class="cx">           }

</span><span class="cx">          $connection->_setInit( 'authmethod', 'USER' );

</span><span class="cx"> 

</span><span class="lines">@@ -500,6 +500,15 @@

</span><span class="cx">  }

</span><span class="cx"> 

</span><span class="cx">  /**

<ins>+       * Closes the connection to the mailserver.

+       *

+       * @since    1.0.4

+       */

+       protected function close_connection() {

+               $this->connection->shutdown();

+       }

+

+       /**

</ins><span class="cx">    * Retrieve the list of new message IDs from the server.

</span><span class="cx">   *

</span><span class="cx">   * @since    1.0.0

</span></span></pre></div>

<a id="2013codebykatpostbyemailtrunkpostbyemailphp"></a>

<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/post-by-email.php (2368 => 2369)</h4>

<pre class="diff"><span>

<span class="info">--- 2013/codebykat/post-by-email/trunk/post-by-email.php     2013-09-23 03:01:27 UTC (rev 2368)

+++ 2013/codebykat/post-by-email/trunk/post-by-email.php        2013-09-23 08:53:26 UTC (rev 2369)

</span><span class="lines">@@ -12,7 +12,7 @@

</span><span class="cx">  * Plugin Name: Post By Email

</span><span class="cx">  * Plugin URI:  http://codebykat.wordpress.com

<span class="cx">  * Description: Create new posts on your WordPress blog by sending email to a specific email address.

</span><del>- * Version:     1.0.3

</del><ins>+ * Version:     1.0.4

</ins><span class="cx">  * Author:      Kat Hagan

</span><span class="cx">  * Author URI:  http://profiles.wordpress.org/codebykat

</span><span class="cx">  * Text Domain: post-by-email

</span></span></pre></div>

<a id="2013codebykatpostbyemailtrunkreadmemd"></a>

<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/readme.md (2368 => 2369)</h4>

<pre class="diff"><span>

<span class="info">--- 2013/codebykat/post-by-email/trunk/readme.md     2013-09-23 03:01:27 UTC (rev 2368)

+++ 2013/codebykat/post-by-email/trunk/readme.md        2013-09-23 08:53:26 UTC (rev 2369)

</span><span class="lines">@@ -126,7 +126,7 @@

</span><span class="cx"> Then, provide as much of the following information as possible:

</span><span class="cx"> 

</span><span class="cx"> 1. WordPress version (e.g. 3.6.x).

</span><del>-1. Plugin version (e.g. 1.0.3).

</del><ins>+1. Plugin version (e.g. 1.0.4).

</ins><span class="cx"> 1. PHP version (e.g. 5.2.x or 5.3.x).

<span class="cx"> 1. Your mailbox settings (URL, protocol, port and whether SSL is enabled; not your login and password).

<span class="cx"> 1. Any error messages displayed (it might help to <a href="http://codex.wordpress.org/WP_DEBUG">enable WP_DEBUG</a> in your wp-config.php).

</span><span class="lines">@@ -139,6 +139,7 @@

<span class="cx"> * Added screenshots, expanded Readme and contextual help.

<span class="cx"> * Added support for user-included gallery shortcode (allows use of WP's gallery options).

<span class="cx"> * Added warning when checking email before changed settings have been saved.

<ins>+* Added more unit tests.

</ins><span class="cx"> * Code style fixes as per http://gsoc.trac.wordpress.org/ticket/377

</span><span class="cx"> * Fixed https://github.com/codebykat/wp-post-by-email/issues/3

</span><span class="cx"> 

</span></span></pre></div>

<a id="2013codebykatpostbyemailtrunkreadmetxt"></a>

<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/readme.txt (2368 => 2369)</h4>

<pre class="diff"><span>

<span class="info">--- 2013/codebykat/post-by-email/trunk/readme.txt    2013-09-23 03:01:27 UTC (rev 2368)

+++ 2013/codebykat/post-by-email/trunk/readme.txt       2013-09-23 08:53:26 UTC (rev 2369)

</span><span class="lines">@@ -3,6 +3,7 @@

</span><span class="cx"> Tags: post-by-email, email

</span><span class="cx"> Requires at least: 3.6

</span><span class="cx"> Tested up to: 3.7

</span><ins>+Stable tag: trunk

</ins><span class="cx"> License: GPLv2 or later

</span><span class="cx"> License URI: http://www.gnu.org/licenses/gpl-2.0.html

</span><span class="cx"> 

</span><span class="lines">@@ -96,7 +97,7 @@

</span><span class="cx"> 

</span><span class="cx"> == Testing ==

</span><span class="cx"> 

</span><del>-### Automated Tests ###

</del><ins>+= Automated Tests =

</ins><span class="cx"> 

<span class="cx"> Like WordPress Core, this plugin includes automated unit tests written in PHPUnit.

</span><span class="cx"> 

</span><span class="lines">@@ -105,15 +106,14 @@

<span class="cx"> 1. Set up the WordPress testing library as described in [Handbook: Automated Testing](http://make.wordpress.org/core/handbook/automated-testing/).  You can also do this [using WP-CLI](http://wp-cli.org/blog/plugin-unit-tests.html).

</span><span class="cx"> 1. From the plugin directory, run `WP_TESTS_DIR=/path/to/WordPress/test/install phpunit`

</span><span class="cx"> 

</span><del>-### Manual Testing ###

</del><ins>+= Manual Testing =

</ins><span class="cx"> 

</span><span class="cx"> 1. Set up a test email address (services such as Gmail work great for this) and enable IMAP or POP3 access.  (Refer to <a href="http://wordpress.org/plugins/post-by-email/installation/">Installation</a> for detailed instructions.)

<span class="cx"> 1. Verify that you are using the correct mailbox settings by using a third-party email client, such as Outlook or OSX Mail.app, to connect to your test mailbox.

<span class="cx"> 1. Enter those settings into the Post By Email settings and save them.

<span class="cx"> 1. Navigate to the "Activity Log" tab and press the "Check Now" button.  When the page reloads, you should see a new entry in the log file describing the results of the mail check.

</span><span class="cx"> 

</span><del>-**Caveat**  

-There is sometimes a delay between sending an email and having it show up in the mailbox, especially with POP3.  If you're using IMAP, you can connect using a third-party mail client to verify that messages have been received, then mark them as unread so Post By Email will pick them up.

</del><ins>+**Caveat:** There is sometimes a delay between sending an email and having it show up in the mailbox, especially with POP3.  If you're using IMAP, you can connect using a third-party mail client to verify that messages have been received, then mark them as unread so Post By Email will pick them up.

</ins><span class="cx"> 

</span><span class="cx"> 

</span><span class="cx"> == Reporting Bugs ==

</span><span class="lines">@@ -123,7 +123,7 @@

</span><span class="cx"> Then, provide as much of the following information as possible:

</span><span class="cx"> 

</span><span class="cx"> 1. WordPress version (e.g. 3.6.x).

</span><del>-1. Plugin version (e.g. 1.0.3).

</del><ins>+1. Plugin version (e.g. 1.0.4).

</ins><span class="cx"> 1. PHP version (e.g. 5.2.x or 5.3.x).