<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[2360] 2013/codebykat/post-by-email/trunk: Added warning when checking email before saving changes to settings</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://gsoc.trac.wordpress.org/changeset/2360">2360</a></dd>
<dt>Author</dt> <dd>codebykat</dd>
<dt>Date</dt> <dd>2013-09-23 02:25:31 +0000 (Mon, 23 Sep 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Added warning when checking email before saving changes to settings</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#2013codebykatpostbyemailtrunkclasspostbyemailadminphp">2013/codebykat/post-by-email/trunk/class-post-by-email-admin.php</a></li>
<li><a href="#2013codebykatpostbyemailtrunkjsadminjs">2013/codebykat/post-by-email/trunk/js/admin.js</a></li>
<li><a href="#2013codebykatpostbyemailtrunkviewsadminphp">2013/codebykat/post-by-email/trunk/views/admin.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="2013codebykatpostbyemailtrunkclasspostbyemailadminphp"></a>
<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/class-post-by-email-admin.php (2359 => 2360)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/codebykat/post-by-email/trunk/class-post-by-email-admin.php 2013-09-23 02:25:28 UTC (rev 2359)
+++ 2013/codebykat/post-by-email/trunk/class-post-by-email-admin.php 2013-09-23 02:25:31 UTC (rev 2360)
</span><span class="lines">@@ -227,12 +227,15 @@
</span><span class="cx">
</span><span class="cx"> wp_enqueue_script( 'post-by-email-admin-js', plugins_url( 'js/admin.js', __FILE__ ), 'jquery', '', true );
</span><span class="cx">
</span><del>- // add nonces
- $nonces = array(
</del><ins>+ // add nonces and JS messages
+ $settings_message = "Your settings have not yet been saved.\nChecking mail now will discard your changes.\nAre you sure you want to do this?";
+
+ $vars = array(
</ins><span class="cx"> 'logNonce' => wp_create_nonce( 'post-by-email-clear-log' ),
</span><span class="cx"> 'pinNonce' => wp_create_nonce( 'post-by-email-generate-pin' ),
</span><ins>+ 'settingsMessage' => __( $settings_message, 'post-by-email' ),
</ins><span class="cx"> );
</span><del>- wp_localize_script( 'post-by-email-admin-js', 'PostByEmailNonces', $nonces );
</del><ins>+ wp_localize_script( 'post-by-email-admin-js', 'PostByEmailVars', $vars );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre></div>
<a id="2013codebykatpostbyemailtrunkjsadminjs"></a>
<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/js/admin.js (2359 => 2360)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/codebykat/post-by-email/trunk/js/admin.js 2013-09-23 02:25:28 UTC (rev 2359)
+++ 2013/codebykat/post-by-email/trunk/js/admin.js 2013-09-23 02:25:31 UTC (rev 2360)
</span><span class="lines">@@ -1,12 +1,15 @@
</span><span class="cx"> jQuery( document ).ready( function() {
</span><span class="cx">
</span><ins>+ // submit buttons start out disabled until changes are made
+ jQuery( 'form#post-by-email-options input[type=submit]' ).attr( 'disabled', 'disabled' );
+
</ins><span class="cx"> // AJAX request to clear the log
</span><span class="cx"> jQuery( 'a#clearLog' ).click( function( e ) {
</span><span class="cx"> e.preventDefault();
</span><span class="cx">
</span><span class="cx"> var data = {
</span><span class="cx"> action: 'post_by_email_clear_log',
</span><del>- security: PostByEmailNonces['logNonce']
</del><ins>+ security: PostByEmailVars['logNonce']
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> jQuery.post( ajaxurl, data, function( response ) {
</span><span class="lines">@@ -21,7 +24,7 @@
</span><span class="cx">
</span><span class="cx"> var data = {
</span><span class="cx"> action: 'post_by_email_generate_pin',
</span><del>- security: PostByEmailNonces['pinNonce']
</del><ins>+ security: PostByEmailVars['pinNonce']
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> jQuery.post( ajaxurl, data, function( response ) {
</span><span class="lines">@@ -71,4 +74,16 @@
</span><span class="cx"> }
</span><span class="cx"> } );
</span><span class="cx">
</span><ins>+ // alert on "Check Now" if settings have been changed but not saved yet
+ jQuery( 'input' ).change( function() {
+ jQuery( 'form#post-by-email-options input[type=submit]' ).removeAttr( 'disabled' );
+
+ jQuery( 'a#post-by-email-check-now' ).click( function(e) {
+ message = jQuery( 'span#post-by-email-settings-changed' ).html();
+ if ( ! confirm( PostByEmailVars['settingsMessage'] ) ) {
+ e.preventDefault();
+ }
+ } );
+ } );
+
</ins><span class="cx"> } );
</span><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="2013codebykatpostbyemailtrunkviewsadminphp"></a>
<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/views/admin.php (2359 => 2360)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/codebykat/post-by-email/trunk/views/admin.php 2013-09-23 02:25:28 UTC (rev 2359)
+++ 2013/codebykat/post-by-email/trunk/views/admin.php 2013-09-23 02:25:31 UTC (rev 2360)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx"> </a>
</span><span class="cx"> </h2>
</span><span class="cx">
</span><del>- <form method="post" action="options.php">
</del><ins>+ <form id="post-by-email-options" method="post" action="options.php">
</ins><span class="cx"> <?php settings_fields( 'post_by_email_options' ); ?>
</span><span class="cx">
</span><span class="cx"> <?php $options = get_option( 'post_by_email_options' ); ?>
</span><span class="lines">@@ -258,7 +258,7 @@
</span><span class="cx"> ?>
</span><span class="cx"> </p>
</span><span class="cx"> <p>
</span><del>- <a href="<?php echo add_query_arg( 'check_mail', true ); ?>" class="button-secondary"
</del><ins>+ <a href="<?php echo add_query_arg( 'check_mail', true ); ?>" class="button-secondary" id="post-by-email-check-now"
</ins><span class="cx"> <?php if ( 'unconfigured' == $options['status'] ) { echo 'disabled'; } ?> >
</span><span class="cx"> <?php _e( 'Check now', 'post-by-email' ); ?>
</span><span class="cx"> </a>
</span></span></pre>
</div>
</div>
</body>
</html>