<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[2330] 2013/codebykat/post-by-email/trunk: Added better validation and proper error reporting when settings fail validation</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://gsoc.trac.wordpress.org/changeset/2330">2330</a></dd>
<dt>Author</dt> <dd>codebykat</dd>
<dt>Date</dt> <dd>2013-09-16 22:25:41 +0000 (Mon, 16 Sep 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Added better validation and proper error reporting when settings fail validation</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#2013codebykatpostbyemailtrunkclasspostbyemailadminphp">2013/codebykat/post-by-email/trunk/class-post-by-email-admin.php</a></li>
<li><a href="#2013codebykatpostbyemailtrunkclasspostbyemailphp">2013/codebykat/post-by-email/trunk/class-post-by-email.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="2013codebykatpostbyemailtrunkclasspostbyemailadminphp"></a>
<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/class-post-by-email-admin.php (2329 => 2330)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/codebykat/post-by-email/trunk/class-post-by-email-admin.php 2013-09-16 20:25:49 UTC (rev 2329)
+++ 2013/codebykat/post-by-email/trunk/class-post-by-email-admin.php 2013-09-16 22:25:41 UTC (rev 2330)
</span><span class="lines">@@ -83,26 +83,44 @@
</span><span class="cx">
</span><span class="cx"> $default_options = Post_By_Email::$default_options;
</span><span class="cx">
</span><del>- $options['mailserver_url'] = trim( $input['mailserver_url'] );
</del><ins>+ /* no validation here, just sanitation */
+ $options['mailserver_url'] = wp_kses_data( strip_tags( $input['mailserver_url'] ) );
+ $options['mailserver_login'] = wp_kses_data( strip_tags( $input['mailserver_login'] ) );
+ $options['mailserver_pass'] = wp_kses_data( strip_tags( $input['mailserver_pass'] ) );
</ins><span class="cx">
</span><span class="cx"> $mailserver_protocol = trim( $input['mailserver_protocol'] );
</span><span class="cx"> if ( in_array( $mailserver_protocol, array( 'POP3', 'IMAP' ) ) ) {
</span><span class="cx"> $options['mailserver_protocol'] = $mailserver_protocol;
</span><ins>+ } else {
+ $error_message .= __( "Could not save protocol: must be POP3 or IMAP.", 'post-by-email' );
+ add_settings_error( 'post_by_email_options',
+ 'post_by_email_options[mailserver_protocol]',
+ $error_message
+ );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // port must be numeric and 16 digits max
</span><span class="cx"> $mailserver_port = trim( $input['mailserver_port'] );
</span><span class="cx"> if ( preg_match('/^[1-9][0-9]{0,15}$/', $mailserver_port ) ) {
</span><del>- $options['mailserver_port'] = $mailserver_port;
</del><ins>+ $options['mailserver_port'] = absint( $mailserver_port );
+ } else {
+ $error_message = __( "Could not save port number: invalid number.", 'post-by-email' );
+ add_settings_error( 'post_by_email_options',
+ 'post_by_email_options[mailserver_port]',
+ $error_message
+ );
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- $options['mailserver_login'] = trim( $input['mailserver_login'] );
- $options['mailserver_pass'] = trim( $input['mailserver_pass'] );
-
</del><span class="cx"> // default email category must be the ID of a real category
</span><span class="cx"> $default_email_category = $input['default_email_category'];
</span><span class="cx"> if ( get_category( $default_email_category ) ) {
</span><span class="cx"> $options['default_email_category'] = $default_email_category;
</span><ins>+ } else {
+ $error_message = __( 'Could not save default category: category not found.', 'post-by-email' );
+ add_settings_error( 'post_by_email_options',
+ 'post_by_email_options[default_email_category]',
+ $error_message
+ );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $options['ssl'] = isset( $input['ssl'] ) && '' != $input['ssl'];
</span><span class="lines">@@ -111,6 +129,25 @@
</span><span class="cx"> $options['pin_required'] = isset( $input['pin_required'] ) && '' != $input['pin_required'];
</span><span class="cx"> $options['pin'] = trim( $input['pin'] );
</span><span class="cx">
</span><ins>+ if ( $options['pin_required'] && '' == $options['pin'] ) {
+ $error_message = __( 'Please enter a security PIN to enable PIN authentication.', 'post-by-email' );
+ add_settings_error( 'post_by_email_options',
+ 'post_by_email_options[mailserver_pin]',
+ $error_message
+ );
+ $options['pin_required'] = false;
+ }
+
+ if( strpos( $options['pin'], ']' ) ) {
+ $error_message = __( 'Error: PIN cannot contain shortcode delimiters.', 'post-by-email' );
+ add_settings_error( 'post_by_email_options',
+ 'post_by_email_options[mailserver_pin]',
+ $error_message
+ );
+ $options['pin'] = '';
+ $options['pin_required'] = false;
+ }
+
</ins><span class="cx"> if ( isset( $input['discard_pending'] ) ) {
</span><span class="cx"> $options['discard_pending'] = ( 'discard' == $input['discard_pending'] );
</span><span class="cx"> }
</span><span class="lines">@@ -207,6 +244,8 @@
</span><span class="cx"> _e( "Post By Email encountered an error. <a href='$settings_url&tab=log'>View the log</a> for details.", 'post-by-email' );
</span><span class="cx"> echo "</p></div>";
</span><span class="cx"> }
</span><ins>+
+ settings_errors( 'post_by_email_options' );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre></div>
<a id="2013codebykatpostbyemailtrunkclasspostbyemailphp"></a>
<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/class-post-by-email.php (2329 => 2330)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/codebykat/post-by-email/trunk/class-post-by-email.php 2013-09-16 20:25:49 UTC (rev 2329)
+++ 2013/codebykat/post-by-email/trunk/class-post-by-email.php 2013-09-16 22:25:41 UTC (rev 2330)
</span><span class="lines">@@ -692,7 +692,7 @@
</span><span class="cx">
</span><span class="cx"> if ( 'attachment' == $p->getDisposition() ) {
</span><span class="cx"> $mime_id = $key;
</span><del>- $filename = $p->getName();
</del><ins>+ $filename = sanitize_file_name( $p->getName() );
</ins><span class="cx"> $filetype = $p->getType();
</span><span class="cx">
</span><span class="cx"> $query2 = new Horde_Imap_Client_Fetch_Query();
</span></span></pre>
</div>
</div>
</body>
</html>