<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[2233] 2013/codebykat/post-by-email/trunk: Workarounds to support PHP 5.2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://gsoc.trac.wordpress.org/changeset/2233">2233</a></dd>
<dt>Author</dt> <dd>codebykat</dd>
<dt>Date</dt> <dd>2013-08-26 03:51:41 +0000 (Mon, 26 Aug 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Workarounds to support PHP 5.2</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#2013codebykatpostbyemailtrunkincludeHordeClientBasephp">2013/codebykat/post-by-email/trunk/include/Horde/Client/Base.php</a></li>
<li><a href="#2013codebykatpostbyemailtrunkincludeHordeExceptionWrappedphp">2013/codebykat/post-by-email/trunk/include/Horde/Exception-Wrapped.php</a></li>
<li><a href="#2013codebykatpostbyemailtrunkincludeHordeMimephp">2013/codebykat/post-by-email/trunk/include/Horde/Mime.php</a></li>
<li><a href="#2013codebykatpostbyemailtrunkviewsadminphp">2013/codebykat/post-by-email/trunk/views/admin.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="2013codebykatpostbyemailtrunkincludeHordeClientBasephp"></a>
<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/include/Horde/Client/Base.php (2232 => 2233)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/codebykat/post-by-email/trunk/include/Horde/Client/Base.php 2013-08-21 14:30:23 UTC (rev 2232)
+++ 2013/codebykat/post-by-email/trunk/include/Horde/Client/Base.php 2013-08-26 03:51:41 UTC (rev 2233)
</span><span class="lines">@@ -829,7 +829,8 @@
</span><span class="cx"> throw new Horde_Imap_Client_Exception_NoSupportExtension('ID');
</span><span class="cx"> }
</span><span class="cx">
</span><del>- $this->_sendID(is_null($info) ? ($this->getParam('id') ?: array()) : $info);
</del><ins>+ /* Modified for WordPress inclusion: The shorthand ternary operator ?: was introduced in PHP 5.3. */
+ $this->_sendID(is_null($info) ? ($this->getParam('id') ? $this->getParam('id') : array()) : $info);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre></div>
<a id="2013codebykatpostbyemailtrunkincludeHordeExceptionWrappedphp"></a>
<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/include/Horde/Exception-Wrapped.php (2232 => 2233)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/codebykat/post-by-email/trunk/include/Horde/Exception-Wrapped.php 2013-08-21 14:30:23 UTC (rev 2232)
+++ 2013/codebykat/post-by-email/trunk/include/Horde/Exception-Wrapped.php 2013-08-26 03:51:41 UTC (rev 2233)
</span><span class="lines">@@ -41,6 +41,13 @@
</span><span class="cx"> $message = (string)$message->getMessage();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- parent::__construct($message, $code, $previous);
</del><ins>+ /* Modified for WordPress inclusion:
+ The "previous" argument was added in PHP 5.3. */
+ if( version_compare( PHP_VERSION, '5.3' ) < 0 ) {
+ parent::__construct($message, $code);
+ }
+ else {
+ parent::__construct($message, $code, $previous);
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="2013codebykatpostbyemailtrunkincludeHordeMimephp"></a>
<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/include/Horde/Mime.php (2232 => 2233)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/codebykat/post-by-email/trunk/include/Horde/Mime.php 2013-08-21 14:30:23 UTC (rev 2232)
+++ 2013/codebykat/post-by-email/trunk/include/Horde/Mime.php 2013-08-26 03:51:41 UTC (rev 2233)
</span><span class="lines">@@ -293,12 +293,12 @@
</span><span class="cx"> switch ($encoding) {
</span><span class="cx"> case 'Q':
</span><span class="cx"> case 'q':
</span><ins>+ /* Modified for WordPress inclusion:
+ passing anonymous functions does not work in PHP 5.2. */
</ins><span class="cx"> $out .= Horde_String::convertCharset(
</span><span class="cx"> preg_replace_callback(
</span><span class="cx"> '/=([0-9a-f]{2})/i',
</span><del>- function($ord) {
- return chr(hexdec($ord[1]));
- },
</del><ins>+ preg_replace_callback_fn,
</ins><span class="cx"> str_replace('_', ' ', $encoded_text)),
</span><span class="cx"> $orig_charset,
</span><span class="cx"> 'UTF-8'
</span><span class="lines">@@ -708,4 +708,7 @@
</span><span class="cx"> return rtrim($decoded, "\0");
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ protected function preg_replace_callback_fn($ord) {
+ return chr(hexdec($ord[1]));
+ }
</ins><span class="cx"> }
</span></span></pre></div>
<a id="2013codebykatpostbyemailtrunkviewsadminphp"></a>
<div class="modfile"><h4>Modified: 2013/codebykat/post-by-email/trunk/views/admin.php (2232 => 2233)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/codebykat/post-by-email/trunk/views/admin.php 2013-08-21 14:30:23 UTC (rev 2232)
+++ 2013/codebykat/post-by-email/trunk/views/admin.php 2013-08-26 03:51:41 UTC (rev 2233)
</span><span class="lines">@@ -96,7 +96,10 @@
</span><span class="cx"> <h2><?php _e( 'Activity Log', 'post-by-email' ) ?></h2>
</span><span class="cx"> <?php
</span><span class="cx"> $options = get_option( 'post_by_email_options' );
</span><del>- $log = $options['log'];
</del><ins>+ $log = null;
+ if( array_key_exists( 'log', $options) ) {
+ $log = $options['log'];
+ }
</ins><span class="cx"> ?>
</span><span class="cx"> <p>
</span><span class="cx"> <?php _e( 'Last checked:', 'post-by-email' ) ?>
</span></span></pre>
</div>
</div>
</body>
</html>