<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[2189] 2013/frederickding/importer/trunk/wordpress-importer.php: Improve UI messages upon completion; see #340.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://gsoc.trac.wordpress.org/changeset/2189">2189</a></dd>
<dt>Author</dt> <dd>frederick.ding</dd>
<dt>Date</dt> <dd>2013-08-06 04:36:50 +0000 (Tue, 06 Aug 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Improve UI messages upon completion; see <a href="http://gsoc.trac.wordpress.org/ticket/340">#340</a>.
- Uses a number of strings that are already localized, like 'All done!'</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#2013frederickdingimportertrunkwordpressimporterphp">2013/frederickding/importer/trunk/wordpress-importer.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="2013frederickdingimportertrunkwordpressimporterphp"></a>
<div class="modfile"><h4>Modified: 2013/frederickding/importer/trunk/wordpress-importer.php (2188 => 2189)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/frederickding/importer/trunk/wordpress-importer.php 2013-08-06 04:19:08 UTC (rev 2188)
+++ 2013/frederickding/importer/trunk/wordpress-importer.php 2013-08-06 04:36:50 UTC (rev 2189)
</span><span class="lines">@@ -373,12 +373,11 @@
</span><span class="cx"> $error = $this->importer->get_error();
</span><span class="cx"> $warnings = $this->importer->get_warnings();
</span><span class="cx"> if(! empty( $warnings ) ) {
</span><ins>+ echo '<h3>';
</ins><span class="cx"> printf(
</span><del>- '<h3>' .
- __(
- 'The import process resulted in %d warnings',
- 'wordpress-importer' ) .
- '</h3><div class="error">', count( $warnings ) );
</del><ins>+ __( 'The import process resulted in %d warnings',
+ 'wordpress-importer' ), count( $warnings ) );
+ echo '</h3><div class="error">';
</ins><span class="cx"> foreach ( $warnings as $warning ) {
</span><span class="cx"> /* @var $warning WP_Error */
</span><span class="cx"> echo '<p>' . $warning->get_error_message() . '</p>';
</span><span class="lines">@@ -387,7 +386,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ( IMPORT_DEBUG ) {
</span><del>- echo '<h4>Debug Data</h4>';
</del><ins>+ echo '<h3>';
+ echo __( 'Debug Data', 'wordpress-importer' );
+ echo '</h3>';
</ins><span class="cx"> echo '<pre>';
</span><span class="cx"> echo _wp_specialchars(
</span><span class="cx"> print_r( get_option( get_class( $this->importer ) ),
</span><span class="lines">@@ -401,6 +402,18 @@
</span><span class="cx"> $this->importer->advance( 'finish' );
</span><span class="cx">
</span><span class="cx"> if ( 'finish' == $this->importer->get_step() ) {
</span><ins>+ echo '<h3>';
+ echo __( 'All done.', 'wordpress-importer' );
+ echo '</h3><p>';
+ if ( count( $this->importer->get_param( 'user_new', array() ) ) > 0 ) {
+ echo __(
+ 'Remember to update the passwords and roles of imported users.',
+ 'wordpress-importer' );
+ echo ' ';
+ }
+ echo __( 'Have fun!', 'wordpress-importer' );
+ echo '</p>';
+
</ins><span class="cx"> $this->import_end();
</span><span class="cx"> } else {
</span><span class="cx"> $this->status_buttons();
</span></span></pre>
</div>
</div>
</body>
</html>