<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[2173] 2013/frederickding/importer/trunk/class-wordpress-importer.php: Add backfill_parents step.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://gsoc.trac.wordpress.org/changeset/2173">2173</a></dd>
<dt>Author</dt> <dd>frederick.ding</dd>
<dt>Date</dt> <dd>2013-07-29 18:37:20 +0000 (Mon, 29 Jul 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add backfill_parents step. See <a href="http://gsoc.trac.wordpress.org/ticket/327">#327</a>.
- Switched to using `wp_update_post()` instead of a direct $wpdb query</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#2013frederickdingimportertrunkclasswordpressimporterphp">2013/frederickding/importer/trunk/class-wordpress-importer.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="2013frederickdingimportertrunkclasswordpressimporterphp"></a>
<div class="modfile"><h4>Modified: 2013/frederickding/importer/trunk/class-wordpress-importer.php (2172 => 2173)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/frederickding/importer/trunk/class-wordpress-importer.php 2013-07-29 06:23:42 UTC (rev 2172)
+++ 2013/frederickding/importer/trunk/class-wordpress-importer.php 2013-07-29 18:37:20 UTC (rev 2173)
</span><span class="lines">@@ -165,6 +165,13 @@
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> *
</span><ins>+ * @see process_parents()
+ * @var array
+ */
+ protected $processed_menu_orphan_items = array();
+
+ /**
+ *
</ins><span class="cx"> * @see fetch_remote_file()
</span><span class="cx"> * @var array
</span><span class="cx"> */
</span><span class="lines">@@ -816,7 +823,7 @@
</span><span class="cx"> if ( isset( $this->processed_menu_items[intval($_menu_item_menu_item_parent)] ) ) {
</span><span class="cx"> $_menu_item_menu_item_parent = $this->processed_menu_items[intval($_menu_item_menu_item_parent)];
</span><span class="cx"> } else if ( $_menu_item_menu_item_parent ) {
</span><del>- $this->menu_item_orphans[intval($item['post_id'])] = (int) $_menu_item_menu_item_parent;
</del><ins>+ $this->processed_menu_orphan_items[intval($item['post_id'])] = (int) $_menu_item_menu_item_parent;
</ins><span class="cx"> $_menu_item_menu_item_parent = 0;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1180,12 +1187,59 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Attempts to associate posts & menu items with previously missing parents.
</ins><span class="cx"> *
</span><del>- * @todo
</del><ins>+ * An imported post's parent may not have been imported when it was first
+ * created, so try again. Also for child menu items and menu items
+ * which were missing the object (e.g. post) they represent in the menu.
</ins><span class="cx"> */
</span><span class="cx"> protected function process_parents() {
</span><del>- $this->advance();
- return true;
</del><ins>+ // find parents for post orphans
+ foreach ( $this->processed_post_orphans as $child_id => $parent_id ) {
+ $local_child_id = $local_parent_id = false;
+ if ( isset( $this->processed_posts[$child_id] ) )
+ $local_child_id = $this->processed_posts[$child_id];
+ if ( isset( $this->processed_posts[$parent_id] ) )
+ $local_parent_id = $this->processed_posts[$parent_id];
+ if ( $local_child_id && $local_parent_id ) {
+ // this used to use $wpdb->update(), but this would be
+ // preferable for a self-contained importer
+ $update = wp_update_post(
+ array(
+ 'ID' => (int) $local_child_id,
+ 'post_parent' => (int) $local_parent_id
+ ), true );
+ if ( is_wp_error( $update ) )
+ $this->warnings[] = new WP_Error(
+ 'import_process_parents_post_warning',
+ sprintf(
+ __(
+ 'Failed to update parent on post orphan with ID %d',
+ 'wordpress-importer' ),
+ $local_child_id ), $update );
+ }
+ }
+
+ // all other posts/terms are imported, retry menu items with missing
+ // associated object
+ foreach ( $this->processed_menu_missing_items as $item )
+ $this->process_menu_item( $item );
+
+ // find parents for menu item orphans
+ foreach ( $this->processed_menu_orphan_items as $child_id => $parent_id ) {
+ $local_child_id = $local_parent_id = 0;
+ if ( isset( $this->processed_menu_items[$child_id] ) )
+ $local_child_id = $this->processed_menu_items[$child_id];
+ if ( isset( $this->processed_menu_items[$parent_id] ) )
+ $local_parent_id = $this->processed_menu_items[$parent_id];
+
+ if ( $local_child_id && $local_parent_id )
+ update_post_meta( $local_child_id,
+ '_menu_item_menu_item_parent', (int) $local_parent_id );
+ }
+
+ $this->advance();
+ return true;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre>
</div>
</div>
</body>
</html>