<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[2139] 2013/frederickding/importer/trunk/tests/test-class-wordpress-importer.php: Add tests for WXR importer; see #332</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://gsoc.trac.wordpress.org/changeset/2139">2139</a></dd>
<dt>Author</dt> <dd>frederick.ding</dd>
<dt>Date</dt> <dd>2013-07-23 05:34:14 +0000 (Tue, 23 Jul 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add tests for WXR importer; see <a href="http://gsoc.trac.wordpress.org/ticket/332">#332</a>
- `test_params()`: tests `set_param()`, `get_param()`, `get_all_params()`
- `test_process_author_mappings_standalone()`: tests irreversible problems
with `process_author_mappings()`
- `test_process_author_mappings_standalone2()`: tests standard operation of
`process_author_mappings()` (separate from previous item due to
irreversibility of error)
- `self::set()`: uses Reflection to set otherwise inaccessible properties</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#2013frederickdingimportertrunkteststestclasswordpressimporterphp">2013/frederickding/importer/trunk/tests/test-class-wordpress-importer.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="2013frederickdingimportertrunkteststestclasswordpressimporterphp"></a>
<div class="modfile"><h4>Modified: 2013/frederickding/importer/trunk/tests/test-class-wordpress-importer.php (2138 => 2139)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/frederickding/importer/trunk/tests/test-class-wordpress-importer.php 2013-07-23 00:17:04 UTC (rev 2138)
+++ 2013/frederickding/importer/trunk/tests/test-class-wordpress-importer.php 2013-07-23 05:34:14 UTC (rev 2139)
</span><span class="lines">@@ -8,7 +8,7 @@
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * Slightly modified from Tests_Import_Import
</span><del>- *
</del><ins>+ *
</ins><span class="cx"> * @see Tests_Import_Import::setUp()
</span><span class="cx"> */
</span><span class="cx"> function setUp() {
</span><span class="lines">@@ -30,7 +30,7 @@
</span><span class="cx"> global $wpdb;
</span><span class="cx"> // crude but effective: make sure there's no residual data in the main
</span><span class="cx"> // tables
</span><del>- foreach ( array(
</del><ins>+ foreach ( array(
</ins><span class="cx"> 'posts',
</span><span class="cx"> 'postmeta',
</span><span class="cx"> 'comments',
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx"> 'term_taxonomy',
</span><span class="cx"> 'term_relationships',
</span><span class="cx"> 'users',
</span><del>- 'usermeta'
</del><ins>+ 'usermeta'
</ins><span class="cx"> ) as $table )
</span><span class="cx"> $wpdb->query( "DELETE FROM {$wpdb->$table}" );
</span><span class="cx"> }
</span><span class="lines">@@ -58,16 +58,16 @@
</span><span class="cx"> // check for hooks
</span><span class="cx"> $this->assertNotEquals( false,
</span><span class="cx"> has_filter( 'cron_schedules',
</span><del>- array(
</del><ins>+ array(
</ins><span class="cx"> $instance,
</span><del>- 'importer_schedule'
</del><ins>+ 'importer_schedule'
</ins><span class="cx"> ) ) );
</span><span class="cx">
</span><span class="cx"> $this->assertNotEquals( false,
</span><span class="cx"> has_action( 'wp_cron_importer_hook',
</span><del>- array(
</del><ins>+ array(
</ins><span class="cx"> $instance,
</span><del>- 'importer_callback'
</del><ins>+ 'importer_callback'
</ins><span class="cx"> ) ) );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -76,7 +76,8 @@
</span><span class="cx"> $vars = $instance->save_vars();
</span><span class="cx">
</span><span class="cx"> $this->assertTrue( $vars );
</span><del>- $this->assertNotEmpty( $options = get_option( get_class( $instance ) ) );
</del><ins>+ $this->assertNotEmpty(
+ $options = get_option( get_class( $instance ) ) );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> public function test_advance() {
</span><span class="lines">@@ -92,60 +93,133 @@
</span><span class="cx"> // valid step
</span><span class="cx"> $this->assertEquals( 'finish', $instance->advance( 'finish' ) );
</span><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> public function test_get_error() {
</span><del>- // clean instance, no errors
- $instance = new WordPress_Importer();
-
- $this->assertNull($instance->get_error());
</del><ins>+ // clean instance, no errors
+ $instance = new WordPress_Importer();
+
+ $this->assertNull( $instance->get_error() );
</ins><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> public function test_get_warnings() {
</span><del>- // clean instance, no warnings
- $instance = new WordPress_Importer();
</del><ins>+ // clean instance, no warnings
+ $instance = new WordPress_Importer();
+
+ $this->assertInternalType( 'array', $instance->get_warnings() );
+ $this->assertEmpty( $instance->get_warnings() );
+ }
</ins><span class="cx">
</span><del>- $this->assertInternalType('array', $instance->get_warnings());
- $this->assertEmpty($instance->get_warnings());
</del><ins>+ public function test_params() {
+ // clean instance, no warnings
+ $instance = new WordPress_Importer();
+ $wxr_file = 'test-nonexistent.xml';
+
+ // can't set without a WXR file defined
+ $this->assertWPError($instance->set_param('name', 'value'));
+
+ // hack it into submission; nothing else will function without a
+ // properly defined wxr_file
+ self::set( $instance, 'wxr_file', $wxr_file );
+
+ $this->assertTrue($instance->set_param('name', 'value'));
+ $this->assertEquals('value', $instance->get_param('name'));
+
+ $this->assertCount(1, $instance->get_all_params());
+ $this->assertArrayHasKey($wxr_file, $instance->get_all_params());
</ins><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> /**
</span><span class="cx"> * @depends test_get_error
</span><span class="cx"> */
</span><span class="cx"> public function test_process_authors_standalone() {
</span><span class="cx"> $instance = new WordPress_Importer();
</span><span class="cx">
</span><del>- $this->assertFalse(self::call($instance, 'process_authors'));
- $this->assertWPError($instance->get_error());
</del><ins>+ $this->assertFalse( self::call( $instance, 'process_authors' ) );
+ $this->assertWPError( $instance->get_error() );
</ins><span class="cx">
</span><span class="cx"> return $instance;
</span><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> /**
</span><span class="cx"> * @depends test_process_authors_standalone
</span><span class="cx"> * @depends test_get_error
</span><span class="cx"> */
</span><del>- public function test_process_author_mappings_standalone(WordPress_Importer $instance) {
-
- $this->assertFalse(self::call($instance, 'process_author_mappings'));
- $this->assertWPError($instance->get_error());
-
</del><ins>+ public function test_process_author_mappings_standalone(
+ WordPress_Importer $instance ) {
+ $this->assertFalse(
+ self::call( $instance, 'process_author_mappings' ) );
+ $this->assertWPError( $instance->get_error() );
</ins><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> /**
</span><del>- * Use Reflection to call otherwise inaccessible methods.
- *
- * Although typically this wouldn't be used, the importer being tested uses
</del><ins>+ * @depends test_process_authors_standalone
+ * @depends test_get_error
+ * @depends test_params
+ */
+ public function test_process_author_mappings_standalone2(
+ WordPress_Importer $instance ) {
+ // hack it into submission; nothing else will function without a
+ // properly defined wxr_file
+ self::set( $instance, 'wxr_file', 'test-nonexistent.xml' );
+
+ $users = array(
+ 'alice' => 1, // alice will be mapped to user ID 1
+ 'bob' => 'john', // bob will be transformed into john
+ 'eve' => false // eve will be imported as is
+ );
+ $i = 0;
+ // each user is either mapped to a given ID, mapped to a new user
+ // with given login or imported using details in WXR file
+ foreach ( $users as $user => $map ) {
+ $authors[$i] = $user;
+ if ( is_int( $map ) )
+ $mapping[$i] = $map;
+ else
+ if ( is_string( $map ) )
+ $new[$i] = $map;
+
+ $i ++;
+ }
+
+ $this->assertTrue(
+ $instance->set_param( 'imported_authors', $authors ) );
+ $this->assertTrue( $instance->set_param( 'user_map', $mapping ) );
+ $this->assertTrue( $instance->set_param( 'user_new', $new ) );
+
+ $this->assertTrue(
+ self::call( $instance, 'process_author_mappings' ) );
+ }
+
+ /**
+ * Uses Reflection to call otherwise inaccessible methods.
+ *
+ * Although typically this wouldn't be used, the importer being tested uses
</ins><span class="cx"> * a number of steps in protected methods.
</span><ins>+ *
+ * @param object $object
+ * @param string $name
+ * @param array $args
+ * optional
+ */
+ protected static function call( $object, $name, array $args = array() ) {
+ $class = new \ReflectionClass( $object );
+ $method = $class->getMethod( $name );
+ $method->setAccessible( true );
+ return $method->invokeArgs( $object, $args );
+ }
+
+ /**
+ * Uses Reflection to set otherwise inaccessible properties.
</ins><span class="cx"> *
</span><span class="cx"> * @param object $object
</span><span class="cx"> * @param string $name
</span><del>- * @param array $args optional
</del><ins>+ * @param mixed $value
</ins><span class="cx"> */
</span><del>- protected static function call($object, $name, array $args = array()) {
- $class = new \ReflectionClass($object);
- $method = $class->getMethod($name);
- $method->setAccessible(true);
- return $method->invokeArgs($object, $args);
</del><ins>+ protected static function set( $object, $name, $value ) {
+ $class = new \ReflectionClass( $object );
+ $variable = $class->getProperty( $name );
+ $variable->setAccessible( true );
+ return $variable->setValue( $object, $value );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>