<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[2140] 2013/frederickding/importer/trunk: Complete standalone test for `process_author_mappings()`; see #332.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://gsoc.trac.wordpress.org/changeset/2140">2140</a></dd>
<dt>Author</dt> <dd>frederick.ding</dd>
<dt>Date</dt> <dd>2013-07-23 06:24:30 +0000 (Tue, 23 Jul 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Complete standalone test for `process_author_mappings()`; see <a href="http://gsoc.trac.wordpress.org/ticket/332">#332</a>.
- Inspired partially by `WP_Import_UnitTestCase::_import_wp()`
- Test user mappings with a) provided user ID; b) provided new username;
c) new user account made from existing username
- Also added `::get()` static function for accessing otherwise inaccessible
object properties using Reflection</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#2013frederickdingimportertrunkclasswordpressimporterphp">2013/frederickding/importer/trunk/class-wordpress-importer.php</a></li>
<li><a href="#2013frederickdingimportertrunkteststestclasswordpressimporterphp">2013/frederickding/importer/trunk/tests/test-class-wordpress-importer.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="2013frederickdingimportertrunkclasswordpressimporterphp"></a>
<div class="modfile"><h4>Modified: 2013/frederickding/importer/trunk/class-wordpress-importer.php (2139 => 2140)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/frederickding/importer/trunk/class-wordpress-importer.php 2013-07-23 05:34:14 UTC (rev 2139)
+++ 2013/frederickding/importer/trunk/class-wordpress-importer.php 2013-07-23 06:24:30 UTC (rev 2140)
</span><span class="lines">@@ -396,7 +396,7 @@
</span><span class="cx"> * emit a warning if the number of mapped authors is fewer than the
</span><span class="cx"> * number of authors identified from the import data.
</span><span class="cx"> */
</span><del>- if ( count( $this->processed_authors ) < count( $this->authors ) ) {
</del><ins>+ if ( count( $this->author_mappings ) < count( $this->authors ) ) {
</ins><span class="cx"> $this->warnings[] = new WP_Error(
</span><span class="cx"> 'import_process_author_mappings_warning',
</span><span class="cx"> __(
</span></span></pre></div>
<a id="2013frederickdingimportertrunkteststestclasswordpressimporterphp"></a>
<div class="modfile"><h4>Modified: 2013/frederickding/importer/trunk/tests/test-class-wordpress-importer.php (2139 => 2140)</h4>
<pre class="diff"><span>
<span class="info">--- 2013/frederickding/importer/trunk/tests/test-class-wordpress-importer.php 2013-07-23 05:34:14 UTC (rev 2139)
+++ 2013/frederickding/importer/trunk/tests/test-class-wordpress-importer.php 2013-07-23 06:24:30 UTC (rev 2140)
</span><span class="lines">@@ -108,24 +108,24 @@
</span><span class="cx"> $this->assertInternalType( 'array', $instance->get_warnings() );
</span><span class="cx"> $this->assertEmpty( $instance->get_warnings() );
</span><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> public function test_params() {
</span><span class="cx"> // clean instance, no warnings
</span><span class="cx"> $instance = new WordPress_Importer();
</span><span class="cx"> $wxr_file = 'test-nonexistent.xml';
</span><span class="cx">
</span><span class="cx"> // can't set without a WXR file defined
</span><del>- $this->assertWPError($instance->set_param('name', 'value'));
</del><ins>+ $this->assertWPError( $instance->set_param( 'name', 'value' ) );
</ins><span class="cx">
</span><span class="cx"> // hack it into submission; nothing else will function without a
</span><span class="cx"> // properly defined wxr_file
</span><span class="cx"> self::set( $instance, 'wxr_file', $wxr_file );
</span><span class="cx">
</span><del>- $this->assertTrue($instance->set_param('name', 'value'));
- $this->assertEquals('value', $instance->get_param('name'));
</del><ins>+ $this->assertTrue( $instance->set_param( 'name', 'value' ) );
+ $this->assertEquals( 'value', $instance->get_param( 'name' ) );
</ins><span class="cx">
</span><del>- $this->assertCount(1, $instance->get_all_params());
- $this->assertArrayHasKey($wxr_file, $instance->get_all_params());
</del><ins>+ $this->assertCount( 1, $instance->get_all_params() );
+ $this->assertArrayHasKey( $wxr_file, $instance->get_all_params() );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="lines">@@ -152,42 +152,70 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><del>- * @depends test_process_authors_standalone
</del><span class="cx"> * @depends test_get_error
</span><span class="cx"> * @depends test_params
</span><span class="cx"> */
</span><del>- public function test_process_author_mappings_standalone2(
- WordPress_Importer $instance ) {
- // hack it into submission; nothing else will function without a
- // properly defined wxr_file
- self::set( $instance, 'wxr_file', 'test-nonexistent.xml' );
-
</del><ins>+ public function test_process_author_mappings_standalone2() {
+ $admin_user = wp_create_user( 'admin', rand_str( 12 ) );
+ $this->assertNotInstanceOf( 'WP_Error', $admin_user );
</ins><span class="cx"> $users = array(
</span><del>- 'alice' => 1, // alice will be mapped to user ID 1
</del><ins>+ 'alice' => $admin_user, // alice will be mapped to user ID whatever
</ins><span class="cx"> 'bob' => 'john', // bob will be transformed into john
</span><span class="cx"> 'eve' => false // eve will be imported as is
</span><span class="cx"> );
</span><del>- $i = 0;
</del><ins>+ $_i = 0;
+ $authors = $mapping = $new = array();
</ins><span class="cx"> // each user is either mapped to a given ID, mapped to a new user
</span><span class="cx"> // with given login or imported using details in WXR file
</span><del>- foreach ( $users as $user => $map ) {
- $authors[$i] = $user;
- if ( is_int( $map ) )
- $mapping[$i] = $map;
- else
- if ( is_string( $map ) )
- $new[$i] = $map;
</del><ins>+ foreach ( $users as $_user => $_map ) {
+ $authors[$_i] = $_user;
+ if ( is_int( $_map ) )
+ $mapping[$_i] = $_map;
+ elseif ( is_string( $_map ) )
+ $new[$_i] = $_map;
</ins><span class="cx">
</span><del>- $i ++;
</del><ins>+ $_i ++;
</ins><span class="cx"> }
</span><ins>+ unset( $_i );
</ins><span class="cx">
</span><ins>+ $instance = new WordPress_Importer();
+ // hack it into submission; nothing else will function without a
+ // properly defined wxr_file
+ self::set( $instance, 'wxr_file', 'test-nonexistent.xml' );
</ins><span class="cx"> $this->assertTrue(
</span><ins>+ $instance->set_param( 'admin_user_id', $admin_user ) );
+ $this->assertTrue( $instance->is_allowed_user_creation() );
+
+ // set the parameters necessary for the process to run
+ $this->assertTrue(
</ins><span class="cx"> $instance->set_param( 'imported_authors', $authors ) );
</span><span class="cx"> $this->assertTrue( $instance->set_param( 'user_map', $mapping ) );
</span><span class="cx"> $this->assertTrue( $instance->set_param( 'user_new', $new ) );
</span><span class="cx">
</span><ins>+ // running the mapping process should be successful, no error/warnings
</ins><span class="cx"> $this->assertTrue(
</span><span class="cx"> self::call( $instance, 'process_author_mappings' ) );
</span><ins>+ $this->assertNull( $instance->get_error() );
+ $this->assertCount( 0, $instance->get_warnings() );
+
+ // since this test case is run by itself without the benefit of
+ // a predecessor process_authors(), no author IDs will be "processed"
+ $this->assertCount( 0, self::get( $instance, 'processed_authors' ) );
+
+ // however, mappings will exist for all provided users
+ $this->assertCount( count( $users ),
+ $author_mappings = self::get( $instance, 'author_mappings' ) );
+ $this->assertEquals( array_keys( $users ),
+ array_keys( $author_mappings ) );
+ foreach ( $author_mappings as $username => $map ) {
+ $_user = get_user_by( 'id', $map );
+ $this->assertInstanceOf( 'WP_User', $_user );
+ }
+
+ // ... and, if a mapping was set by user decision, it should match
+ $this->assertEquals( current( $mapping ), $author_mappings['alice'] );
+ $this->assertEquals( get_user_by( 'login', $users['bob'] )->ID,
+ $author_mappings['bob'] );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="lines">@@ -210,10 +238,10 @@
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * Uses Reflection to set otherwise inaccessible properties.
</span><del>- *
- * @param object $object
- * @param string $name
- * @param mixed $value
</del><ins>+ *
+ * @param object $object
+ * @param string $name
+ * @param mixed $value
</ins><span class="cx"> */
</span><span class="cx"> protected static function set( $object, $name, $value ) {
</span><span class="cx"> $class = new \ReflectionClass( $object );
</span><span class="lines">@@ -221,5 +249,19 @@
</span><span class="cx"> $variable->setAccessible( true );
</span><span class="cx"> return $variable->setValue( $object, $value );
</span><span class="cx"> }
</span><ins>+
+ /**
+ * Uses Reflection to get otherwise inaccessible properties.
+ *
+ * @param object $object
+ * @param string $name
+ * @throws \ReflectionException
+ */
+ protected static function get( $object, $name ) {
+ $class = new \ReflectionClass( $object );
+ $variable = $class->getProperty( $name );
+ $variable->setAccessible( true );
+ return $variable->getValue( $object );
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>