[wp-gsoc] [Summer of Code] #371: Make updates as per Justin

[Summer of Code]

#371: Make updates as per Justin
---------------------------+------------------------------
 Reporter:  codebykat      |      Owner:  codebykat
     Type:  defect         |     Status:  new
 Priority:  normal         |  Milestone:  2013 Final (1.0)
Component:  Post by Email  |   Keywords:
---------------------------+------------------------------
 Here are some thoughts after doing a code review. All minorish things:

 * if( )

 should be

 if ( )

 * Spacing in the array is a little off at
 http://plugins.trac.wordpress.org/browser/post-by-email/trunk/class-post-
 by-email.php#L370
 * Spacing in $default_options is off
 http://plugins.trac.wordpress.org/browser/post-by-email/trunk/class-post-
 by-email.php#L66

 * // use admin if no author found
 $post_author = 1;


 * Admin may not always be '1'. User ID '1' could no longer exist, or no
 longer be an admin.

 * Some comments reference "WPMU" (probably left over from old PBE code) -
 might be good to take the time to update these to say multisite.

 * Missing textdomain here: http://plugins.trac.wordpress.org/browser/post-
 by-email/trunk/class-post-by-email-admin.php#L132

 * May be like this in other places but
 http://plugins.trac.wordpress.org/browser/post-by-email/trunk/class-post-
 by-email-admin.php#L167
 the way we do this is 'unconfigured' == $options['status'] rather then
 $options['status'] == 'unconfigured'

 * In http://plugins.trac.wordpress.org/browser/post-by-
 email/trunk/views/admin.php#L128 and similar places look at using
 http://codex.wordpress.org/Function_Reference/selected or
 http://codex.wordpress.org/Function_Reference/checked

 * http://plugins.trac.wordpress.org/browser/post-by-
 email/trunk/views/admin.php#L170 should be esc_attr_e

--
Ticket URL: <http://gsoc.trac.wordpress.org/ticket/371>
Summer of Code <http://gsoc.trac.wordpress.org>
My example project