<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Hi Otto,</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">I’m sorry we didn’t test out the Theme Check plugin sooner. Thanks for making that quick code tweak. It's correctly ignoring my function now. I also understand the add_setting issue, and I’ve managed to find a workaround for it.</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Thanks,</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Corey</div> <br><p style="color:#000;">On October 23, 2014 at 1:27:52 PM, Otto (<a href="mailto:otto@ottodestruct.com">otto@ottodestruct.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>
<title></title>
<div dir="ltr">
<div>WRT the register_post_type, I made a change to the check to
make it slightly more accurate in determining what looks like
function calls instead of simple string matching. You can use the
development version of the theme-check plugin to test and see if
this adjustment works to solve your issue: <a href="https://wordpress.org/plugins/theme-check/developers/">https://wordpress.org/plugins/theme-check/developers/</a> </div>
<div><br></div>
<div>Please test this version of the plugin. I need positive
confirmation from you that this fix works before I move it into
production on the .org uploader.<br></div>
<div class="gmail_extra">
<div><br></div>
<div>For the Customizer add_setting issue, there won't be a fix.
Don't put your argument data in a variable like that, just pass
them directly inside the function call. There is no realistic way
to write code which can parse your arbitrary variables or other
things of that nature and determine whether or not you are actually
using sanitization callbacks. And since this is an important
security precaution, the check is a necessary one. So, change your
code to put the parameters right there where the function call
is.</div>
<div><br></div>
<div>-Otto</div>
<div><br></div>
<div><br></div>
<div><br></div>
<div><br></div>
<br>
<div class="gmail_quote">On Thu, Oct 23, 2014 at 3:26 PM, Corey
McKrill <span dir="ltr"><<a href="mailto:cmckrill@jestro.com" target="_blank">cmckrill@jestro.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<div style="margin:0px">I’m running into a similar issue with the
same theme check rule that Sami encountered. I have a function
called register_post_type_support_for_builder(). It does not
register a custom post type. Unfortunately, I can't easily rename
it because it's a helper function for developers to use that's been
in for several versions, so changing it now could cause sites to
fatal.</div>
<div style="margin:0px"><br></div>
<div style="margin:0px">I'm also getting this error:</div>
<div style="margin:0px"><br></div>
<div style="margin:0px">REQUIRED: Found a Customizer setting that
did not have a sanitization callback function. Every call to the
add_setting() method needs to have a sanitization callback function
passed.</div>
<div style="margin:0px"><br></div>
<div style="margin:0px">I have verified that all of my settings
have a sanitization callback. However, the parameters for each
setting are stored in a variable rather than being fed into the
add_setting() method inline.</div>
<div style="margin:0px"><br></div>
<div style="margin:0px">Given that both of these are false
positives, is there another way I can get my theme update
submitted?</div>
<div style="margin:0px"><br></div>
<div style="margin:0px">Thanks,</div>
</div>
<div>
<div style="font-family:helvetica,arial;font-size:13px"><br>
Corey</div>
<div style="font-family:helvetica,arial;font-size:13px">The Theme
Foundry | <a href="https://thethemefoundry.com" target="_blank">https://thethemefoundry.com</a></div>
</div>
<div>
<div class="h5"><br>
<p style="color:#000">On October 22, 2014 at 8:56:06 AM, Sami
Keijonen (<a href="mailto:sami.keijonen@foxnet.fi" target="_blank">sami.keijonen@foxnet.fi</a>) wrote:</p>
<blockquote type="cite">
<div>
<div>
<div dir="ltr"><span>Yep, updated already and sent new
version.<br></span>
<div class="gmail_extra"><span><br></span>
<div class="gmail_quote"><span>On 22 October 2014 19:54, Justin
Tadlock <span dir="ltr"><<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>></span>
wrote:<br></span>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">I just do a check if the post type exists rather
than the function name myself.</div>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>
<div>
<div>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div dir="ltr">
<div><span><font color="#888888"><br></font></span></div>
</div>
</div>
</blockquote>
</div>
<br clear="all">
<div><br></div>
--<br>
<div dir="ltr">Sami Keijonen<br>
Fox Holding Oy<br>
<a href="mailto:sami.keijonen@foxnet.fi" target="_blank">sami.keijonen@foxnet.fi</a><br>
<a href="http://foxnet.fi" target="_blank">foxnet.fi</a>
<div><a href="https://foxland.fi/" target="_blank">https://foxland.fi/</a><br>
<div><br></div>
</div>
</div>
</div>
</div>
</div>
<br></div>
</div>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote>
</div>
<br></div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote>
</div>
<br>
<br clear="all">
<div><br></div>
--<br>
<div dir="ltr">Sami Keijonen<br>
Fox Holding Oy<br>
<a href="mailto:sami.keijonen@foxnet.fi" target="_blank">sami.keijonen@foxnet.fi</a><br>
<a href="http://foxnet.fi" target="_blank">foxnet.fi</a>
<div><a href="https://foxland.fi/" target="_blank">https://foxland.fi/</a><br>
<div><br></div>
</div>
</div>
</div>
</div>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div>
</div>
</blockquote>
</div>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote>
</div>
<br></div>
</div>
_______________________________________________
<br>theme-reviewers mailing list
<br>theme-reviewers@lists.wordpress.org
<br>http://lists.wordpress.org/mailman/listinfo/theme-reviewers
<br></div></div></span></blockquote></body></html>