<div dir="ltr">Why am I only hearing about these issues now? The theme check plugin was released with the latest code over 3 weeks ago, and I asked for testers here 2 weeks before that. I gave it three weeks after release before I moved the code into production on WordPress.org, and I didn't hear anything about these problems before that.<div><br></div><div>Right now, I'm getting ready to leave for WCSF tomorrow, and I'll likely be there all week. I will try to take a look at it, but for now, you simply can't upload your theme because it doesn't pass the theme-check process, and nobody told me about these issues for well over a month.</div><div><br></div><div>If there is a problem, telling somebody about it sooner is probably a good idea.</div><div><br></div><div><br></div></div><div class="gmail_extra"><br clear="all"><div>-Otto</div>
<br><div class="gmail_quote">On Thu, Oct 23, 2014 at 3:26 PM, Corey McKrill <span dir="ltr"><<a href="mailto:cmckrill@jestro.com" target="_blank">cmckrill@jestro.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto"><div style="margin:0px">I’m running into a similar issue with the same theme check rule that Sami encountered. I have a function called register_post_type_support_for_builder(). It does not register a custom post type. Unfortunately, I can't easily rename it because it's a helper function for developers to use that's been in for several versions, so changing it now could cause sites to fatal.</div><div style="margin:0px"><br></div><div style="margin:0px">I'm also getting this error:</div><div style="margin:0px"><br></div><div style="margin:0px">REQUIRED: Found a Customizer setting that did not have a sanitization callback function. Every call to the add_setting() method needs to have a sanitization callback function passed.</div><div style="margin:0px"><br></div><div style="margin:0px">I have verified that all of my settings have a sanitization callback. However, the parameters for each setting are stored in a variable rather than being fed into the add_setting() method inline.</div><div style="margin:0px"><br></div><div style="margin:0px">Given that both of these are false positives, is there another way I can get my theme update submitted?</div><div style="margin:0px"><br></div><div style="margin:0px">Thanks,</div></div> <div><div style="font-family:helvetica,arial;font-size:13px"><br>Corey</div><div style="font-family:helvetica,arial;font-size:13px">The Theme Foundry | <a href="https://thethemefoundry.com" target="_blank">https://thethemefoundry.com</a></div></div><div><div class="h5"> <br><p style="color:#000">On October 22, 2014 at 8:56:06 AM, Sami Keijonen (<a href="mailto:sami.keijonen@foxnet.fi" target="_blank">sami.keijonen@foxnet.fi</a>) wrote:</p> <blockquote type="cite"><span><div><div></div><div>






<div dir="ltr">Yep, updated already and sent new version.<br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 22 October 2014 19:54, Justin Tadlock
<span dir="ltr"><<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">I just do a check if the post type exists rather
than the function name myself.</div>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>
<div>
<div>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div dir="ltr">
<div><span><font color="#888888"><br></font></span></div>
</div>
</div>
</blockquote>
</div>
<br clear="all">
<div><br></div>
--<br>
<div dir="ltr">Sami Keijonen<br>
Fox Holding Oy<br>
<a href="mailto:sami.keijonen@foxnet.fi" target="_blank">sami.keijonen@foxnet.fi</a><br>
<a href="http://foxnet.fi" target="_blank">foxnet.fi</a>
<div><a href="https://foxland.fi/" target="_blank">https://foxland.fi/</a><br>
<div><br></div>
</div>
</div>
</div>
</div>
</div>
<br></div>
</div>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>

<br></blockquote>
</div>
<br></div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>

<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>

<br></blockquote>
</div>
<br>
<br clear="all">
<div><br></div>
--<br>
<div dir="ltr">Sami Keijonen<br>
Fox Holding Oy<br>
<a href="mailto:sami.keijonen@foxnet.fi" target="_blank">sami.keijonen@foxnet.fi</a><br>
<a href="http://foxnet.fi" target="_blank">foxnet.fi</a>
<div><a href="https://foxland.fi/" target="_blank">https://foxland.fi/</a><br>
<div><br></div>
</div>
</div>
</div>
</div>


_______________________________________________
<br>theme-reviewers mailing list
<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
<br></div></div></span></blockquote></div></div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>