<HTML><HEAD></HEAD>
<BODY dir=ltr>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: 12pt">
<DIV>That’s nice, but comment_popup_link() only works on the
is_home/is_front_page while plugin authors and others who create unique loops
that need to work elsewhere are apparently going to be out of luck.</DIV>
<DIV> </DIV>
<DIV>Say for example someone wants to put a comments link at the top of the post
itself and the post is quite long, it will not work if there are no comments
since #comments doesn’t exist. It will not auto-realign to the comments
area because comments_popup_link will not appear on the singles</DIV>
<DIV> </DIV>
<DIV>But hey, whatever you want. Just pointing out a flaw in the
system.</DIV>
<DIV> </DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV style="FONT: 10pt tahoma">
<DIV> </DIV>
<DIV style="BACKGROUND: #f5f5f5">
<DIV style="font-color: black"><B>From:</B> <A title=justin@justintadlock.com
href="mailto:justin@justintadlock.com">Justin Tadlock</A> </DIV>
<DIV><B>Sent:</B> Thursday, October 23, 2014 8:37 AM</DIV>
<DIV><B>To:</B> <A title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org">Discussion list for WordPress
theme reviewers.</A> </DIV>
<DIV><B>Subject:</B> Re: [theme-reviewers] Friendly request? About themes
commentssection</DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV dir=ltr>
<DIV>If you go back and look at some of the original themes or even in the
`wp-includes/theme-compat/comments.php`, you'll notice this is how it's done and
has always been done as far as I can remember. The `#comments` section
isn't shown until there are actual comments. </DIV>
<DIV> </DIV>
<DIV>This is why I'd consider `comments_link()` and `get_comments_link()` the
inappropriate functions when there are no comments for the post. You'd be
linking to something that does not yet exist.</DIV>
<DIV> </DIV>
<DIV>I'd use `comments_popup_link()` instead, which will display a link to
either `#comments` or `#respond` depending on the situation. This function
also takes into account things like whether comments are open, pings are open,
or a password is required before showing the link. </DIV>
<DIV> </DIV></DIV>
<DIV class=gmail_extra>
<DIV> </DIV>
<DIV class=gmail_quote>On Thu, Oct 23, 2014 at 5:47 AM, Philip M. Hofer (Frumph)
<SPAN dir=ltr><<A href="mailto:philip@frumph.net"
target=_blank>philip@frumph.net</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>comments_link() get_comments_link() appends
#comments to the end of the url<BR><BR>If the comments section
displaying on the single pages/posts does not have a id="comments" then the
comments_link appending of the #comments is worthless .. I see quite a few
themes that only have the #respond section but not the wrapper around it for
#comments<BR><BR>The most common reason is that dev's have it so that it's in
the part of the comments.php section that only shows up when the post actually
has a comment made for it ..<BR><BR>^ which it shouldn't, then it's not seen
or used as a ref. for the #comments in the comments_link; it
should be the class for the wrapper for the whole entire comments section - or
at least shown as a marker location regardless if the post has comments or
not<BR><BR>-
Phil<BR><BR><BR><BR><BR><BR><BR><BR>______________________________<U></U>_________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.<U></U>wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/<U></U>mailman/listinfo/theme-<U></U>reviewers</A><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV>
<P>
<HR>
_______________________________________________<BR>theme-reviewers mailing
list<BR>theme-reviewers@lists.wordpress.org<BR>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR></DIV></DIV></DIV></BODY></HTML>