<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">If you need help, please request a mentor :)<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 20, 2014 at 10:22 AM, Venkat Raj <span dir="ltr"><<a href="mailto:venkat@webulous.in" target="_blank">venkat@webulous.in</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    It is options framework, but it doesn't matter. I meant to say any
    "bundled resource"<br>
    Checking everything makes sense and we should.<br>
    <br>
    My concern is that, say we have 2 embedded resource then 1 theme
    review = 1 theme code + 2 plug-in code review?<br>
    I think admins can make a rule for this, because<br>
    1) We're already atleast 6 week behind <br>
    2) New comers like me, don't have much experience in reviewing
    plugin code and security issues.<div><div class="h5"><br>
    <br>
    <br>
    <div>On Monday 20 October 2014 08:34 PM,
      Emil Uzelac wrote:<br>
    </div>
    <blockquote type="cite">
      <div dir="ltr">
        <div class="gmail_default" style="font-family:arial,helvetica,sans-serif">If you are
          referring to <a href="http://wptheming.com/options-framework-plugin/" target="_blank">http://wptheming.com/options-framework-plugin/</a>
          I don't think that phoning home is involved.</div>
        <div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br>
        </div>
        <div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Now, it does
          not matter if the code was integrated as-is, or has been
          modified, we still need to check everything :)</div>
      </div>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On Mon, Oct 20, 2014 at 8:59 AM, Jasin
          S. <span dir="ltr"><<a href="mailto:jasins@wphoot.com" target="_blank">jasins@wphoot.com</a>></span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div dir="ltr">
              <div>
                <div>^ what tskk said.<br>
                  <br>
                </div>
                A good starting point would be using diff to check if
                the Options framework has been inserted "as-is" in the
                theme, or if its a modified version (maybe even
                malicious code)<br>
                <br>
              </div>
              I find Sublimerge to be an awesome tool for this
              (available on Sublime Text editor)<br>
              <div>
                <div>
                  <div>
                    <div>
                      <div class="gmail_extra"><br clear="all">
                        <div>
                          <div dir="ltr"><span><font color="#888888"><span style="color:rgb(0,0,0)"></span></font></span><span style="color:rgb(0,0,0)"><span style="font-family:courier new,monospace">cheers,<br>
                              </span></span><span><font color="#888888">
                                <div dir="ltr"><span style="font-family:courier new,monospace"><span style="color:rgb(0,0,0)">Jasin S.</span><br>
                                  </span><span style="font-family:courier new,monospace"><span style="color:rgb(153,153,153)"></span></span></div>
                              </font></span></div>
                        </div>
                        <div>
                          <div><br>
                            <div class="gmail_quote">
                              <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Is that
                                framework included in the theme zip? If
                                it is then you have to review it.<br>
                                Sent from BlackBerry® on Airtel<br>
                                <div>
                                  <div><br>
                                    -----Original Message-----<br>
                                    From: Venkat Raj <<a href="mailto:venkat@webulous.in" target="_blank">venkat@webulous.in</a>><br>
                                    Sender: "theme-reviewers" <<a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a>>Date:
                                    Mon, 20 Oct 2014 11:55:24<br>
                                    To: theme >> Discussion list
                                    for WordPress theme reviewers.<<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>><br>
                                    Reply-To: "Discussion list for
                                    WordPress theme reviewers."<br>
                                     <<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>><br>
                                    Subject: [theme-reviewers] Embedded
                                    theme options frameworks and/or
                                    resources<br>
                                    <br>
                                    I'm reviewing a theme which embeds
                                    options framework.<br>
                                    My question is, since it is bundled
                                    resource, I don't need to go through<br>
                                    it line by line, right?<br>
                                    Plugin reviewer can take care of
                                    that. But how can I make sure, it is<br>
                                    not modified version of original<br>
                                    and/or not containing any malicious
                                    code such as dialling home which we<br>
                                    encountered few days back!<br>
                                    <br>
_______________________________________________<br>
                                    theme-reviewers mailing list<br>
                                    <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
                                    <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
_______________________________________________<br>
                                    theme-reviewers mailing list<br>
                                    <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
                                    <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
                                  </div>
                                </div>
                              </blockquote>
                            </div>
                            <br>
                          </div>
                        </div>
                      </div>
                    </div>
                  </div>
                </div>
              </div>
            </div>
            <br>
            _______________________________________________<br>
            theme-reviewers mailing list<br>
            <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
            <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
            <br>
          </blockquote>
        </div>
        <br>
      </div>
      <br>
      <fieldset></fieldset>
      <br>
      <pre>_______________________________________________
theme-reviewers mailing list
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
    </blockquote>
    <br>
  </div></div></div>

<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>