<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Sounds good :) </div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">You can also reply in the ticket directly, instead of here.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Emil</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Oct 18, 2014 at 7:16 PM, Edward R. Jenkins <span dir="ltr"><<a href="mailto:erjenkins1@gmail.com" target="_blank">erjenkins1@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p>Thanks for the comments. I'll get these corrected next week.</p><div class="HOEnZb"><div class="h5">
<div class="gmail_quote">On Oct 18, 2014 7:38 PM, "WordPress Themes" <<a href="mailto:noreply@wordpress.org" target="_blank">noreply@wordpress.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">#21261: THEME: NewsFrame - 2.3<br>
----------------------------+---------------------<br>
Reporter: cardiganmedia | Owner: Milmor<br>
Type: theme | Status: closed<br>
Priority: theme update | Resolution: live<br>
Keywords: theme-newsframe |<br>
----------------------------+---------------------<br>
Changes (by emiluzelac):<br>
<br>
* status: approved => closed<br>
* resolution: => live<br>
<br>
<br>
Comment:<br>
<br>
Please fix the following:<br>
<br>
- {{{esc_url(home_url())}}} is missing {{{/}}}.<br>
- Theme loads {{{load_theme_textdomain( 'newsframe',<br>
get_template_directory() . '/languages' );}}} but there is nothing in that<br>
folder.<br>
- Latest version does not use textdomain like you did for the rest of the<br>
files {{{<?php _e ('Whoops. The page you were looking for has gone<br>
extinct. Maybe you can find what you were looking for below.'); ?>}}}.<br>
When author decides to localize, all parts should be included.<br>
- Also <a href="https://themes.svn.wordpress.org/newsframe/2.3/inc/index-nav.php" target="_blank">https://themes.svn.wordpress.org/newsframe/2.3/inc/index-nav.php</a><br>
uses unrelated textdomain {{{bartleby}}}.<br>
- Themes must properly use dates: {{{get_option( 'date_format' )}}} and<br>
{{{get_option( 'time_format' )}}}, unless an explicit design decision<br>
requires use of a custom output for {{{the_date()}}} or {{{the_time()}}}.<br>
----<br>
I will mark your theme live with the hope that mentioned issues are<br>
corrected and submitted at your convenience.<br>
<br>
Thanks!<br>
<br>
--<br>
Ticket URL: <<a href="https://themes.trac.wordpress.org/ticket/21261#comment:3" target="_blank">https://themes.trac.wordpress.org/ticket/21261#comment:3</a>><br>
WordPress Themes <<a href="https://themes.trac.wordpress.org/" target="_blank">https://themes.trac.wordpress.org/</a>><br>
WordPress.org Theme Directory Reviews<br>
</blockquote></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>