<div dir="ltr">Sorry if I got the mailing list bit wrong. I was on digest, but just turned it off. If nothing else, it shows what a barrier it is for potential contributors like myself who want to contribute to improving the quality of the Unit Tests, but not be a part of the wider TRT.<div><br></div><div>I did join this list a year or so ago and highlighted a few different problems with the Unit Tests that you then fixed. I've got no idea what they were, and nor would anyone else, unless they knew what to search for and when. A public repo (GitHub, BitBucket, Trac SVN) with associated Issues / Tickets would mean all future information is consolidated in one place, not tucked within a mailing list archive.<div><br></div><div>I saw the discussion about administration / owner of the WPTRT account on GitHub. In the short term, if given Lance's agreement, the tests could be put under anyone's individual account (or even Automattic's) and moved over to WPTRT once that team account has been sorted out. Whilst it might be nice to do the SVN to Git transfer properly to keep the commit history, I'm not sure if that necessarily gives any long term value.</div><div><br></div><div>I realise the files for <a href="http://wptest.io">wptest.io</a> is not an official version, and I meant to imply that it had been forked from the official tests some time ago, before each branch separately added different fixes and improvements, such that merging might produce too many conflicts.<br><div class="gmail_extra"><br clear="all"><div><div dir="ltr">-- <div>Gary Jones<div>Web Developer, Gamajo Tech</div></div></div></div>
<br><div class="gmail_quote">On 10 October 2014 17:39, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Gary you replied on digest I copied what you wrote last:<div><br></div><div>----------------</div><div><div><font><span style="background-color:rgba(255,255,255,0)">That's exactly my point which I didn't seem to communicate well enough. Contributors want to write code or make amendments with the tools that are already familiar with, not have to subscribe to a mailing list and submit changes that way.</span></font></div><div><font><span style="background-color:rgba(255,255,255,0)"><br></span></font></div><div><font><span style="background-color:rgba(255,255,255,0)">And by not creating tickets, again, no-one has any record of what changes have been mentioned, awaiting review or fixed. Searching through mailing list archives is really not the most productive of anyone's time.<br></span></font><div class="gmail_extra"><font><span style="background-color:rgba(255,255,255,0)"><br clear="all"></span></font><div><div dir="ltr"><font><span style="background-color:rgba(255,255,255,0)">-- </span></font><div><font><span style="background-color:rgba(255,255,255,0)">Gary Jones</span></font></div><div><font><span style="background-color:rgba(255,255,255,0)">-----------------------</span></font></div><div><font><span>There could be more to it and please don't think of me as someone who blocks this <span></span>I am merely echoing what was said in the past. If Lance is in agreement case closed :)</span></font></div><div><font><span><br></span></font></div><div><font><span>Emil</span></font></div></div></div></div></div><br>On Friday, October 10, 2014, Emil Uzelac <<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Accessible by Lance, Chip, me and few others. There's not much to see anyway :)<span></span><br><br>On Friday, October 10, 2014, Ulrich Pogson <<a>grapplerulrich@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">> <span style="font-family:arial,sans-serif;font-size:13px">N.B we track the history with page/post revisions :)</span><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">@Emil is this information public?</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 10 October 2014 17:11, Emil Uzelac <span dir="ltr"><<a>emil@uzelac.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">N.B we track the history with page/post revisions :)<div><div><span></span><br><br>On Friday, October 10, 2014, Emil Uzelac <<a>emil@uzelac.me</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Not really sure what would be the point of that to be honest. Anyone can freely obtain an official copy and ping us here with the changes. <div><br></div><div>Creating a ticket is also not needed. We can handle all at one place, which is right here.</div><div><br></div>And again this is @Lance's call :)<span></span><br><div><br></div><div><br><br>On Friday, October 10, 2014, Tammie Lister <<a>karmatosed@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
I think having it (not forked) but accessible on GH could be good.
We don't have to fork just to put on GH and for the record, I never
suggested it was forked :)<br>
<br>
Regards<br>
Tammie Lister<br>
<br>
<div>On 10/10/2014 15:56, Emil Uzelac wrote:<br>
</div>
<blockquote type="cite">I don't think we need to fork the unit. WPTest is not
official copy or the same as ours. If you wish to improve, please
by all means. Just ping me and I will go over the changes and make
the update.
<div><br>
</div>
<div>Unless @Lance thinks that this is ok to do, but I doubt that
because someone tried few times already.<div><div class="h5"><span></span><br>
<br>
On Friday, October 10, 2014, Gary Jones <<a>gary@gamajo.com</a>>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hey,
<div><br>
</div>
<div>tl;dr:</div>
<div>1. Could the theme unit tests file be put on public
repo on GitHub?</div>
<div>2. Anyone want to help tackle <a href="https://core.trac.wordpress.org/ticket/22279" target="_blank">https://core.trac.wordpress.org/ticket/22279</a>
?</div>
<div><br>
</div>
<div>Posting after Tammie suggested I do.</div>
<div><br>
</div>
<div>I'd like to see The Theme Unit Tests file on GitHub for
the following reasons:<br>
<br>
* Access to commit history to see what exactly has
changed version to version. Currently, us mere mortals can
only see when it was updated - the information about what
was not updated is not available (or not easy to find) as
it's part of Automattic's SVN repo.</div>
<div> * Easier to see already-reported bugs and
enhancements, rather than wading through the mailing list
archives. </div>
<div><br>
</div>
<div>There's a fork already on GH (<a href="https://github.com/manovotny/wptest" target="_blank">https://github.com/manovotny/wptest</a>)
which claims to have added extra edge cases. But I've
currently got no idea which cases these are, and why they
weren't added to the original Tests file. Michael also
believes that further cases and fixes may have been added
to the official Tests since the fork that aren't in his,
so now we may have two sets of tests, mostly but not
completely duplicated.<br>
<br>
If the official Tests were on GH, and open to pull
requests on those edge cases and other issues, then I'd
hope that wptest could be discontinued to just leave a
single more-complete test suite that everyone can benefit
from.<br>
<br>
The wptest file has fixed things like <a href="https://github.com/manovotny/wptest/issues/27" target="_blank">https://github.com/manovotny/wptest/issues/27</a>
(s/Isaac Newton/Albert Einstein) and <a href="https://github.com/manovotny/wptest/issues/24" target="_blank">https://github.com/manovotny/wptest/issues/24</a>
(s/Horizontal/Vertical on vertical featured image alt
text) which the official Tests are still bugged with. Both
tests are bugged with missing markup formatting tests for
some elements, <a href="https://github.com/manovotny/wptest/issues/37" target="_blank">https://github.com/manovotny/wptest/issues/37</a>
(s/Headers/Headings) and a side-effect of <a href="https://core.trac.wordpress.org/ticket/29621" target="_blank">https://core.trac.wordpress.org/ticket/29621</a>
(post titles stripped of markup on export).<br>
<br>
One of the things that would make contributions
*considerably* easier would be to get <a href="https://core.trac.wordpress.org/ticket/22279" target="_blank">https://core.trac.wordpress.org/ticket/22279</a>
(mixed line endings for XML vs cdata in export) fixed.
That would enable direct editing of the file without
breaking line-endings, without having to set up a clean WP
install, import, amend and export. If anyone has
experience of the Exporter and could help on this, then I
would personally be grateful, as would potential GitHub
contributors :-)</div>
<div><br>
</div>
<div>Gary<br>
<br>
</div>
<div>
<div>
<div dir="ltr">--
<div>Gary Jones
<div>Web Developer, Gamajo Tech</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div></div></div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
theme-reviewers mailing list
<a>theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
</blockquote>
<br><span class="HOEnZb"><font color="#888888">
<pre cols="72">--
Thanks
Tammie Lister</pre>
</font></span></div><span class="HOEnZb"><font color="#888888">
</font></span></blockquote></div><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
</font></span></div></div><span class="HOEnZb"><font color="#888888"><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a>theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br></font></span></div>
</blockquote>
</blockquote></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div></div>