<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I think having it (not forked) but accessible on GH could be good.
We don't have to fork just to put on GH and for the record, I never
suggested it was forked :)<br>
<br>
Regards<br>
Tammie Lister<br>
<br>
<div class="moz-cite-prefix">On 10/10/2014 15:56, Emil Uzelac wrote:<br>
</div>
<blockquote
cite="mid:CAEytdhcfb4xcCbLR9Tp1tKbzgRWS3EJB+v8vqSNuBiNnygd4VA@mail.gmail.com"
type="cite">I don't think we need to fork the unit. WPTest is not
official copy or the same as ours. If you wish to improve, please
by all means. Just ping me and I will go over the changes and make
the update.
<div><br>
</div>
<div>Unless @Lance thinks that this is ok to do, but I doubt that
because someone tried few times already.<span></span><br>
<br>
On Friday, October 10, 2014, Gary Jones <<a
moz-do-not-send="true" href="mailto:gary@gamajo.com">gary@gamajo.com</a>>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hey,
<div><br>
</div>
<div>tl;dr:</div>
<div>1. Could the theme unit tests file be put on public
repo on GitHub?</div>
<div>2. Anyone want to help tackle <a moz-do-not-send="true"
href="https://core.trac.wordpress.org/ticket/22279"
target="_blank">https://core.trac.wordpress.org/ticket/22279</a>
?</div>
<div><br>
</div>
<div>Posting after Tammie suggested I do.</div>
<div><br>
</div>
<div>I'd like to see The Theme Unit Tests file on GitHub for
the following reasons:<br>
<br>
* Access to commit history to see what exactly has
changed version to version. Currently, us mere mortals can
only see when it was updated - the information about what
was not updated is not available (or not easy to find) as
it's part of Automattic's SVN repo.</div>
<div> * Easier to see already-reported bugs and
enhancements, rather than wading through the mailing list
archives. </div>
<div><br>
</div>
<div>There's a fork already on GH (<a moz-do-not-send="true"
href="https://github.com/manovotny/wptest"
target="_blank">https://github.com/manovotny/wptest</a>)
which claims to have added extra edge cases. But I've
currently got no idea which cases these are, and why they
weren't added to the original Tests file. Michael also
believes that further cases and fixes may have been added
to the official Tests since the fork that aren't in his,
so now we may have two sets of tests, mostly but not
completely duplicated.<br>
<br>
If the official Tests were on GH, and open to pull
requests on those edge cases and other issues, then I'd
hope that wptest could be discontinued to just leave a
single more-complete test suite that everyone can benefit
from.<br>
<br>
The wptest file has fixed things like <a
moz-do-not-send="true"
href="https://github.com/manovotny/wptest/issues/27"
target="_blank">https://github.com/manovotny/wptest/issues/27</a>
(s/Isaac Newton/Albert Einstein) and <a
moz-do-not-send="true"
href="https://github.com/manovotny/wptest/issues/24"
target="_blank">https://github.com/manovotny/wptest/issues/24</a>
(s/Horizontal/Vertical on vertical featured image alt
text) which the official Tests are still bugged with. Both
tests are bugged with missing markup formatting tests for
some elements, <a moz-do-not-send="true"
href="https://github.com/manovotny/wptest/issues/37"
target="_blank">https://github.com/manovotny/wptest/issues/37</a>
(s/Headers/Headings) and a side-effect of <a
moz-do-not-send="true"
href="https://core.trac.wordpress.org/ticket/29621"
target="_blank">https://core.trac.wordpress.org/ticket/29621</a>
(post titles stripped of markup on export).<br>
<br>
One of the things that would make contributions
*considerably* easier would be to get <a
moz-do-not-send="true"
href="https://core.trac.wordpress.org/ticket/22279"
target="_blank">https://core.trac.wordpress.org/ticket/22279</a>
(mixed line endings for XML vs cdata in export) fixed.
That would enable direct editing of the file without
breaking line-endings, without having to set up a clean WP
install, import, amend and export. If anyone has
experience of the Exporter and could help on this, then I
would personally be grateful, as would potential GitHub
contributors :-)</div>
<div><br>
</div>
<div>Gary<br>
<br>
</div>
<div>
<div>
<div dir="ltr">--
<div>Gary Jones
<div>Web Developer, Gamajo Tech</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
theme-reviewers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a>
<a class="moz-txt-link-freetext" href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Thanks
Tammie Lister</pre>
</body>
</html>