<div dir="ltr">Yes, that would be fine. Alternatively you can recommend them using: add_filter( 'use_default_gallery_style', '__return_false' ); If all they want to do is not use the styling.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 7, 2014 at 8:34 PM, priyanshu mittal <span dir="ltr"><<a href="mailto:priyanshu.mittal@gmail.com" target="_blank">priyanshu.mittal@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>May Be I new here<br><br></div>I think it comes under theme territory itself. Since all the code he has written,is for only, presentational purpose. He is not creating additions attributes or options.<br><br></div>I would like to know the final answer to this.SInce, I am also reviewing a theme, in which user has removed the gallery style using the below snippet<br><br><pre><b>add_filter( 'gallery_style', 'simplyread_gallery_style' );</b></pre><b><br><br></b><pre><b>// remove injected CSS from gallery
function simplyread_gallery_style($css) {
return preg_replace( "!<style type='text/css'>(.*?)</style>!s", '', $css );
}</b></pre><br><div>Will that be okay for theme?<br><br></div><div>Thanks<span class="HOEnZb"><font color="#888888"><br>Priyanshu<br></font></span></div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 8, 2014 at 8:26 AM, Jose Castaneda <span dir="ltr"><<a href="mailto:jomcastaneda@gmail.com" target="_blank">jomcastaneda@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">In the manner being used it would seem that way only because they are re-adding the shortcode in line 275: <a href="https://themes.trac.wordpress.org/browser/alexis/1.2.0/functions.php#L275" target="_blank">https://themes.trac.wordpress.org/browser/alexis/1.2.0/functions.php#L275</a><div><br><div>I would suggest filtering like the others said. I mean they already are taking out the default gallery styling: <a href="https://themes.trac.wordpress.org/browser/alexis/1.2.0/functions.php#L241" target="_blank">https://themes.trac.wordpress.org/browser/alexis/1.2.0/functions.php#L241</a></div></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 7, 2014 at 6:30 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Wouldn't this fall under (Presentation Vs. Functionality:) and again, plugin-territory? </div><div class="gmail_default"><ul><li><span style="font-family:arial,helvetica,sans-serif">Since the purpose of Themes is to define the presentation of user content, Themes must not be used to define the generation of user content, or to define Theme-independent site options or functionality.</span><br></li></ul><div><font face="arial, helvetica, sans-serif">It's right on our main page: <a href="http://codex.wordpress.org/Theme_Review" target="_blank">http://codex.wordpress.org/Theme_Review</a></font></div></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 7, 2014 at 8:26 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Looking at the functions.php alone is a bit out of context but I'm not really seeing anything there that couldn't work in a theme's layout and aesthetics.</div><div class="gmail_extra"><span><font color="#888888"><br clear="all"><div>Edward Caissie<br>aka Cais.</div></font></span><div><div>
<br><div class="gmail_quote">On Tue, Oct 7, 2014 at 8:38 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">See <a href="https://themes.svn.wordpress.org/alexis/1.2.0/functions.php" target="_blank">https://themes.svn.wordpress.org/alexis/1.2.0/functions.php</a> I can easily be wrong :) Just don't remember that we allowed this before.</div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 7, 2014 at 7:35 PM, Justin Tadlock <span dir="ltr"><<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span><div>As long as the user can use the core parameters, there shouldn't be any issues. Filtering the gallery shortcode output is one area that, at least to me, falls clearly in theme territory since we're referring to the presentational aspect of content. </div><div><br></div></span><div>Of course, plugins could perform the same function, but for that matter, plugins could perform any function you can do in a theme.</div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 7, 2014 at 6:25 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">My understanding was that theme overrides core, if so it is not accepted. Extending, sure :) User should be able to use core features. </div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 7, 2014 at 6:21 PM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I dunno, actually. It is an interesting question. How galleries display is part of the visual style of the theme. I don't see anything wrong with including masonry-enabled galleries in the theme, especially as some kind of optional thing.<div><br></div><div>Now, I would suggest to the theme author not to override the gallery shortcode itself, but to use the post_gallery filter instead, which will let them do essentially the same thing without tinkering with "shortcodes".<div><br></div><div>That said, you would want to make sure that the controls for galleries in WordPress still operate as you would expect them to, more or less. Obviously, something like masonry is probably going to change the meaning of "columns" and the like, but still, that should be mostly functional, to whatever extent makes sense.</div></div><div><br></div><div>But then again, anything you do here in a theme could be done in a plugin too, and said plugin could be made universal for any theme, so unless this particular gallery shortcode is deeply tied to the theme in some way, then it's probably better in a plugin.</div><span><font color="#888888"><div><br></div></font></span></div><div class="gmail_extra"><span><font color="#888888"><br clear="all"><div>-Otto</div>
<br></font></span><div class="gmail_quote"><span>On Tue, Oct 7, 2014 at 6:18 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br></span><div><div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Not silly at all :)</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">This would definitely fall under plugins. </div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Tue, Oct 7, 2014 at 6:11 PM, Ryan Cowles <span dir="ltr"><<a href="mailto:ryan.cowles@automattic.com" target="_blank">ryan.cowles@automattic.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr">Howdy,<div><br></div><div>I'm reviewing a theme that overwrites the native gallery shortcode with a custom Masonry gallery. Seems like a silly question, but I'm looking for confirmation - would this fall under plugin territory?</div><div><br></div><div>Thanks!</div><span><font color="#888888"><div>Ryan</div></font></span></div>
<br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div></div></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>