<HTML><HEAD></HEAD>
<BODY dir=ltr>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: 12pt">
<DIV>If it leaves the user not able to switch themes because of it, it needs to
be in a plugin instead, otherwise it’s fine – was a quote from one of you guys
about a year ago.</DIV>
<DIV> </DIV>
<DIV>This default gallery modifying does not hamper the ability of the end user
to switch to another theme.</DIV>
<DIV> </DIV>
<DIV> </DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV style="FONT: 10pt tahoma">
<DIV> </DIV>
<DIV style="BACKGROUND: #f5f5f5">
<DIV style="font-color: black"><B>From:</B> <A title=justin@justintadlock.com
href="mailto:justin@justintadlock.com">Justin Tadlock</A> </DIV>
<DIV><B>Sent:</B> Tuesday, October 07, 2014 10:27 PM</DIV>
<DIV><B>To:</B> <A title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org">Discussion list for WordPress
theme reviewers.</A> </DIV>
<DIV><B>Subject:</B> Re: [theme-reviewers] Modifying Default
Gallery</DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV dir=ltr>
<DIV>It would fall under our presentation vs. functionality guideline, which is
the primary guideline to me. It just falls on the presentation side of
things. </DIV>
<DIV> </DIV>
<DIV>The best way to look at it might be to break it down a bit. It's the
gallery images (i.e., attachment post type) that are the content.
Functionality dealing with the generation/creation of these attachments and most
related data would fall under plugin territory. The gallery output is the
presentation of that content. This is the sort of thing where theme
authors should have complete freedom to experiment to see what neat things they
can come up with.</DIV>
<DIV> </DIV>
<DIV>To answer the question as to whether we've allowed this before, the answer
is yes. There are numerous themes in the repo that alter the output of the
gallery.</DIV>
<DIV> </DIV>
<DIV>The one thing I'd recommend doing differently is for the theme author to
filter `post_gallery` instead of using `add_shortcode()`.</DIV></DIV>
<DIV class=gmail_extra>
<DIV> </DIV>
<DIV class=gmail_quote>On Tue, Oct 7, 2014 at 8:30 PM, Emil Uzelac <SPAN
dir=ltr><<A href="mailto:emil@uzelac.me"
target=_blank>emil@uzelac.me</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: arial,helvetica,sans-serif"
class=gmail_default>Wouldn't this fall under (Presentation Vs. Functionality:)
and again, plugin-territory? </DIV>
<DIV class=gmail_default>
<UL>
<LI><SPAN style="FONT-FAMILY: arial,helvetica,sans-serif">Since the purpose
of Themes is to define the presentation of user content, Themes must not be
used to define the generation of user content, or to define
Theme-independent site options or functionality.</SPAN><BR></LI></UL>
<DIV><FONT face="arial, helvetica, sans-serif">It's right on our main page: <A
href="http://codex.wordpress.org/Theme_Review"
target=_blank>http://codex.wordpress.org/Theme_Review</A></FONT></DIV></DIV></DIV>
<DIV class=HOEnZb>
<DIV class=h5>
<DIV class=gmail_extra>
<DIV> </DIV>
<DIV class=gmail_quote>On Tue, Oct 7, 2014 at 8:26 PM, Edward Caissie <SPAN
dir=ltr><<A href="mailto:edward.caissie@gmail.com"
target=_blank>edward.caissie@gmail.com</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>Looking at the functions.php alone is a bit out of context but
I'm not really seeing anything there that couldn't work in a theme's layout
and aesthetics.</DIV>
<DIV class=gmail_extra><SPAN><FONT color=#888888><BR clear=all>
<DIV>Edward Caissie<BR>aka Cais.</DIV></FONT></SPAN>
<DIV>
<DIV>
<DIV> </DIV>
<DIV class=gmail_quote>On Tue, Oct 7, 2014 at 8:38 PM, Emil Uzelac <SPAN
dir=ltr><<A href="mailto:emil@uzelac.me"
target=_blank>emil@uzelac.me</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: arial,helvetica,sans-serif"
class=gmail_default>See <A
href="https://themes.svn.wordpress.org/alexis/1.2.0/functions.php"
target=_blank>https://themes.svn.wordpress.org/alexis/1.2.0/functions.php</A>
I can easily be wrong :) Just don't remember that we allowed this
before.</DIV></DIV>
<DIV>
<DIV>
<DIV class=gmail_extra>
<DIV> </DIV>
<DIV class=gmail_quote>On Tue, Oct 7, 2014 at 7:35 PM, Justin Tadlock
<SPAN dir=ltr><<A href="mailto:justin@justintadlock.com"
target=_blank>justin@justintadlock.com</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr><SPAN>
<DIV>As long as the user can use the core parameters, there shouldn't be
any issues. Filtering the gallery shortcode output is one area
that, at least to me, falls clearly in theme territory since we're
referring to the presentational aspect of content. </DIV>
<DIV> </DIV></SPAN>
<DIV>Of course, plugins could perform the same function, but for that
matter, plugins could perform any function you can do in a
theme.</DIV></DIV>
<DIV>
<DIV>
<DIV class=gmail_extra>
<DIV> </DIV>
<DIV class=gmail_quote>On Tue, Oct 7, 2014 at 6:25 PM, Emil Uzelac <SPAN
dir=ltr><<A href="mailto:emil@uzelac.me"
target=_blank>emil@uzelac.me</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: arial,helvetica,sans-serif"
class=gmail_default>My understanding was that theme overrides core, if
so it is not accepted. Extending, sure :) User should be able to use
core features. </DIV></DIV>
<DIV>
<DIV>
<DIV class=gmail_extra>
<DIV> </DIV>
<DIV class=gmail_quote>On Tue, Oct 7, 2014 at 6:21 PM, Otto <SPAN
dir=ltr><<A href="mailto:otto@ottodestruct.com"
target=_blank>otto@ottodestruct.com</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>I dunno, actually. It is an interesting question. How
galleries display is part of the visual style of the theme. I don't
see anything wrong with including masonry-enabled galleries in the
theme, especially as some kind of optional thing.
<DIV> </DIV>
<DIV>Now, I would suggest to the theme author not to override the
gallery shortcode itself, but to use the post_gallery filter
instead, which will let them do essentially the same thing without
tinkering with "shortcodes".
<DIV> </DIV>
<DIV>That said, you would want to make sure that the controls for
galleries in WordPress still operate as you would expect them to,
more or less. Obviously, something like masonry is probably going to
change the meaning of "columns" and the like, but still, that should
be mostly functional, to whatever extent makes sense.</DIV></DIV>
<DIV> </DIV>
<DIV>But then again, anything you do here in a theme could be done
in a plugin too, and said plugin could be made universal for any
theme, so unless this particular gallery shortcode is deeply tied to
the theme in some way, then it's probably better in a
plugin.</DIV><SPAN><FONT color=#888888>
<DIV> </DIV></FONT></SPAN></DIV>
<DIV class=gmail_extra><SPAN><FONT color=#888888><BR clear=all>
<DIV>-Otto</DIV><BR></FONT></SPAN>
<DIV class=gmail_quote><SPAN>On Tue, Oct 7, 2014 at 6:18 PM, Emil
Uzelac <SPAN dir=ltr><<A href="mailto:emil@uzelac.me"
target=_blank>emil@uzelac.me</A>></SPAN> wrote:<BR></SPAN>
<DIV>
<DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: arial,helvetica,sans-serif"
class=gmail_default>Not silly at all :)</DIV>
<DIV style="FONT-FAMILY: arial,helvetica,sans-serif"
class=gmail_default> </DIV>
<DIV style="FONT-FAMILY: arial,helvetica,sans-serif"
class=gmail_default>This would definitely fall under plugins.
</DIV></DIV>
<DIV class=gmail_extra>
<DIV> </DIV>
<DIV class=gmail_quote>
<DIV>
<DIV>On Tue, Oct 7, 2014 at 6:11 PM, Ryan Cowles <SPAN
dir=ltr><<A href="mailto:ryan.cowles@automattic.com"
target=_blank>ryan.cowles@automattic.com</A>></SPAN>
wrote:<BR></DIV></DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV>
<DIV>
<DIV dir=ltr>Howdy,
<DIV> </DIV>
<DIV>I'm reviewing a theme that overwrites the native gallery
shortcode with a custom Masonry gallery. Seems like a silly
question, but I'm looking for confirmation - would this fall
under plugin territory?</DIV>
<DIV> </DIV>
<DIV>Thanks!</DIV><SPAN><FONT color=#888888>
<DIV>Ryan</DIV></FONT></SPAN></DIV>
<DIV> </DIV></DIV></DIV>_______________________________________________<BR>theme-reviewers
mailing list<BR><A
href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A
href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV></DIV></DIV>
<DIV> </DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV></DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV></DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV></DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV></DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV></DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV>
<P>
<HR>
_______________________________________________<BR>theme-reviewers mailing
list<BR>theme-reviewers@lists.wordpress.org<BR>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR></DIV></DIV></DIV></BODY></HTML>