<div dir="ltr">So should we change the wording on <a href="https://make.wordpress.org/themes/handbook/guidelines/theme-security-and-privacy/#theme-settings-and-data-security">https://make.wordpress.org/themes/handbook/guidelines/theme-security-and-privacy/#theme-settings-and-data-security</a> to make it required and say exemption maybe granted in rare and valid cases.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 30, 2014 at 3:21 AM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I would very much suggest to use the theme-mod system for all cases, and the Customizer for preference over creating an options page. The new features in customizer where you can add Panels to contain Sections (which themselves contain Controls) makes it possible to stuff a lot more controls and organization in there than you might expect.<div><br></div><div>If you haven't read this yet, check it out:</div><div><a href="https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/" target="_blank">https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/</a><span class="HOEnZb"><font color="#888888"><br></font></span></div><span class="HOEnZb"><font color="#888888"><div><br></div></font></span></div><div class="gmail_extra"><span class="HOEnZb"><font color="#888888"><br clear="all"><div>-Otto</div></font></span><div><div class="h5">
<br><div class="gmail_quote">On Mon, Sep 29, 2014 at 4:36 PM, Justin Tadlock <span dir="ltr"><<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">That specific theme was actually creating a custom table in the database, which is something that we wouldn't allow. I don't think that's explicitly stated in the guidelines, but there's really no reason a theme should be creating an extra table.</div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 29, 2014 at 3:15 PM, Srikanth Koneru <span dir="ltr"><<a href="mailto:tskk79@gmail.com" target="_blank">tskk79@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yes, I read your comment ( <a href="https://themes.trac.wordpress.org/ticket/19847#comment:30" target="_blank">https://themes.trac.wordpress.org/ticket/19847#comment:30</a> ) so wanted to know if I should say its required too.<br></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 30, 2014 at 1:42 AM, Justin Tadlock <span dir="ltr"><<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Basically, theme authors should either be using the Settings API or Theme Mods API if they're building a theme settings page. It's not strictly required to use the Settings API, but for the majority of cases you might as well say it's a requirement because it's going to take care of a lot of problems present with custom-built theme options pages. There are, of course, exceptions, but I don't think I've seen one yet here on WordPress.org.<div><br></div><div>Ideally, we'd push theme authors to use the Theme Customizer as much as possible, which would eliminate most issues with theme options.</div><div><br></div><div><br></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 29, 2014 at 3:04 PM, Ulrich Pogson <span dir="ltr"><<a href="mailto:grapplerulrich@gmail.com" target="_blank">grapplerulrich@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">It is recommended but if it is not used then security precautions should be taken. <a href="https://make.wordpress.org/themes/handbook/guidelines/theme-security-and-privacy/#theme-settings-and-data-security" target="_blank">https://make.wordpress.org/themes/handbook/guidelines/theme-security-and-privacy/#theme-settings-and-data-security</a></div><div class="gmail_extra"><br><div class="gmail_quote">On 29 September 2014 22:53, Srikanth Koneru <span dir="ltr"><<a href="mailto:tskk79@gmail.com" target="_blank">tskk79@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Need confirmation.<br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>