<div dir="ltr">It's not so much if the code is OK, it's more a question of why do you think it is not OK?<div><br></div><div>This is important to understand from your review, why are you questioning if there is a problem ... what part of the code is causing you to be concerned?</div><div><br></div></div><div class="gmail_extra"><br clear="all"><div>Edward Caissie<br>aka Cais.</div>
<br><div class="gmail_quote">On Sun, Sep 14, 2014 at 12:49 PM, Weblizar WordPress Premium Themes And Plugins <span dir="ltr"><<a href="mailto:lizarweb@gmail.com" target="_blank">lizarweb@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yes, Is this ok to have this in the theme ?</div><div class="gmail_extra"><span class=""><br clear="all"><div><div dir="ltr"><div><div><b>Kindest Regards</b><br></div><b>Weblizar<br></b></div><b>Follow Us: <a href="https://twitter.com/weblizar" target="_blank">Twitter</a> | <a href="https://www.facebook.com/pages/Weblizar/1440510482872657" target="_blank">Facebook</a> | <a href="https://plus.google.com/u/0/100920322672659513870/" target="_blank">Google+</a> | <a href="http://in.linkedin.com/pub/weblizar-premium-themes-plugins/99/3bb/460" target="_blank">Linkedin</a></b> | <b><a href="http://www.pinterest.com/lizarweb/" target="_blank">Pinterest</a></b><br></div></div>
<br></span><div><div class="h5"><div class="gmail_quote">On Sun, Sep 14, 2014 at 10:14 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yes, I saw the paste bin link and quickly looked at the code ... what concerns do you have with it that makes you think it should not be used?</div><div class="gmail_extra"><span><font color="#888888"><br clear="all"><div>Edward Caissie<br>aka Cais.</div></font></span><div><div>
<br><div class="gmail_quote">On Sun, Sep 14, 2014 at 12:24 PM, Weblizar WordPress Premium Themes And Plugins <span dir="ltr"><<a href="mailto:lizarweb@gmail.com" target="_blank">lizarweb@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Code has the link of paste bin.<div><br></div><div>and the actual php custom pagination code is there, which is used in a theme,I'm reviewing.</div></div><div class="gmail_extra"><span><br clear="all"><div><div dir="ltr"><div><div><b>Kindest Regards</b><br></div><b>Weblizar<br></b></div><b>Follow Us: <a href="https://twitter.com/weblizar" target="_blank">Twitter</a> | <a href="https://www.facebook.com/pages/Weblizar/1440510482872657" target="_blank">Facebook</a> | <a href="https://plus.google.com/u/0/100920322672659513870/" target="_blank">Google+</a> | <a href="http://in.linkedin.com/pub/weblizar-premium-themes-plugins/99/3bb/460" target="_blank">Linkedin</a></b> | <b><a href="http://www.pinterest.com/lizarweb/" target="_blank">Pinterest</a></b><br></div></div>
<br></span><div><div><div class="gmail_quote">On Sun, Sep 14, 2014 at 9:50 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">What are your concerns with the code?<span><font color="#888888"><div><br></div></font></span></div><div class="gmail_extra"><span><font color="#888888"><br clear="all"><div>Edward Caissie<br>aka Cais.</div></font></span><div><div>
<br><div class="gmail_quote">On Sun, Sep 14, 2014 at 5:59 AM, Weblizar WordPress Premium Themes And Plugins <span dir="ltr"><<a href="mailto:lizarweb@gmail.com" target="_blank">lizarweb@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Reviewing a Theme . Is this allow in theme ?<div><br></div><div><a href="http://tny.cz/5c93d218" target="_blank">Code</a></div></div><div class="gmail_extra"><span><br clear="all"><div><div dir="ltr"><div><div><b>Kindest Regards</b><br></div><b>Weblizar<br></b></div><b>Follow Us: <a href="https://twitter.com/weblizar" target="_blank">Twitter</a> | <a href="https://www.facebook.com/pages/Weblizar/1440510482872657" target="_blank">Facebook</a> | <a href="https://plus.google.com/u/0/100920322672659513870/" target="_blank">Google+</a> | <a href="http://in.linkedin.com/pub/weblizar-premium-themes-plugins/99/3bb/460" target="_blank">Linkedin</a></b> | <b><a href="http://www.pinterest.com/lizarweb/" target="_blank">Pinterest</a></b><br></div></div>
<br></span><div><div><div class="gmail_quote">On Sat, Sep 13, 2014 at 7:34 PM, Weblizar WordPress Premium Themes And Plugins <span dir="ltr"><<a href="mailto:lizarweb@gmail.com" target="_blank">lizarweb@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks all for the Guide me.</div><div class="gmail_extra"><span><br clear="all"><div><div dir="ltr"><div><div><b>Kindest Regards</b><br></div><b>Weblizar<br></b></div><b>Follow Us: <a href="https://twitter.com/weblizar" target="_blank">Twitter</a> | <a href="https://www.facebook.com/pages/Weblizar/1440510482872657" target="_blank">Facebook</a> | <a href="https://plus.google.com/u/0/100920322672659513870/" target="_blank">Google+</a> | <a href="http://in.linkedin.com/pub/weblizar-premium-themes-plugins/99/3bb/460" target="_blank">Linkedin</a></b> | <b><a href="http://www.pinterest.com/lizarweb/" target="_blank">Pinterest</a></b><br></div></div>
<br></span><div><div><div class="gmail_quote">On Sat, Sep 13, 2014 at 6:52 PM, Harish <span dir="ltr"><<a href="mailto:me@harishchouhan.com" target="_blank">me@harishchouhan.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-IN" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Check TwentyFourteen theme. It uses the pagination. <u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#404040"><u></u> <u></u></span></p><p class="MsoNormal" style="line-height:150%"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#404040">Regards,<u></u><u></u></span></p><p class="MsoNormal" style="line-height:150%"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#404040">Harish </span><span style="font-size:10.0pt;line-height:150%;font-family:"Arial","sans-serif";color:#404040"><u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> theme-reviewers [mailto:<a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a>] <b>On Behalf Of </b>Justin Tadlock<br><b>Sent:</b> Sat 13 September 14 06:48 PM</span></p><div><div><br><b>To:</b> Discussion list for WordPress theme reviewers.<br><b>Subject:</b> Re: [theme-reviewers] Custom pagination acceptable or not?<u></u><u></u></div></div><p></p><div><div><p class="MsoNormal"><u></u> <u></u></p><div><p class="MsoNormal">You can definitely have custom pagination in your theme.  This is one of those things that falls under "presentational" in nature, so it's OK to have it in your theme.  You must make use of core functionality though, which means using `paginate_links()`.<u></u><u></u></p></div><div><p class="MsoNormal"><u></u> <u></u></p><div><p class="MsoNormal">On Sat, Sep 13, 2014 at 7:53 AM, Srikanth Koneru <<a href="mailto:tskk79@gmail.com" target="_blank">tskk79@gmail.com</a>> wrote:<u></u><u></u></p><blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"><div><p class="MsoNormal">you can have <prev 1 2 3 next> using core function example is at <a href="http://codex.wordpress.org/Function_Reference/paginate_links" target="_blank">http://codex.wordpress.org/Function_Reference/paginate_links</a><u></u><u></u></p></div><div><div><div><p class="MsoNormal"><u></u> <u></u></p><div><p class="MsoNormal">On Sat, Sep 13, 2014 at 6:18 PM, FasterThemes Support <<a href="mailto:support@fasterthemes.com" target="_blank">support@fasterthemes.com</a>> wrote:<u></u><u></u></p><blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"><div><div><p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">+1 to Stanko Metodiev.<br>A good solution ! :)</span><span lang="EN-US"><u></u><u></u></span></p><p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><span lang="EN-US"><u></u><u></u></span></p><div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0cm 0cm 0cm"><p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> theme-reviewers [mailto:<a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a>] <b>On Behalf Of </b>Stanko Metodiev<br><b>Sent:</b> 13 September, 2014 6:16 PM<br><b>To:</b> Discussion list for WordPress theme reviewers.<br><b>Subject:</b> Re: [theme-reviewers] Custom pagination acceptable or not?</span><span lang="EN-US"><u></u><u></u></span></p></div><div><div><p class="MsoNormal"><span lang="EN-US"> <u></u><u></u></span></p><div><p class="MsoNormal"><span lang="EN-US">You could add support for some of the existing pagination plugins, e.g. <a href="https://wordpress.org/plugins/wp-pagenavi/" target="_blank">https://wordpress.org/plugins/wp-pagenavi/</a><u></u><u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US"> <u></u><u></u></span></p><div><p class="MsoNormal"><span lang="EN-US">On 13 September 2014 15:42, FasterThemes Support <<a href="mailto:support@fasterthemes.com" target="_blank">support@fasterthemes.com</a>> wrote:<u></u><u></u></span></p><div><div><p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I don't think so. It falls in plugin territory !<br>Solution is : create 1 plugin and once approved in WP.org , recommend it to your theme users through TGM.</span><span lang="EN-US"><u></u><u></u></span></p><p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><span lang="EN-US"><u></u><u></u></span></p><div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0cm 0cm 0cm"><p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> theme-reviewers [mailto:<a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a>] <b>On Behalf Of </b>Weblizar WordPress Premium Themes And Plugins<br><b>Sent:</b> 13 September, 2014 6:08 PM<br><b>To:</b> Discussion list for WordPress theme reviewers.<br><b>Subject:</b> [theme-reviewers] Custom pagination acceptable or not?</span><span lang="EN-US"><u></u><u></u></span></p></div><div><div><p class="MsoNormal"><span lang="EN-US"> <u></u><u></u></span></p><div><p class="MsoNormal"><span lang="EN-US">Can I use customise Pagination in my next WordPress Theme?<u></u><u></u></span></p><div><p class="MsoNormal"><span lang="EN-US"><br clear="all"><u></u><u></u></span></p><div><div><div><div><p class="MsoNormal"><b><span lang="EN-US">Kindest Regards</span></b><span lang="EN-US"><u></u><u></u></span></p></div><p class="MsoNormal"><b><span lang="EN-US">Weblizar</span></b><span lang="EN-US"><u></u><u></u></span></p></div><p class="MsoNormal"><b><span lang="EN-US">Follow Us: <a href="https://twitter.com/weblizar" target="_blank">Twitter</a> | <a href="https://www.facebook.com/pages/Weblizar/1440510482872657" target="_blank">Facebook</a> | <a href="https://plus.google.com/u/0/100920322672659513870/" target="_blank">Google+</a> | <a href="http://in.linkedin.com/pub/weblizar-premium-themes-plugins/99/3bb/460" target="_blank">Linkedin</a></span></b><span lang="EN-US"> | <b><a href="http://www.pinterest.com/lizarweb/" target="_blank">Pinterest</a></b><u></u><u></u></span></p></div></div></div></div></div></div></div></div><p class="MsoNormal" style="margin-bottom:12.0pt"><span lang="EN-US"><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><u></u><u></u></span></p></div><p class="MsoNormal"><span lang="EN-US"><br><br clear="all"><u></u><u></u></span></p><div><p class="MsoNormal"><span lang="EN-US"> <u></u><u></u></span></p></div><p class="MsoNormal"><span lang="EN-US">-- <u></u><u></u></span></p><div><div><p class="MsoNormal"><span lang="EN-US">Stanko Metodiev,<u></u><u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US">WordPress Developer<u></u><u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US">@metodiew<u></u><u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US"><a href="http://metodiew.com/" target="_blank">http://metodiew.com/</a><u></u><u></u></span></p></div></div></div></div></div></div></div><p class="MsoNormal" style="margin-bottom:12.0pt"><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><u></u><u></u></p></blockquote></div><p class="MsoNormal"><u></u> <u></u></p></div></div></div><p class="MsoNormal" style="margin-bottom:12.0pt"><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><u></u><u></u></p></blockquote></div><p class="MsoNormal"><u></u> <u></u></p></div></div></div></div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
</blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>