<div dir="ltr">Makes sense, better first review is proper solution.<br>running themecheck, approving theme started during incentive program.<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 1, 2014 at 1:56 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Adding more admins, or getting a paid full-time admin, would merely be a band-aid. The issue won't truly be resolved until the second review becomes unnecessary. What will help mark Themes live is ensuring that they don't need an admin re-review. As Otto pointed out: the final admin review is there, because it is needed, unfortunately. There are too many approved Themes that have significant issues, that need to be resolved before those Themes are placed in users' hands.<div>
<br></div><div>Theme review is hard, it has a steep learning curve, and it takes a while to get really comfortable with it. The biggest hindrance is reviewer training/education. The admins are doing what we can to mitigate that, but time spent on education/training is time not spent on auditing Themes and pushing them Live.</div>
<div><br></div><div>I have seen some improvement overall, but it has been marginal (I have to reopen probably 80% of tickets, where before I had to reopen 90% of tickets - give or take).</div><div><br></div><div>What I suspect is still happening is that most reviews are conducted like so:</div>
<div><br></div><div>1) Install Theme</div><div>2) Run Theme Check, dump output into the ticket</div><div>3) Look at the Theme on the front end</div><div><br></div><div>Unfortunately, that should be the final 10% of the review, not not bulk of the review. But I really think that's what's happening.</div>
<div><br></div><div>Reviews should look more like:</div><div><br></div><div>1) Review style.css for license/keyword information</div><div>2) Review readme.css for license information and look for custom features/functionality</div>
<div>3) Review header.php</div><div>4) Review footer.php</div><div>5) Review functions.php (and included sub-files)</div><div>6) Review bundled/included resources, and ensure they're listed with copyright/license information in the readme</div>
<div><br></div><div>80% of important issues will be found with just those 5 steps. </div><div><br></div><div>If the Theme uses a base with which you're familiar (Underscores, Twenty Twelve, etc.), you can most likely ignore the rest of the template/template-part files.</div>
<div><br></div><div>From there:</div><div><br></div><div>7) Install the Theme, run Theme Check. Ensure there are no critical or required issues. Review (but DO NOT POST) the recommended and info output (INFO might include hard-coded links, that you'll need to check to ensure appropriateness, but you wouldn't put anything in the ticket, unless you find an inappropriate link).</div>
<div>8) Look at the Theme on the front end and in the back end. Ensure there is no PHP error/notice output. Ensure there are no deprecated notices. Verify custom functionality works (if applicable) - assign a menu to a theme location, add a Widget to a dynamic sidebar, etc.</div>
<div>9) Ensure all style.css keyword tags are appropriate.</div><div><br></div><div>That will catch almost all of the rest of the required issues.</div><div><br></div><div>Notice that this implies a code-review and functionality-focused review. We tried to emphasize this point by making the Theme Unit Tests officially only *recommended* instead of *required*: we're primarily reviewing code and functionality, not design and aesthetics.</div>
<div><br></div><div>(Yes, all of this is going into a re-write of my guide to reviewing Themes; but it's taking a while to complete.)</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">
On Thu, Jul 31, 2014 at 3:01 PM, Michael Hebenstreit <span dir="ltr"><<a href="mailto:michael@mhthemes.com" target="_blank">michael@mhthemes.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>That doesn’t help the review queue and also won’t mark themes as live. :-)
</div><div><br></div>
<br><div><div>Am 31.07.2014 um 21:58 schrieb Emil Uzelac <<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>>:</div><div><div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">
And you can get paid for reviews too, just go to <a href="http://jobs.wordpress.net/" target="_blank">http://jobs.wordpress.net/</a> and problem solved ;)<br>
</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jul 31, 2014 at 2:57 PM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Thu, Jul 31, 2014 at 2:52 PM, Michael Hebenstreit <span dir="ltr"><<a href="mailto:michael@mhthemes.com" target="_blank">michael@mhthemes.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><blockquote type="cite">
<div dir="auto">At the moment it seems that a lot of unexperienced reviewers are being motivated on WordCamps around the world. They review a few themes during the contribution day and then it’s over (in most cases).</div>
</blockquote></div></blockquote></div><div>WordCamps aren't recruitment drives. Those sessions should be entirely for the benefit of the people there, not for any other purpose. Our goal at WordCamps, overall, is to educate and inform (and meet and greet and BBQ and so on).</div>
<div><br></div><div>If showing somebody how the theme review works and having them do one for hands on experience helps them in any way, then that was the point. Whether the result is useful to us or not is irrelevant, we only care whether or not it was useful for that person. </div>
<div><br></div><div>Wordcamps are for the Wordcampers. If they decide to continue reviewing, great. If not, that's okay too.<span><font color="#888888"><br></font></span></div><span><font color="#888888"><div class="gmail_extra">
<br clear="all"><div>-Otto</div></div><div><br></div></font></span></div>
</div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</blockquote></div></div></div><br></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>