<p dir="ltr">No, because that's stupid.</p>
<p dir="ltr">Feel free to correct the reviewers when you think they are wrong. Theme review is a dialog, not a word handed down from up on high. Everybody makes mistakes. Don't judge, just try to achieve balance. </p>
<p dir="ltr">The goal is to produce the best code possible and to not give broken code users. Work towards that end, all around.<br></p>
<p dir="ltr"> </p>
<div class="gmail_quote">On May 27, 2014 7:16 PM, "Evan Henley" <<a href="mailto:henleyedition@gmail.com">henleyedition@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div>Hi all,</div><div><br></div>This is regarding the following ticket: <a href="https://themes.trac.wordpress.org/ticket/18381" target="_blank">https://themes.trac.wordpress.org/ticket/18381</a><div>
<br></div><div>There is some conflict over the interpretation of the rules for prefixing variables:</div><div><br></div><div><blockquote type="cite">Themes are required to use theme-slug ( or a reasonably unique slug) as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.) </blockquote>
</div><div><br></div><div>I am being told I need to prefix every variable used in my theme. Is it correct that even non-global variables need to be prefixed?</div><div><br></div><div>For instance, I’m told that <font face="Menlo">$title</font> needs to be changed to <font face="Menlo">$counterpoint_title</font>:</div>
<div><br></div><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px"><div><div><span style="font-family:Menlo">function counterpoint_no_title($title) {</span></div></div><div><div><font face="Menlo"> if ( $title == '' ) $title = __('Untitled', 'counterpoint');</font></div>
</div><div><div><font face="Menlo"> return $title;</font></div></div><div><div><font face="Menlo">}</font></div></div><div><div><font face="Menlo">add_filter( 'the_title', 'counterpoint_no_title' );</font></div>
</div></blockquote><div><div><br></div><div>Any insight would be much appreciated.</div><div><br></div><div>Thanks,</div><div>Evan</div></div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div>