<div dir="ltr">Or wp_add_inline_style(). I might play around with that a bit.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Apr 10, 2014 at 7:29 PM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Only if you need to replace the whole thing. If you only need to make minor adjustments to portions of it, using CSS specificity is simpler and quicker.<span class="HOEnZb"><font color="#888888"><br>
</font></span><div class="gmail_extra"><span class="HOEnZb"><font color="#888888"><br clear="all"><div>-Otto</div></font></span><div><div class="h5">
<br><br><div class="gmail_quote">On Thu, Apr 10, 2014 at 6:18 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">You know what, I'm going to contradict myself. The cleanest way to wholesale override the mediaelement playlist CSS is to deregister the core style, and enqueue your own. Something like so:<div><br></div>
<div><div>/**</div><div> * Function action to override playlist CSS</div><div> */</div><div>function themeslug_override_playlist_style() {</div><div><span style="white-space:pre-wrap"> </span>wp_dequeue_style( 'wp-mediaelement' );</div>
<div><span style="white-space:pre-wrap"> </span>wp_enqueue_style( 'themeslug-mediaelement', $url );</div><div>}</div><div>add_action( 'wp_playlist_scripts', 'themeslug_override_playlist_style', 11 );</div>
</div><div><br></div><div>Now, if you just need to filter the "skins" (default are "dark" and "light"), to add a custom skin, that's filterable, and should be done via filter. But if a Theme needs/wants to override the CSS completely, I don't have a huge problem with it. </div>
<div><br></div><div>I dug quite a bit, looking for a better way to filter; but I didn't find anything. Maybe wp_add_inline_style() could be useful?</div></div><div><div><div class="gmail_extra">
<br><br><div class="gmail_quote">
On Thu, Apr 10, 2014 at 7:05 PM, Justin Tadlock <span dir="ltr"><<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
In general, I don't recommend disabling the JavaScript (that's probably always plugin territory), but the CSS is fine in many cases. Presentation of content is entirely within the theme's domain.<br>
<br>
I even have a project for handling custom styling of the media player:<br>
<a href="https://github.com/justintadlock/theme-mediaelement" target="_blank">https://github.com/<u></u>justintadlock/theme-<u></u>mediaelement</a><br>
<br>
Demo:<br>
<a href="http://locallylost.com/socially-awkward/2013/09/02/big-buck-bunny/" target="_blank">http://locallylost.com/<u></u>socially-awkward/2013/09/02/<u></u>big-buck-bunny/</a><br>
<br>
This is referring to overwriting the entire stylesheet with a custom one. I like to mix it with Genericons instead of the images packaged with WP. There's no need to load WP's stylesheets (two of them) when completely customizing the player's design.<br>
<br>
Just to overwrite some minor things, all that's needed is a bit of CSS in a theme's `style.css`.<div><div><br>
<br>
On 4/10/2014 2:32 PM, Afzaal wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
I'm currently reviewing a theme where the author is deregistering a WordPress bundled stylesheet "wp-mediaelement". This is being done within a custom theme class and immediately the authors own stylesheet is being registered.<br>
<br>
Is there any problems with doing this? I know that deregistering some scripts such as jQuery are not allowed, so thought it best to ask.<br>
<br>
Thanks,<br>
<br>
Afzaal<br>
<br>
______________________________<u></u>_________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/<u></u>mailman/listinfo/theme-<u></u>reviewers</a><br>
</blockquote>
<br>
______________________________<u></u>_________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/<u></u>mailman/listinfo/theme-<u></u>reviewers</a><br>
</div></div></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>