<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">@Ulrich I was just about to reply, but Chip beat me to it and there's not much else to add.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">
<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Mar 23, 2014 at 4:08 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">What's the rationale for the exception?<div><br></div><div>The correct function for adding a submenu page to the Appearance menu is add_theme_page(). This is also something that, as far as I know, is flagged by both Theme Check and the uploader script.</div>
</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Mar 23, 2014 at 4:40 PM, Ulrich Pogson <span dir="ltr"><<a href="mailto:grapplerulrich@gmail.com" target="_blank">grapplerulrich@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">@Emil - My question was "<span style="font-family:arial,sans-serif;font-size:13px">Can we make an <b>exception </b>here if the added menu item is under "Appearance"?" :)</span><div>
<span style="font-family:arial,sans-serif;font-size:13px"><br>
</span></div><div><font face="arial, sans-serif">The guidelines is clear to me but do we need to be so strict if a similar function gets the same result.</font></div><div><font face="arial, sans-serif"><br></font></div><div>
<font face="arial, sans-serif"><b>If</b> the guideline was this then there would be no problem.</font></div><div><span style="font-family:arial,sans-serif;font-size:13px">"</span><span style="font-size:13px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;line-height:18.200000762939453px">Themes are </span><b style="font-size:13px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;line-height:18.200000762939453px">required</b><span style="font-size:13px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;line-height:18.200000762939453px"> </span><span style="font-size:13px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;line-height:18.200000762939453px">to add the Theme Settings Page to the </span><i style="font-size:13px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;line-height:18.200000762939453px">Appearance</i><span style="font-size:13px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;line-height:18.200000762939453px"> menu"</span><font face="arial, sans-serif"><br>
</font></div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On 23 March 2014 21:10, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">The requirement is pretty much self explanatory ;-)</p><div><div>
<div class="gmail_quote">On Mar 23, 2014 2:09 PM, "WordPress (thinkupthemes)" <<a href="mailto:wordpress@thinkupthemes.com" target="_blank">wordpress@thinkupthemes.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="auto"><div><div>Redux is very easy to customize. You can edit the relevant code in framework.php to make it compliment. That's what we do.</div><div><br></div><div>Afzaal</div><br>Sent from my iPhone</div><div>
<br>On 23 Mar 2014, at 19:06, Ulrich Pogson <<a href="mailto:grapplerulrich@gmail.com" target="_blank">grapplerulrich@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">Redux Framework uses add_submenu_page() instead of add_theme_page(). Can we make an exception here if the the added menu item is under "Appearance"?<div>
<br></div><div>"<span style="font-size:13px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;line-height:18.200000762939453px">Themes are </span><b style="font-size:13px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;line-height:18.200000762939453px">required</b><span style="font-size:13px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;line-height:18.200000762939453px"> to use the </span><i style="font-size:13px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;line-height:18.200000762939453px">add_theme_page()</i><span style="font-size:13px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;line-height:18.200000762939453px"> function to add the Theme Settings Page to the </span><i style="font-size:13px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;line-height:18.200000762939453px">Appearance</i><span style="font-size:13px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;line-height:18.200000762939453px"> menu"</span></div>
<div><span style="line-height:18.200000762939453px;color:rgb(85,85,85);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif"><a href="http://make.wordpress.org/themes/guidelines/guidelines-theme-security-and-privacy/" target="_blank">http://make.wordpress.org/themes/guidelines/guidelines-theme-security-and-privacy/</a></span><br>
</div><div><br></div><a href="https://github.com/ReduxFramework/redux-framework/search?q=add_submenu_page" target="_blank">https://github.com/ReduxFramework/redux-framework/search?q=add_submenu_page</a><div><br></div><div>
Thanks</div></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>theme-reviewers mailing list</span><br><span><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a></span><br>
<span><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></span><br></div></blockquote></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>