<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">I will certainly do this (probably a
combination of prefixing theme names and the exclude from updates
filter) from now on when I develop themes.... But this particular
site is actually using a theme developed by a friend of mine, so
I'm concerned about the bigger picture here. I have seen this
happen more than once I sites I have developed and/or maintained.
In all my years developing themes and reading tutorials, I have
never seen this problem addressed... So it seems like we either
need to do a better job of letting theme developers know that this
is a potential problem, or adjust how the API looks for updates so
that it is less likely to be a problem.<br>
<br>
Thanks!
<pre class="moz-signature" cols="72">Morgan Kay
WordPress Alchemists
<a class="moz-txt-link-freetext" href="http://wpalchemists.com">http://wpalchemists.com</a>
Alchemy Computer Solutions
<a class="moz-txt-link-freetext" href="http://alchemycs.com">http://alchemycs.com</a>
Skype: wp-alchemist
206-321-1742</pre>
On 12/22/2013 1:38 PM, Chip Bennett wrote:<br>
</div>
<blockquote
cite="mid:CAPdLKqfW8sGNyyHxUYaFv3Arbb6Df88+xEfeu_pRV9oYCrFXyA@mail.gmail.com"
type="cite">
<div dir="ltr">Theme developers can simply exclude their Theme
from the update API check, through a simple filter. Given how
deeply the Theme and Plugin directories are integrated into the
WordPress user admin, I would strongly recommend that developers
of Themes/Plugins not hosted by WPORG implement such filters, as
a matter of course. (Note: there is a similar method for hooking
a third-party update *into* the update API, so that
non-WPORG-hosted Themes/Plugins can make use of the automatic
update/upgrade functionality.)</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Sun, Dec 22, 2013 at 4:27 PM, Morgan
Kay <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:morgan@wpalchemists.com" target="_blank">morgan@wpalchemists.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">This might
be slightly off-topic for this list.... but I just ran into
a problem on a client's site that I have seen happen more
than once. The client has a custom theme, and the theme's
name is "Polaris." The client was being diligent about
doing updates on their site, and WordPress told them that
they needed to update the Polaris theme, so they did.
Unfortunately, "Polaris" is also the name of a theme in the
WordPress theme repository, which has a later version number
than the custom theme named "Polaris" on the client's
website. So they thought they were updating their current
theme, when actually they were installing a whole new theme
which completely broke their site.<br>
<br>
This isn't the first time I have seen this happen.
Apparently WordPress only compares the theme name and the
version number, and then prompts for an update.<br>
<br>
So I have two questions here:<br>
1) Is there anything that theme authors who write bespoke
themes can do to prevent this from happening? Other than
only using really obscure names, or giving our themes
artificially high version numbers?<br>
2) Can we change how WordPress looks for theme updates so
that it checks Author name or some other required parameters
to make sure that it is actually the same theme? (I know -
you're going to tell me to fix it myself. I would actually
be happy to do that, but there seem to be some policy
questions involved here, such as whether authors are likely
to change their author name or URI, and whether these
changes would prevent themes from being updated when they
should.)<br>
<br>
Thanks!<br>
Morgan.<br>
<br>
-- <br>
Morgan Kay<br>
WordPress Alchemists<br>
<a moz-do-not-send="true" href="http://wpalchemists.com"
target="_blank">http://wpalchemists.com</a><br>
<br>
Alchemy Computer Solutions<br>
<a moz-do-not-send="true" href="http://alchemycs.com"
target="_blank">http://alchemycs.com</a><br>
<br>
Skype: wp-alchemist<br>
<a moz-do-not-send="true" href="tel:206-321-1742"
value="+12063211742" target="_blank">206-321-1742</a><br>
<br>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org"
target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
theme-reviewers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a>
<a class="moz-txt-link-freetext" href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
</blockquote>
<br>
</body>
</html>