<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi. I have Replied to the ticket with a few more changes that needed to be made in the diff you submitted. <span style="font-size: 12pt;">Its great to see, that this upgrade is being made.</span><div><br></div><div>Answer to your other Question. Yes, themes are likely to suffer with this upgrade, as 5 of the very commonly used parameters were renamed in masonry v3. Hence, some sort of backword compatibilty is needed.<br><div><br><div><hr id="stopSpelling">From: jpollock412@gmail.com<br>Date: Sat, 23 Nov 2013 15:36:46 -0500<br>To: theme-reviewers@lists.wordpress.org<br>Subject: [theme-reviewers] Upgrading Masonry In Core<br><br><div dir="ltr">We discussed the need to upgrade Masonry in core to version 3 awhile back. I have submitted a new patch that not only updates Masonry to version 3 but also addresses the fact that doing so initially broke the footer widgets in 2013 and 2014 due to the different way that v2 and v3 handle column width.<div>
<br></div><div><a href="http://core.trac.wordpress.org/ticket/25351" target="_blank">http://core.trac.wordpress.org/ticket/25351</a><br></div><div><br></div><div>This raises a relevant question:</div><div>Would anyone's theme experience a similar issue? Probably. Is that a valid objection to upgrading in core?</div>
<div><br></div><div>BTW If anyone has a second to test and/ or improve on my patch it would be appreciated. I'd like to get this fairly simple upgrade done soon.</div></div>
<br>_______________________________________________
theme-reviewers mailing list
theme-reviewers@lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers</div></div></div> </div></body>
</html>