<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>In ticket comment pointing out the issues so that the author can address them and upload a revised version as soon as possible is the way to go. Suspension is too harsh especially at this stage in the process.<br><br><div><hr id="stopSpelling">Date: Fri, 22 Nov 2013 10:38:03 -0500<br>From: chip@chipbennett.net<br>To: theme-reviewers@lists.wordpress.org<br>Subject: Re: [theme-reviewers] Custom Post Metas in the Theme<br><br><div dir="ltr">Suspended? Really?</div><div class="ecxgmail_extra"><br><br><div class="ecxgmail_quote">On Fri, Nov 22, 2013 at 10:34 AM, Rohit Tripathi <span dir="ltr"><<a href="mailto:rohitink@live.com" target="_blank">rohitink@live.com</a>></span> wrote:<br>
<blockquote class="ecxgmail_quote" style="border-left:1px #ccc solid;padding-left:1ex;">
<div><div dir="ltr">Shouldn't Hueman be suspended in that case, untill the issues are resolved?<br><br><div><hr>Date: Fri, 22 Nov 2013 10:32:10 -0500<br>From: <a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a><div>
<div class="h5"><br>To: <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>Subject: Re: [theme-reviewers] Custom Post Metas in the Theme<br><br><div dir="ltr">Content generation is currently Plugin territory. Thus, custom post meta used to generate content remain Plugin territory.<div>
<br></div><div>The opportunity for custom-designed Themes has never changed, regardless of criticality of the Theme Unit Tests. Developers have always been and remain welcome to ask for exceptions for special use-case Themes.</div>
</div><div><br><br><div>On Fri, Nov 22, 2013 at 10:30 AM, Zulfikar Nore <span dir="ltr"><<a href="mailto:zulfikarnore@live.com" target="_blank">zulfikarnore@live.com</a>></span> wrote:<br>
<blockquote style="border-left:1px #ccc solid;padding-left:1ex;">
<div><div dir="ltr">Are we to start saying that these are now also plugin territory?<br><br>Having moved from TUT being required and opening up the opportunity for custom designed themes wouldn't making such a restrictive move on custom metas be counter productive?<br>
<br><div><hr>Date: Fri, 22 Nov 2013 15:16:56 +0200<br>From: <a href="mailto:eminozlem@gmail.com" target="_blank">eminozlem@gmail.com</a><div><div><br>To: <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
Subject: Re: [theme-reviewers] Custom Post Metas in the Theme<br><br><div dir="ltr">Definitely agree with that one.<br></div><div><br><br><div>2013/11/22 Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span><br>
<blockquote style="border-left:1px #ccc solid;padding-left:1ex;"><div dir="ltr">That could certainly be added for register_post_type() and register_taxonomy(), but add_meta_box() isn't inherently improper; it all depends on its use.</div>
<div><div><div><br><br><div>
On Fri, Nov 22, 2013 at 8:08 AM, Towfiq I. <span dir="ltr"><<a href="mailto:tislam100@gmail.com" target="_blank">tislam100@gmail.com</a>></span> wrote:<br><blockquote style="border-left:1px #ccc solid;padding-left:1ex;">
<div dir="ltr">when we submit a theme through the uploader. The uploader detects and returns an error when there is a important tag missing. Isn't it possible to make the uploader extend its functionality and check whether the uploaded theme has custom post type registered with register_post_type and if it does, the uploader shows an error and does not continue with the submission process.<div>
<br></div><div>just my 2 bits. </div><div><br></div><div><br></div></div><div><div><div><br><br><div>On Fri, Nov 22, 2013 at 6:34 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote style="border-left:1px #ccc solid;padding-left:1ex;"><div dir="ltr">In this specific instance, I wonder if this isn't a legacy of the in-core-then-removed-in-beta Post Formats UI post-meta handling of post format-specific data? If that's the case, I have less of a concern with the use of custom post meta here - but I'd like to get some clarification from the core devs to know, when the feature is addressed again in the future, if the same post-meta implementation will be used.</div>
<div><div>
<div><br><br><div>On Fri, Nov 22, 2013 at 4:38 AM, Rohit Tripathi <span dir="ltr"><<a href="mailto:rohitink@live.com" target="_blank">rohitink@live.com</a>></span> wrote:<br>
<blockquote style="border-left:1px #ccc solid;padding-left:1ex;">
<div><div dir="ltr">Theme specific design is acceptable. But Enterting MP3 Urls for audio format, and Video Embed Code for Video Formats is not acceptable. This is what is done in the themes i mentioned.<br><br><div><hr>
Date: Fri, 22 Nov 2013 10:37:19 +0100<br>From: <a href="mailto:grapplerulrich@gmail.com" target="_blank">grapplerulrich@gmail.com</a><br>To: <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
Subject: Re: [theme-reviewers] Custom Post Metas in the Theme<div><div><br><br><p dir="ltr">What is wrong with using meta boxes? I do realise that in some cases you would loose data but there are other cases where it can be used for theme specific design. </p>
<p dir="ltr">I suppose these cases would need to be an exception. </p>
<div>On 22 Nov 2013 10:03, "Konstantin Kovshenin" <<a href="mailto:kovshenin@gmail.com" target="_blank">kovshenin@gmail.com</a>> wrote:<br><blockquote style="border-left:1px #ccc solid;padding-left:1ex;">
<div dir="ltr">I think we should be looking for add_meta_box in Theme-Check and register_post_type for that matter.<div><br><br><div>On Fri, Nov 22, 2013 at 11:58 AM, Rohit Tripathi <span dir="ltr"><<a href="mailto:rohitink@live.com" target="_blank">rohitink@live.com</a>></span> wrote:<br>
<blockquote style="border-left:1px #ccc solid;padding-left:1ex;">
<div><div dir="ltr"><div><span style="font-size:12pt;">I recently approved a theme: Anew. But, later on the ticket was opened, and it was pointed out the theme is heavily dependant on Custom Post Metas for Implementation of Post Formats. I Obviously understand, that why its unacceptable. But, i didn't look in the Add New Post section of the theme. So, I clearly missed it.</span></div>
<div><span style="font-size:12pt;"><br></span></div><div>Another Theme from the Same Author, which is currently a Featured Theme: <a href="http://wordpress.org/themes/hueman/" target="_blank">http://wordpress.org/themes/hueman/</a> also depends a lot on Custom Post Meta for implemention Post Formats, violating the WPORG's Functionality Guidelines. Those issues need to be resolved, as users who switch away from the theme would loose significant amount of data.</div>
<div><br></div><div>I am just writing this up here, as we reviewers should start looking carefully in the "Add New Post" areas, as we generally do not look there. </div><div><br></div><div>:)</div> </div>
</div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Konstantin
</div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div>
<br>_______________________________________________
theme-reviewers mailing list
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></div></div></div> </div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br></div></div><span><font color="#888888"><span style="color:rgb(153,153,153);">Towfiq I.</span><br>
</font></span></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________
theme-reviewers mailing list
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></div></div></div> </div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________
theme-reviewers mailing list
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></div></div></div> </div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________
theme-reviewers mailing list
theme-reviewers@lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers</div> </div></body>
</html>