<div dir="ltr">@chip In my case I am only de-registering/registering if ! is_admin and if the use masonry option is selected. Hard to see why someone would use a plugin using masonry and my theme and not disable that option.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Sep 18, 2013 at 7:07 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I don't think it's an inherently ridiculous requirement. For the record, (almost) all guidelines can have exceptions granted - but those exceptions need to be justified. Usually that sort of thing is handled in-ticket, but I think this one makes for a useful and interesting discussion.<div>
<br></div><div>We can assume a couple things:</div><div><br></div><div>1) The core-bundled version is kept in core for a reason</div><div>2) Plugins will use the core-bundled version</div><div><br></div><div>So, any exception to the guideline, if justified and granted, would need to account for those two assumptions. There is an interesting discussion taking place in the Trac ticket, that gives some useful background regarding why v2.x is still bundled with core, as well as the issues that must be overcome in order to bundle the latest version in core.</div>
<div><br></div><div>Given sound justification, and implemented in a way that ensures that the custom-registered version of Masonry plays nicely with core and other Plugins, I would have no problem with allowing an exception, until the core-bundled version is updated.</div>
</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Sep 18, 2013 at 5:21 PM, Josh Pollock <span dir="ltr"><<a href="mailto:jpollock412@gmail.com" target="_blank">jpollock412@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This is a ridiculous requirement.<div><br></div><div>So let's imagine a scenario where a reviewer noticed that my theme deregistered core-bundled Masonry 4 versions or so ago in order to use Masonry 3. That reviewer would have said "Josh you are required to use the version of Masonry that is bundled with WordPress." To which I would have said, "but you see, the version of Masonry in WordPress is very old. The very different new version, allows me to solve all of the weird formatting problems I was getting when using Masonry in my theme." And the reviewer would have reminded me that our guidelines do not have sensible flexibility built-in to allow for the rules to be bent a bit when it solves real world problems. Instead, I'd have been given the choice of removing a feature or allowing my theme to remain broken for an indefinite period of time.</div>
<div><br></div><div>Wouldn't it have been better if the hypothetical reviewer had allowed this rule bending, in the name of making things work, that would have had little to no adverse consequences as long as I agreed to switch to core-bundled Masonry when it was updated to Masonry 3? </div>
<div><br></div><div>See how that second scenario produces better themes, which I think is the point of the theme review guidelines to begin with.</div><div><br></div><div>Of course, my theme works nicely with Masonry, because no one noticed that I acted sensibly instead instead of following the guidelines to the letter, which would have produced an inferior theme.</div>
<div><br></div><div><br></div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Sep 18, 2013 at 4:11 PM, Rohit Tripathi <span dir="ltr"><<a href="mailto:rohitink@live.com" target="_blank">rohitink@live.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div dir="ltr">Great. I am submitting a trac ticket with patch.<div><br><div><hr>Date: Wed, 18 Sep 2013 15:10:37 -0500<br>From: <a href="mailto:dane@danemorganmedia.com" target="_blank">dane@danemorganmedia.com</a><div>
<br>To: <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>Subject: Re: [theme-reviewers] Is it necessary to use Core Bundled Masonry?<br><br></div><div><div>
Chip, do you have a good
resource for me to start learning how to go about doing that?<br>
<br>
<blockquote style="border:0px none">
<div><div style="display:table;width:100%;border-top:1px solid #edeef0;padding-top:5px"> <div style="display:table-cell;vertical-align:middle;padding-right:6px"><img src="cid:part1.07070904.08080104@danemorganmedia.com" height="25px" width="25px"></div>
<div style="display:table-cell;white-space:nowrap;vertical-align:middle;width:100%">
<a href="mailto:chip@chipbennett.net" style="color:#737f92!important;padding-right:6px;font-weight:bold;text-decoration:none!important" target="_blank">Chip Bennett</a></div> <div style="display:table-cell;white-space:nowrap;vertical-align:middle">
<font color="#9FA2A5"><span style="padding-left:6px">Wednesday,
September 18, 2013 15:06</span></font></div></div></div>
<div style="color:#888888"><div dir="ltr">You should
submit a Trac ticket (with patch, if possible) to have the core-bundled
version updated.</div><div><br><br><br></div>
<div>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div>
<div><div style="display:table;width:100%;border-top:1px solid #edeef0;padding-top:5px"> <div style="display:table-cell;vertical-align:middle;padding-right:6px"><img src="cid:part2.00020101.02070309@danemorganmedia.com" height="25px" width="25px"></div>
<div style="display:table-cell;white-space:nowrap;vertical-align:middle;width:100%">
<a href="mailto:tislam100@gmail.com" style="color:#737f92!important;padding-right:6px;font-weight:bold;text-decoration:none!important" target="_blank">Towfiq I.</a></div> <div style="display:table-cell;white-space:nowrap;vertical-align:middle">
<font color="#9FA2A5"><span style="padding-left:6px">Wednesday,
September 18, 2013 15:04</span></font></div></div></div>
<div style="color:#888888"><div dir="ltr">+1 for the
making this allowed.<div><br></div></div><div><br><br><br><br clear="all"><div><br></div>-- <br><span style="color:rgb(153,153,153)">Towfiq
I.</span><br>
</div>
<div>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div>
<div><div style="display:table;width:100%;border-top:1px solid #edeef0;padding-top:5px"> <div style="display:table-cell;vertical-align:middle;padding-right:6px"><img src="cid:part3.03020701.03070909@danemorganmedia.com" height="25px" width="25px"></div>
<div style="display:table-cell;white-space:nowrap;vertical-align:middle;width:100%">
<a href="mailto:rohitink@live.com" style="color:#737f92!important;padding-right:6px;font-weight:bold;text-decoration:none!important" target="_blank">Rohit Tripathi</a></div> <div style="display:table-cell;white-space:nowrap;vertical-align:middle">
<font color="#9FA2A5"><span style="padding-left:6px">Wednesday,
September 18, 2013 15:01</span></font></div></div></div>
<div style="color:#888888">
<div dir="ltr">Here is the latest version:<span style="font-size:12pt"> <a href="http://masonry.desandro.com/masonry.pkgd.min.js" target="_blank">http://masonry.desandro.com/masonry.pkgd.min.js</a></span><div>and
here is the one which wordpress uses: <a href="http://pastebin.com/HtbGdtdK" target="_blank">http://pastebin.com/HtbGdtdK</a></div><div><br></div><div>These
are two really different scripts.<br><div><span style="font-size:12pt"><br></span></div></div>
</div><div>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div>
<div><div style="display:table;width:100%;border-top:1px solid #edeef0;padding-top:5px"> <div style="display:table-cell;vertical-align:middle;padding-right:6px"><img height="25px" width="25px"></div> <div style="display:table-cell;white-space:nowrap;vertical-align:middle;width:100%">
<a href="mailto:rohitink@live.com" style="color:#737f92!important;padding-right:6px;font-weight:bold;text-decoration:none!important" target="_blank">Rohit Tripathi</a></div> <div style="display:table-cell;white-space:nowrap;vertical-align:middle">
<font color="#9FA2A5"><span style="padding-left:6px">Wednesday,
September 18, 2013 14:58</span></font></div></div></div>
<div style="color:#888888">
<div dir="ltr">The core jquery-masonry(v2.1) is
practically useless, it has 1/3rd the amount of code present in the
version 3.1.2. I will be handicapped, if I am forced to use the MUCH
older version, as I am not able to do what I want with it.<div><br></div><div>It's
a request to allow usage of the latest version, as both are really
different.<br><br></div> </div><div>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div>
<div><div style="display:table;width:100%;border-top:1px solid #edeef0;padding-top:5px"> <div style="display:table-cell;vertical-align:middle;padding-right:6px"><img src="cid:part5.00070304.03070605@danemorganmedia.com" height="25px" width="25px"></div>
<div style="display:table-cell;white-space:nowrap;vertical-align:middle;width:100%">
<a href="mailto:emil@uzelac.me" style="color:#737f92!important;padding-right:6px;font-weight:bold;text-decoration:none!important" target="_blank">Emil Uzelac</a></div> <div style="display:table-cell;white-space:nowrap;vertical-align:middle">
<font color="#9FA2A5"><span style="padding-left:6px">Wednesday,
September 18, 2013 14:54</span></font></div></div></div>
<div style="color:#888888"><p dir="ltr">Hi,</p>
<p dir="ltr">Yes it's requirement to use core bundled scripts.</p>
<p dir="ltr">Emil</p>
<div>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div>
</blockquote>
<br>_______________________________________________
theme-reviewers mailing list
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></div></div></div></div> </div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>