<div dir="ltr">I would approve (assuming no other issues), but require the developer to replace SMOF in the next revision.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Sep 10, 2013 at 12:09 PM, Srikanth Koneru <span dir="ltr"><<a href="mailto:tskk79@gmail.com" target="_blank">tskk79@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">If an already approved theme is using SMOF, should i not-approve it or can it stay?<br></div><div class="HOEnZb">
<div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 6, 2013 at 12:14 AM, Towfiq I. <span dir="ltr"><<a href="mailto:tislam100@gmail.com" target="_blank">tislam100@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I found another options framework, released under GPL v3. Should I use this:<br><a href="http://en.bainternet.info/2012/my-options-panel" target="_blank">http://en.bainternet.info/2012/my-options-panel</a><br>
<a href="https://github.com/bainternet/Admin-Page-Class" target="_blank">https://github.com/bainternet/Admin-Page-Class</a><br>
<div><br></div><div>Thanks</div><div><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On Thu, Sep 5, 2013 at 11:49 PM, Towfiq I. <span dir="ltr"><<a href="mailto:tislam100@gmail.com" target="_blank">tislam100@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">damn. I started building my new theme with SMOF. :/<div>I preferred SMOF over original options framework because of the backup options feature.</div>
</div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Thu, Sep 5, 2013 at 11:47 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">If I were reviewing a Theme that bundled SMOF, I would challenge the GPL-compatibility of the license terms. So, I would say "no".</div><div><div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Thu, Sep 5, 2013 at 1:45 PM, Towfiq I. <span dir="ltr"><<a href="mailto:tislam100@gmail.com" target="_blank">tislam100@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">So is it allowed to use the SMOF?</div><div><div><div class="gmail_extra"><br>
<br><div class="gmail_quote">On Thu, Sep 5, 2013 at 11:34 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Awesome :)</div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Thu, Sep 5, 2013 at 12:33 PM, Towfiq I. <span dir="ltr"><<a href="mailto:tislam100@gmail.com" target="_blank">tislam100@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks Emil. This is what I was referring to.yes.<div><br></div><div>and I use options framework by devin in my themes. So the points mentioned by Chip is already being done in my themes. </div>
<div>and yes Chip I was thinking that too. Its an overkill..</div>
<div><br></div></div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On Thu, Sep 5, 2013 at 11:29 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">What Towfiq was saying is something like this: <a href="http://www.presscoders.com/2011/10/better-theme-activation-handling/" target="_blank">http://www.presscoders.com/2011/10/better-theme-activation-handling/</a><div>
<br>
</div><div>But I like what @Chip linked better :)<br><div><br></div><div><br></div></div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 5, 2013 at 12:20 PM, <span dir="ltr"><<a href="mailto:wordpress@thinkupthemes.com" target="_blank">wordpress@thinkupthemes.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Totally agree! The theme should still look like a theme when activated. I'd suggest that you have clear documentation so users know they can change options from the theme options page. Make it super clear.<br>
<br>
So would I be right in assuming that SMOF is allowed then? I'll submit my theme next week and can completely strip it out if SMOF is not allowed, but didn't want to as I thought it would be cool to give a premium level theme for free.<br>
<br>
Afzaal<br>
<br>
<br>
<br>
Quoting Chip Bennett <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>>:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
You should never, ever need to redirect the user to the Theme options page<br>
upon activation.<br>
<br>
Instead, the Theme should define and use sane defaults as a fallback, in<br>
case the user does not configure Theme options.<br>
<br>
<br>
On Thu, Sep 5, 2013 at 1:01 PM, Towfiq I. <<a href="mailto:tislam100@gmail.com" target="_blank">tislam100@gmail.com</a>> wrote:<br>
<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
on a different note, is it possible to redirect the user to theme options<br>
page after activating the theme? If so, how?<br>
<br>
Thanks<br>
<br>
<br>
On Thu, Sep 5, 2013 at 10:58 PM, <<a href="mailto:wordpress@thinkupthemes.com" target="_blank">wordpress@thinkupthemes.com</a>> wrote:<br>
<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
Thanks Harish,<br>
<br>
Great idea. I'll add a recommendation for the plugin to be installed<br>
using TGM activation. Thanks, I'll remove this and take your advice.<br>
<br>
Afzaal<br>
<br>
<br>
<br>
<br>
Quoting Harish <<a href="mailto:me@harishchouhan.com" target="_blank">me@harishchouhan.com</a>>:<br>
<br>
Hi,<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
<br>
Any reason why you want to roll in the twitter widget in your theme?<br>
Simply<br>
show a message after activation to help people download the plugin. Will<br>
make your theme smaller and if the users change theme, they won't lose<br>
their<br>
twitter widget.<br>
<br>
<br>
<br>
<br>
Regards,<br>
Harish Chouhan<br>
<br>
Visit me at - <a href="http://www.harishchouhan.com" target="_blank">www.harishchouhan.com</a><br>
Phone: <a href="tel:%2B91-9833661410" value="+919833661410" target="_blank">+91-9833661410</a> | Email: <a href="mailto:me@harishchouhan.com" target="_blank">me@harishchouhan.com</a><br>
<br>
-----Original Message-----<br></div></div><div>
From: theme-reviewers [mailto:<a href="mailto:theme-reviewers-" target="_blank">theme-reviewers-</a>**<br>
<a href="mailto:bounces@lists.wordpress.org" target="_blank">bounces@lists.wordpress.org</a><<a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">th<u></u>eme-reviewers-bounces@lists.<u></u>wordpress.org</a>><br>
]<br>
On Behalf Of <a href="mailto:wordpress@thinkupthemes.com" target="_blank">wordpress@thinkupthemes.com</a><br>
Sent: Thu 05 September 13 10:21 PM<br></div><div>
To: theme-reviewers@lists.**<a href="http://wordpress.org" target="_blank">wordpr<u></u>ess.org</a><<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a>><br>
Subject: [theme-reviewers] Is SMOF framework allowed?<br>
<br>
Hello all,<br>
<br>
I'm in the final stages of completing my WordPress theme and think people<br>
may find it useful so am thinking about trying to get it into the<br>
WordPress<br>
repository. I've noticed a few warnings however that have appeared when<br>
running theme-check.<br>
<br>
1. base64_encode error in the framework SMOF. I used this because of the<br></div>
referral on <a href="http://codex.wordpress.org/**Theme_Frameworks" target="_blank">http://codex.wordpress.org/**<u></u>Theme_Frameworks</a><<a href="http://codex.wordpress.org/Theme_Frameworks" target="_blank">http://codex.<u></u>wordpress.org/Theme_Frameworks</a><u></u>><div>
<br>
.<br>
<br>
2. base64_encode in the Twitter feed widget which I've packaged into the<br></div>
theme <a href="http://wordpress.org/plugins/**tweetscroll-widget/" target="_blank">http://wordpress.org/plugins/*<u></u>*tweetscroll-widget/</a><<a href="http://wordpress.org/plugins/tweetscroll-widget/" target="_blank">http://<u></u>wordpress.org/plugins/<u></u>tweetscroll-widget/</a>><div>
<br>
.<br>
<br>
If anyone can shed any light on if these are major errors I'd really<br>
appreciate your help. I really want to make sure that my themes are 100%<br>
safe so am spending a lot of time on finding any errors.<br>
<br>
Thank you so much in advance.<br>
<br>
Afzaal<br>
<br></div>
______________________________<u></u>**_________________<br>
theme-reviewers mailing list<br>
theme-reviewers@lists.**<a href="http://wordpress.org" target="_blank">wordpr<u></u>ess.org</a><<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a>><br>
<a href="http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers" target="_blank">http://lists.wordpress.org/**<u></u>mailman/listinfo/theme-**<u></u>reviewers</a><<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.<u></u>wordpress.org/mailman/<u></u>listinfo/theme-reviewers</a>><br>
<br>
______________________________<u></u>**_________________<br>
theme-reviewers mailing list<br>
theme-reviewers@lists.**<a href="http://wordpress.org" target="_blank">wordpr<u></u>ess.org</a><<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a>><br>
<a href="http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers" target="_blank">http://lists.wordpress.org/**<u></u>mailman/listinfo/theme-**<u></u>reviewers</a><<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.<u></u>wordpress.org/mailman/<u></u>listinfo/theme-reviewers</a>><br>
<br>
<br>
</blockquote>
<br>
<br>
______________________________<u></u>**_________________<br>
theme-reviewers mailing list<br>
theme-reviewers@lists.**<a href="http://wordpress.org" target="_blank">wordpr<u></u>ess.org</a><<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a>><br>
<a href="http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers" target="_blank">http://lists.wordpress.org/**<u></u>mailman/listinfo/theme-**<u></u>reviewers</a><<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.<u></u>wordpress.org/mailman/<u></u>listinfo/theme-reviewers</a>><br>
<br>
</blockquote><div>
<br>
<br>
<br>
--<br>
Towfiq I.<br>
<br>
______________________________<u></u>_________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/<u></u>mailman/listinfo/theme-<u></u>reviewers</a><br>
<br>
<br>
</div></blockquote>
<br>
</blockquote>
<br>
<br><div><div>
<br>
______________________________<u></u>_________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/<u></u>mailman/listinfo/theme-<u></u>reviewers</a><br>
</div></div></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><span style="color:rgb(153,153,153)">Towfiq I.</span><br>
</font></span></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><span style="color:rgb(153,153,153)">Towfiq I.</span><br>
</div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><span style="color:rgb(153,153,153)">Towfiq I.</span><br>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><span style="color:rgb(153,153,153)">Towfiq I.</span><br>
</font></span></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>