<div dir="ltr">Additional: Putting the array into a variable makes perfect sense when you're going to pass it through a filter before sending it to the function call, to give other code a chance to modify the arguments.<div>
<br><div><br></div></div></div><div class="gmail_extra"><br clear="all"><div>-Otto</div>
<br><br><div class="gmail_quote">On Fri, Sep 6, 2013 at 2:58 PM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Whether it is in a variable or not, prefixing it instead of using something like "$args" is really unarguable. Clarity, no mucking with potential globals, etc.<div><br></div><div>However, I personally prefer this style:</div>
<div><br></div><div>wp_function_call( array (</div><div> 'key1' => 'value1',</div><div> 'key2' => 'value2',<br></div><div> 'key3' => 'value3',<br></div><div>) );</div>
<div><br></div><div>It keeps the arguments orderly and close to the function call in which they're being used. You could put the array in a variable and then pass in the variable, but this only makes sense when the array is complex or needs to be built up from pieces. Even then, usually those pieces are simple other variables in your function, so your call becomes this:</div>
<div><br></div><div><div>wp_function_call( array (</div><div> 'key1' => $value,</div><div> 'key2' => $whatever,<br></div><div> 'key3' => $some_other_thing,<br></div><div>) );</div></div>
<div><br></div><div>It's just a cleaner look, I feel. But either way works.</div><div class="gmail_extra"><span class="HOEnZb"><font color="#888888"><br clear="all"><div>-Otto</div></font></span><div><div class="h5">
<br><br><br><div class="gmail_quote">On Fri, Sep 6, 2013 at 2:36 PM, Doug Stewart <span dir="ltr"><<a href="mailto:zamoose@gmail.com" target="_blank">zamoose@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">In re: point #4: why? Adding the arrays in-line can contribute to greater illegibility, particularly when the number of array elements grows large.<div><br></div><div>Color me old-fashioned, but doing it that way strikes me as a hard requirement with little actual utility.</div>
</div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On Wed, Sep 4, 2013 at 10:28 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Nice! Please see my comment: <a href="https://gist.github.com/GaryJones/1698719" target="_blank">https://gist.github.com/GaryJones/1698719</a> we need small change :)</div><div><div>
<div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, Sep 4, 2013 at 9:26 PM, Dane Morgan <span dir="ltr"><<a href="mailto:dane@danemorganmedia.com" target="_blank">dane@danemorganmedia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">I'm sorry, I had meant to
ask if that could be done with scripts as well. I initially found it in a
reference that implied that you could do the same thing to enqueued
scripts, but I never chased it down to see how.<br>
<br>
<blockquote style="border:0px none" type="cite"><div>
<div style="margin:30px 25px 10px 25px"><div style="display:table;width:100%;border-top:1px solid #edeef0;padding-top:5px"> <div style="display:table-cell;vertical-align:middle;padding-right:6px"><img src="cid:part1.08080804.06070106@danemorganmedia.com" name="140f4db0044b6acc_140f4c7588c04a17_140ebf3492fe9b83_140ebf128be576f0_postbox-contact.jpg" height="25px" width="25px"></div>
<div style="display:table-cell;white-space:nowrap;vertical-align:middle;width:100%">
<a href="mailto:emil@uzelac.me" style="color:#737f92!important;padding-right:6px;font-weight:bold;text-decoration:none!important" target="_blank">Emil Uzelac</a></div> <div style="display:table-cell;white-space:nowrap;vertical-align:middle">
<font color="#9FA2A5"><span style="padding-left:6px">Wednesday,
September 04, 2013 20:58</span></font></div></div></div>
</div><div style="color:#888888;margin-left:24px;margin-right:24px"><div dir="ltr"><a href="http://lists.wordpress.org/pipermail/theme-reviewers/2013-June/013545.html" target="_blank">http://lists.wordpress.org/pipermail/theme-reviewers/2013-June/013545.html</a><br>
</div><div class="gmail_extra"><br><br><br></div><div>
<div>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></div><div>
<div style="margin:30px 25px 10px 25px"><div style="display:table;width:100%;border-top:1px solid #edeef0;padding-top:5px"> <div style="display:table-cell;vertical-align:middle;padding-right:6px"><img src="cid:part2.08020400.07080908@danemorganmedia.com" name="140f4db0044b6acc_140f4c7588c04a17_140ebf3492fe9b83_140ebf128be576f0_postbox-contact.jpg" height="25px" width="25px"></div>
<div style="display:table-cell;white-space:nowrap;vertical-align:middle;width:100%">
<a href="mailto:dane@danemorganmedia.com" style="color:#737f92!important;padding-right:6px;font-weight:bold;text-decoration:none!important" target="_blank">Dane Morgan</a></div> <div style="display:table-cell;white-space:nowrap;vertical-align:middle">
<font color="#9FA2A5"><span style="padding-left:6px">Wednesday,
September 04, 2013 20:12</span></font></div></div></div>
</div><div><div style="color:#888888;margin-left:24px;margin-right:24px">
I was wondering the same
thing<br>
<br>
</div>
</div><div><div style="margin:30px 25px 10px 25px"><div style="display:table;width:100%;border-top:1px solid #edeef0;padding-top:5px"> <div style="display:table-cell;vertical-align:middle;padding-right:6px">
<img src="cid:part3.02030305.00080800@danemorganmedia.com" name="140f4db0044b6acc_140f4c7588c04a17_140ebf3492fe9b83_140ebf128be576f0_postbox-contact.jpg" height="25px" width="25px"></div> <div style="display:table-cell;white-space:nowrap;vertical-align:middle;width:100%">
<a href="mailto:jpollock412@gmail.com" style="color:#737f92!important;padding-right:6px;font-weight:bold;text-decoration:none!important" target="_blank">Josh Pollock</a></div> <div style="display:table-cell;white-space:nowrap;vertical-align:middle">
<font color="#9FA2A5"><span style="padding-left:6px">Wednesday,
September 04, 2013 19:17</span></font></div></div></div>
</div><div style="color:#888888;margin-left:24px;margin-right:24px"><div><div dir="ltr">Why are the IE
compatibility scripts hardcoded instead of echoed in a function hooked
to wp_head? I'm wondering both in terms of why hardcoding is standard
practice and why hooking to wp_head isn't required.</div>
<div class="gmail_extra"><br><br><br></div>
</div><div><div>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></div><div>
<div style="margin:30px 25px 10px 25px"><div style="display:table;width:100%;border-top:1px solid #edeef0;padding-top:5px"> <div style="display:table-cell;vertical-align:middle;padding-right:6px"><img src="cid:part4.03030707.01010606@danemorganmedia.com" name="140f4db0044b6acc_140f4c7588c04a17_140ebf3492fe9b83_140ebf128be576f0_postbox-contact.jpg" height="25px" width="25px"></div>
<div style="display:table-cell;white-space:nowrap;vertical-align:middle;width:100%">
<a href="mailto:chip@chipbennett.net" style="color:#737f92!important;padding-right:6px;font-weight:bold;text-decoration:none!important" target="_blank">Chip Bennett</a></div> <div style="display:table-cell;white-space:nowrap;vertical-align:middle">
<font color="#9FA2A5"><span style="padding-left:6px">Wednesday,
September 04, 2013 18:53</span></font></div></div></div>
</div><div style="color:#888888;margin-left:24px;margin-right:24px"><div><div dir="ltr">There's not much
that can be done right now, until this ticket makes it into core:<div><a href="http://core.trac.wordpress.org/ticket/16024" target="_blank">http://core.trac.wordpress.org/ticket/16024</a><br></div><div>
<br></div><div>In the meantime, those scripts can optionally be
hard-coded in the document head (though they could be recommended to be
added via callback hooked into wp_head).</div></div><div class="gmail_extra"><br><br>
<br></div>
</div><div><div>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></div><div>
<div style="margin:30px 25px 10px 25px"><div style="display:table;width:100%;border-top:1px solid #edeef0;padding-top:5px"> <div style="display:table-cell;vertical-align:middle;padding-right:6px"><img src="cid:part5.04040709.00020903@danemorganmedia.com" name="140f4db0044b6acc_140f4c7588c04a17_140ebf3492fe9b83_140ebf128be576f0_postbox-contact.jpg" height="25px" width="25px"></div>
<div style="display:table-cell;white-space:nowrap;vertical-align:middle;width:100%">
<a href="mailto:grapplerulrich@gmail.com" style="color:#737f92!important;padding-right:6px;font-weight:bold;text-decoration:none!important" target="_blank">Ulrich Pogson</a></div> <div style="display:table-cell;white-space:nowrap;vertical-align:middle">
<font color="#9FA2A5"><span style="padding-left:6px">Wednesday,
September 04, 2013 18:35</span></font></div></div></div>
</div><div style="color:#888888;margin-left:24px;margin-right:24px"><p dir="ltr">@chip what is your
recommendation for including IE specific scripts in the header? I am
talking about the second point you mentioned. </p><div>
<div>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></div>
</blockquote>
</div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br>-Doug<br><br><br>
</font></span></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div></div>
</blockquote></div><br></div>