<HTML><HEAD></HEAD>
<BODY dir=ltr>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: 12pt">
<DIV>I thought that was your intention at first but there have been ‘many’
requirements popping up that were.. uhm, arguable? so I wanted to make sure
;)</DIV>
<DIV> </DIV>
<DIV>- Phil</DIV>
<DIV> </DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV style="FONT: 10pt tahoma">
<DIV> </DIV>
<DIV style="BACKGROUND: #f5f5f5">
<DIV style="font-color: black"><B>From:</B> <A title=chip@chipbennett.net
href="mailto:chip@chipbennett.net">Chip Bennett</A> </DIV>
<DIV><B>Sent:</B> Wednesday, September 04, 2013 3:57 PM</DIV>
<DIV><B>To:</B> <A title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org">Discussion list for WordPress
theme reviewers.</A> </DIV>
<DIV><B>Subject:</B> Re: [theme-reviewers] Common Things Overlooked in Theme
Reviews</DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV dir=ltr>That was probably poorly worded; blame it on being hopped up on
NSAIDs and putting in far too many hours of work. :)
<DIV> </DIV>
<DIV>I don't mean to imply that Themes are *required* to include any particular
template file (other than index.php, of course). What I intended to say was
that, if a Theme provides a template file for a particular context, then it must
use the appropriate template file as per the Template Hierarchy. So, if a Theme
includes a template file that is intended for the site front page, then that
template file must be named "front-page.php" - and if a Theme includes a
template file that is intended for the blog posts index, then that template file
must be named "home.php".</DIV></DIV>
<DIV class=gmail_extra><BR><BR>
<DIV class=gmail_quote>On Wed, Sep 4, 2013 at 6:47 PM, Philip M. Hofer (Frumph)
<SPAN dir=ltr><<A href="mailto:philip@frumph.net"
target=_blank>philip@frumph.net</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: 'Calibri'; FONT-SIZE: 12pt">
<DIV>“Themes must use front-page.php for the *site front page*, and that must
account for both the blog posts index and a static page as front page.”</DIV>
<DIV> </DIV>
<DIV>_________________________________________________</DIV>
<DIV> </DIV>
<DIV>I believe you’re thinking index.php as a requirement </DIV>
<DIV> </DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">front-page.php
in hierarchy is an override to the index.php, i.e. takes precedence if
used</DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none"> </DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none"><A
title=http://codex.wordpress.org/Template_Hierarchy
href="http://codex.wordpress.org/Template_Hierarchy"
target=_blank>http://codex.wordpress.org/Template_Hierarchy</A></DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none"> </DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">ref:
wp-includes/template-loader.php, wp-includes/template.php
get_front_page_template() get_home_template()</DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none"> </DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">if
the $wp_query->has set</DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none"> </DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">is_front_page()
calls front-page.php </DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none"> </DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">is_home()
calls home.php and index.php</DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none"> </DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">index.php’s
loop needs to handle them both for display, if has posts –> loop display,
front-page.php is an override to both</DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none"> </DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">Looks
for front-page.php –> then</DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">Looks
for home.php, if not find looks for index.php if neither the
front-page.php nor home.php there MUST be /required/ an index.php</DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none"> </DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">hence
the index.php should be the requirement since if all 3 don’t exist, it must
minimally have at least index.php</DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none"> </DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none"> </DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none"> </DIV></DIV>
<DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none"></DIV>
<DIV style="FONT: 10pt tahoma">
<DIV style="BACKGROUND: #f5f5f5">
<DIV><B>From:</B> <A title=zulfikarnore@live.com
href="mailto:zulfikarnore@live.com" target=_blank>Zulfikar Nore</A> </DIV>
<DIV><B>Sent:</B> Wednesday, September 04, 2013 3:15 PM</DIV>
<DIV><B>To:</B> <A title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org" target=_blank>Theme
Reviewers</A> </DIV>
<DIV>
<DIV class=h5>
<DIV><B>Subject:</B> Re: [theme-reviewers] Common Things Overlooked in Theme
Reviews</DIV></DIV></DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV>
<DIV class=h5>
<DIV dir=ltr>This is exactly what I just set out to research as I've made some
of those mistakes in my reviews.
<DIV> </DIV>
<DIV>Thanks for the clarification @Chip and @Emil :)<BR><BR>Zul<BR>
<DIV>
<HR>
Date: Wed, 4 Sep 2013 16:21:18 -0500<BR>From: <A href="mailto:emil@uzelac.me"
target=_blank>emil@uzelac.me</A><BR>To: <A
href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR>Subject: Re:
[theme-reviewers] Common Things Overlooked in Theme Reviews<BR><BR>
<DIV dir=ltr>Hi TR's,
<DIV> </DIV>
<DIV>If I may add few things:</DIV>
<DIV> </DIV>
<DIV><A
href="http://codex.wordpress.org/Theme_Review#Licensing.2C_Theme_Name.2C_Credit_Links.2C_Up-Sell_Themes:"
target=_blank>Theme Names</A>: </DIV>
<DIV>
<UL>
<LI>No "Mobile, Bootstrap Portfolio" types please.<BR>
<LI>Child Themes need unique names, we cannot use "Twenty Thirteen
Child".</LI></UL>
<DIV>For some reason we no longer have the guidelines for Child Themes and we
need them.</DIV></DIV>
<DIV>This is something we need to look into soon.</DIV>
<DIV> </DIV>
<DIV>Before we did not allow Child Themes that are pretty much the same as the
Parent Theme</DIV>
<DIV>meaning that author can't just change the background, colors in general,
fonts or simply</DIV>
<DIV>add post formats, additional languages and pass that as the Child
Theme.</DIV>
<DIV> </DIV>
<DIV>Design should be different and we don't care much for extended
functionalities :)<BR></DIV>
<DIV> </DIV>
<DIV>Thanks,</DIV>
<DIV>Emil</DIV></DIV>
<DIV><BR><BR>
<DIV>On Wed, Sep 4, 2013 at 3:41 PM, Chip Bennett <SPAN dir=ltr><<A
href="mailto:chip@chipbennett.net"
target=_blank>chip@chipbennett.net</A>></SPAN> wrote:<BR>
<BLOCKQUOTE style="BORDER-LEFT: #ccc 1px solid; PADDING-LEFT: 1ex">
<DIV dir=ltr>Good afternoon, Theme Reviewers!
<DIV> </DIV>
<DIV>As I perform the final "QA" audit of approved Themes before pushing
them Live, I've noticed several things that come up frequently:</DIV>
<DIV> </DIV>
<DIV>1. <title> tag: the content of the <title> tag must be
*only* the call to wp_title() with its parameters. All additional content
must be added via `wp_title` filter</DIV>
<DIV> </DIV>
<DIV>2. Document head stylesheet links: all stylesheets, scripts, and
stylesheet/script links in the document head and footer must be enqueued,
rather than hard-coded. Common culprits are GoogleFont stylesheet
links</DIV>
<DIV> </DIV>
<DIV>3. wp_nav_menu(): Themes must use the theme_location parameter, and NOT
the menu parameter, in calls to wp_nav_menu(). The theme_location parameter
corresponds to the array key used in the
register_nav_menu()/register_nav_menus() call. The menu parameter
corresponds to the slug for a *user-defined* custom nav menu.</DIV>
<DIV> </DIV>
<DIV>4. Namespacing arguments arrays: Please place arguments arrays directly
inside of the function calls to which they apply, or properly namespace the
variable used to hold the array:</DIV>
<DIV> </DIV>
<BLOCKQUOTE
style="BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0px; PADDING-LEFT: 0px; PADDING-RIGHT: 0px; BORDER-TOP: medium none; BORDER-RIGHT: medium none; PADDING-TOP: 0px">
<DIV>$args = array( /* ... */ )</DIV>
<DIV>wp_nav_menu( $args );</DIV>
<DIV> </DIV>
<DIV>Instead do one of the following:</DIV>
<DIV> </DIV>
<DIV>wp_nav_menu( array( /* ... */ );</DIV>
<DIV> </DIV>
<DIV>or </DIV>
<DIV> </DIV>
<DIV>$themeslug_primary_menu_args = array( /* ... */ )</DIV>
<DIV>wp_nav_menu( $themeslug_primary_menu_args ;</DIV></BLOCKQUOTE>
<DIV> </DIV>
<DIV>5. Confusion between the *site front page* and the *blog posts index*:
is_front_page() vs is_home(), front-page.php vs home.php (and confusing
custom page template names), etc. Themes must use front-page.php for the
*site front page*, and that must account for both the blog posts index and a
static page as front page.</DIV>
<DIV> </DIV>
<DIV>6. Child Theme Friendliness: be cognizant of the differences between
get_template_directory() and get_stylesheet_directory(), and the appropriate
uses for each. Any asset that is NOT intended to be overridden in a Child
Theme (e.g. Theme options) *must* use get_template_directory().</DIV>
<DIV> </DIV>
<DIV>Thanks, everyone, for all your time and contribution to Theme
review!</DIV><SPAN><FONT color=#888888>
<DIV> </DIV>
<DIV>Chip</DIV></FONT></SPAN></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV><BR>_______________________________________________
theme-reviewers mailing list <A
href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A> <A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A></DIV></DIV></DIV></DIV></DIV>
<HR>
<DIV
class=im>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR></DIV></DIV></DIV></DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV>
<P>
<HR>
_______________________________________________<BR>theme-reviewers mailing
list<BR>theme-reviewers@lists.wordpress.org<BR>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR></DIV></DIV></DIV></BODY></HTML>