<div dir="ltr">That was probably poorly worded; blame it on being hopped up on NSAIDs and putting in far too many hours of work. :)<div><br></div><div>I don't mean to imply that Themes are *required* to include any particular template file (other than index.php, of course). What I intended to say was that, if a Theme provides a template file for a particular context, then it must use the appropriate template file as per the Template Hierarchy. So, if a Theme includes a template file that is intended for the site front page, then that template file must be named "front-page.php" - and if a Theme includes a template file that is intended for the blog posts index, then that template file must be named "home.php".</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Sep 4, 2013 at 6:47 PM, Philip M. Hofer (Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div dir="ltr">
<div style="font-size:12pt;font-family:'Calibri'">
<div>“Themes must use front-page.php for the *site front page*, and that must
account for both the blog posts index and a static page as front page.”</div>
<div> </div>
<div>_________________________________________________</div>
<div> </div>
<div>I believe you’re thinking index.php as a requirement </div>
<div> </div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal">front-page.php
in hierarchy is an override to the index.php, i.e. takes precedence if
used</div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"> </div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"><a title="http://codex.wordpress.org/Template_Hierarchy" href="http://codex.wordpress.org/Template_Hierarchy" target="_blank">http://codex.wordpress.org/Template_Hierarchy</a></div>
</div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"> </div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal">ref:
wp-includes/template-loader.php, wp-includes/template.php
get_front_page_template() get_home_template()</div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"> </div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal">if
the $wp_query->has set</div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"> </div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal">is_front_page()
calls front-page.php </div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"> </div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal">is_home()
calls home.php and index.php</div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"> </div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal">index.php’s
loop needs to handle them both for display, if has posts –> loop display,
front-page.php is an override to both</div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"> </div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal">Looks
for front-page.php –> then</div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal">Looks
for home.php, if not find looks for index.php if neither the
front-page.php nor home.php there MUST be /required/ an index.php</div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"> </div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal">hence
the index.php should be the requirement since if all 3 don’t exist, it must
minimally have at least index.php</div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"> </div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"> </div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"> </div></div>
<div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"></div>
<div style="FONT:10pt tahoma">
<div style="BACKGROUND:#f5f5f5">
<div><b>From:</b> <a title="zulfikarnore@live.com" href="mailto:zulfikarnore@live.com" target="_blank">Zulfikar Nore</a> </div>
<div><b>Sent:</b> Wednesday, September 04, 2013 3:15 PM</div>
<div><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">Theme Reviewers</a> </div><div><div class="h5">
<div><b>Subject:</b> Re: [theme-reviewers] Common Things Overlooked in Theme
Reviews</div></div></div></div></div>
<div> </div></div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"><div><div class="h5">
<div dir="ltr">This is exactly what I just set out to research as I've made some
of those mistakes in my reviews.
<div> </div>
<div>Thanks for the clarification @Chip and @Emil :)<br><br>Zul<br>
<div>
<hr>
Date: Wed, 4 Sep 2013 16:21:18 -0500<br>From: <a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a><br>To:
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>Subject: Re: [theme-reviewers] Common
Things Overlooked in Theme Reviews<br><br>
<div dir="ltr">Hi TR's,
<div> </div>
<div>If I may add few things:</div>
<div> </div>
<div><a href="http://codex.wordpress.org/Theme_Review#Licensing.2C_Theme_Name.2C_Credit_Links.2C_Up-Sell_Themes:" target="_blank">Theme Names</a>: </div>
<div>
<ul>
<li>No "Mobile, Bootstrap Portfolio" types please.<br>
</li><li>Child Themes need unique names, we cannot use "Twenty Thirteen
Child".</li></ul>
<div>For some reason we no longer have the guidelines for Child Themes and we
need them.</div></div>
<div>This is something we need to look into soon.</div>
<div> </div>
<div>Before we did not allow Child Themes that are pretty much the same as the
Parent Theme</div>
<div>meaning that author can't just change the background, colors in general,
fonts or simply</div>
<div>add post formats, additional languages and pass that as the Child
Theme.</div>
<div> </div>
<div>Design should be different and we don't care much for extended
functionalities :)<br></div>
<div> </div>
<div>Thanks,</div>
<div>Emil</div></div>
<div><br><br>
<div>On Wed, Sep 4, 2013 at 3:41 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT:#ccc 1px solid;PADDING-LEFT:1ex">
<div dir="ltr">Good afternoon, Theme Reviewers!
<div> </div>
<div>As I perform the final "QA" audit of approved Themes before pushing them
Live, I've noticed several things that come up frequently:</div>
<div> </div>
<div>1. <title> tag: the content of the <title> tag must be *only*
the call to wp_title() with its parameters. All additional content must be
added via `wp_title` filter</div>
<div> </div>
<div>2. Document head stylesheet links: all stylesheets, scripts, and
stylesheet/script links in the document head and footer must be enqueued,
rather than hard-coded. Common culprits are GoogleFont stylesheet links</div>
<div> </div>
<div>3. wp_nav_menu(): Themes must use the theme_location parameter, and NOT
the menu parameter, in calls to wp_nav_menu(). The theme_location parameter
corresponds to the array key used in the
register_nav_menu()/register_nav_menus() call. The menu parameter corresponds
to the slug for a *user-defined* custom nav menu.</div>
<div> </div>
<div>4. Namespacing arguments arrays: Please place arguments arrays directly
inside of the function calls to which they apply, or properly namespace the
variable used to hold the array:</div>
<div> </div>
<blockquote style="BORDER-BOTTOM:medium none;BORDER-LEFT:medium none;PADDING-BOTTOM:0px;PADDING-LEFT:0px;PADDING-RIGHT:0px;BORDER-TOP:medium none;BORDER-RIGHT:medium none;PADDING-TOP:0px">
<div>$args = array( /* ... */ )</div>
<div>wp_nav_menu( $args );</div>
<div> </div>
<div>Instead do one of the following:</div>
<div> </div>
<div>wp_nav_menu( array( /* ... */ );</div>
<div> </div>
<div>or </div>
<div> </div>
<div>$themeslug_primary_menu_args = array( /* ... */ )</div>
<div>wp_nav_menu( $themeslug_primary_menu_args ;</div></blockquote>
<div> </div>
<div>5. Confusion between the *site front page* and the *blog posts index*:
is_front_page() vs is_home(), front-page.php vs home.php (and confusing custom
page template names), etc. Themes must use front-page.php for the *site front
page*, and that must account for both the blog posts index and a static page
as front page.</div>
<div> </div>
<div>6. Child Theme Friendliness: be cognizant of the differences between
get_template_directory() and get_stylesheet_directory(), and the appropriate
uses for each. Any asset that is NOT intended to be overridden in a Child
Theme (e.g. Theme options) *must* use get_template_directory().</div>
<div> </div>
<div>Thanks, everyone, for all your time and contribution to Theme
review!</div><span><font color="#888888">
<div> </div>
<div>Chip</div></font></span></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div>
<div> </div></div><br>_______________________________________________
theme-reviewers mailing list <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></div></div></div>
</div></div><p>
</p><hr><div class="im">
_______________________________________________<br>theme-reviewers mailing
list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div><p></p></div></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>