<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>This is exactly what I just set out to research as I've made some of those mistakes in my reviews.<div><br></div><div>Thanks for the clarification @Chip and @Emil :)<br><br>Zul<br><div><hr id="stopSpelling">Date: Wed, 4 Sep 2013 16:21:18 -0500<br>From: emil@uzelac.me<br>To: theme-reviewers@lists.wordpress.org<br>Subject: Re: [theme-reviewers] Common Things Overlooked in Theme Reviews<br><br><div dir="ltr">Hi TR's,<div><br></div><div>If I may add few things:</div><div><br></div><div><a href="http://codex.wordpress.org/Theme_Review#Licensing.2C_Theme_Name.2C_Credit_Links.2C_Up-Sell_Themes:" target="_blank">Theme Names</a>: </div>
<div><ul><li>No "Mobile, Bootstrap Portfolio" types please.<br></li><li>Child Themes need unique names, we cannot use "Twenty Thirteen Child".</li></ul><div>For some reason we no longer have the guidelines for Child Themes and we need them.</div>
</div><div>This is something we need to look into soon.</div><div><br></div><div>Before we did not allow Child Themes that are pretty much the same as the Parent Theme</div><div>meaning that author can't just change the background, colors in general, fonts or simply</div>
<div>add post formats, additional languages and pass that as the Child Theme.</div><div><br></div><div>Design should be different and we don't care much for extended functionalities :)<br></div><div><br></div><div>Thanks,</div>
<div>
Emil</div></div><div class="ecxgmail_extra"><br><br><div class="ecxgmail_quote">On Wed, Sep 4, 2013 at 3:41 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="ecxgmail_quote" style="border-left:1px #ccc solid;padding-left:1ex;"><div dir="ltr">Good afternoon, Theme Reviewers!<div><br></div><div>As I perform the final "QA" audit of approved Themes before pushing them Live, I've noticed several things that come up frequently:</div>
<div>
<br></div><div>1. <title> tag: the content of the <title> tag must be *only* the call to wp_title() with its parameters. All additional content must be added via `wp_title` filter</div><div><br></div><div>2. Document head stylesheet links: all stylesheets, scripts, and stylesheet/script links in the document head and footer must be enqueued, rather than hard-coded. Common culprits are GoogleFont stylesheet links</div>
<div><br></div><div>3. wp_nav_menu(): Themes must use the theme_location parameter, and NOT the menu parameter, in calls to wp_nav_menu(). The theme_location parameter corresponds to the array key used in the register_nav_menu()/register_nav_menus() call. The menu parameter corresponds to the slug for a *user-defined* custom nav menu.</div>
<div><br></div><div>4. Namespacing arguments arrays: Please place arguments arrays directly inside of the function calls to which they apply, or properly namespace the variable used to hold the array:</div><div><br></div>
<blockquote style="border:none;padding:0px;"><div>$args = array( /* ... */ )</div><div>wp_nav_menu( $args );</div><div><br></div><div>Instead do one of the following:</div><div><br></div><div>wp_nav_menu( array( /* ... */ );</div>
<div><br></div><div>or </div><div><br></div><div>$themeslug_primary_menu_args = array( /* ... */ )</div><div>wp_nav_menu( $themeslug_primary_menu_args ;</div></blockquote><div><br></div><div>5. Confusion between the *site front page* and the *blog posts index*: is_front_page() vs is_home(), front-page.php vs home.php (and confusing custom page template names), etc. Themes must use front-page.php for the *site front page*, and that must account for both the blog posts index and a static page as front page.</div>
<div><br></div><div>6. Child Theme Friendliness: be cognizant of the differences between get_template_directory() and get_stylesheet_directory(), and the appropriate uses for each. Any asset that is NOT intended to be overridden in a Child Theme (e.g. Theme options) *must* use get_template_directory().</div>
<div><br></div><div>Thanks, everyone, for all your time and contribution to Theme review!</div><span class="ecxHOEnZb"><font color="#888888"><div><br></div><div>Chip</div></font></span></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________
theme-reviewers mailing list
theme-reviewers@lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers</div></div> </div></body>
</html>