<div dir="ltr"><div><br></div><div>Looks great Zgani, but I see you also didn't implement menu fallback and most of bootstrap themes in directory doesn't implement fallback menu in case none is selected? </div><div>
<br>
</div><div>I am pretty new to theme development and I tried to implement it in my theme , it works and reviewed.. but not sure if what I have done was the way or it was unnecessary? I believe WordPress core should have taken care it.</div>
<div><br></div><div><a href="http://wordpress.org/themes/bikaner">http://wordpress.org/themes/bikaner</a><br></div><div><br></div><div>-Ash<br></div><div><a href="http://devcorn.com">http://devcorn.com</a></div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Tue, Sep 3, 2013 at 8:52 PM, Zulfikar Nore <span dir="ltr"><<a href="mailto:zulfikarnore@live.com" target="_blank">zulfikarnore@live.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div dir="ltr">Anyone interested in Bootstrap themeing can use my "improvisation" of a framework - built on Underscores and Bootstrap :)<div><br></div><div>You can grab it at <a href="http://www.wpstrapcode.com/theme-developers-framework" target="_blank">http://www.wpstrapcode.com/theme-developers-framework</a> - there are two versions, take your pick or take them both.</div>
<div><br></div><div>Regards,</div><div>Zulf AKA ZGani<br><br><div><hr>Date: Tue, 3 Sep 2013 16:17:36 +0530<br>From: <a href="mailto:wp@devcorn.com" target="_blank">wp@devcorn.com</a><br>To: <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
Subject: Re: [theme-reviewers] wp_mav_menu using bootstrap<div><div class="h5"><br><br><div dir="ltr">Apart from extending , this is what I am doing.<div><br></div><div>in header.php</div><div><br></div><div><?php wp_nav_menu( array( 'theme_location' => 'primary', 'menu_class' => 'navbar-nav nav ' , 'container_class' => 'collapse navbar-collapse primary-menu-collapse','walker' => new bikaner_walker_nav_menu(),'fallback_cb'=>'bikaner_wp_page_menu' )); ?><br>
<div><br></div><div>and following in bikaner_wp_page_menu in functions.php</div><div><br></div><div>761 : $list_args['walker'] = new bikaner_walker_page_menu;<br></div><div><br></div><div>Let me know if you need more details.</div>
<div><br></div><div>Thanks</div><div>Ash</div></div></div><div><br><br><div>On Tue, Sep 3, 2013 at 4:05 PM, devcorn <span dir="ltr"><<a href="mailto:wp@devcorn.com" target="_blank">wp@devcorn.com</a>></span> wrote:<br>
<blockquote style="border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">And I have one based on bootstrap3 , It is reviewed by WRT and in directory ... you need to extend the walker class.. <div>
<br></div><div><a href="http://wordpress.org/themes/bikaner" target="_blank">http://wordpress.org/themes/bikaner</a><br>
</div></div><div><div><div><br><br><div>On Tue, Sep 3, 2013 at 11:24 AM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br>
<blockquote style="border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">From one of the previous reviewers <a href="http://wordpress.org/themes/the-bootstrap" target="_blank">http://wordpress.org/themes/the-bootstrap</a> good stuff there :-D</p>
<div><div>
<div>On Sep 3, 2013 12:47 AM, "Srikanth Koneru" <<a href="mailto:tskk79@gmail.com" target="_blank">tskk79@gmail.com</a>> wrote:<br><blockquote style="border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Or look at one of zgani's themes, he is obsessed with bootstrap :)<br></div><div><br><br><div>On Tue, Sep 3, 2013 at 11:09 AM, Konrad Sroka <span dir="ltr"><<a href="mailto:konrads@themekraft.com" target="_blank">konrads@themekraft.com</a>></span> wrote:<br>
<blockquote style="border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hey Priyanshu, <div><br></div><div>we just built a WordPress Starter Theme based on Twitter Bootstrap 3.0 and Underscores (_s). </div>
<div><br></div><div>And it aligns 100% with the WordPress Theme Review Guidelines. (please correct me anyone if I should be wrong) </div>
<div><br></div><div>Maybe you can find some inspiration in our nav walker or other stuff ;-) </div><div><br></div><div>Project @ Github: <a href="https://github.com/Themekraft/_tk" target="_blank">https://github.com/Themekraft/_tk</a> </div>
<div><br></div><div>Cheers, Konrad<br></div></div><div><br><br><div><div><div>On 3 September 2013 06:26, priyanshu mittal <span dir="ltr"><<a href="mailto:priyanshu.mittal@gmail.com" target="_blank">priyanshu.mittal@gmail.com</a>></span> wrote:<br>
</div></div><blockquote style="border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr">Hey I am using bootstrap for my next theme and getting some problems with menu which is, wp_page_menu is not supporting bootstrap nav walker<div>
<br></div><div>wp_nav_menu is working fine but when there is no custom menu or location than in that case the default fallback must work which is wp_page_menu, because i want to maintain responsiveness with the page links as well</div>
<div><br></div><div><br></div><div>Any suggestions?</div></div>
<br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><br></div><div>i.A. Konrad Sroka </div><div><span><font face="arial, helvetica, sans-serif"><span lang="DE"><font size="4">Themekraft UG </font></span><span lang="DE"><font size="4">haftungsbeschränkt </font><br>
</span></font></span><span style="font-family:arial,helvetica,sans-serif">Beautiful Themes and Plugins for WordPress and BuddyPress </span><br><span style="font-family:arial,helvetica,sans-serif">web - <a href="http://themekraft.com" target="_blank">http://themekraft.com</a> <br>
</span><span style="font-family:arial,helvetica,sans-serif">mail - <a href="mailto:konrads@themekraft.com" target="_blank">konrads@themekraft.com</a></span><span style="font-family:arial,helvetica,sans-serif"> <br>
</span><br><span style="letter-spacing:-0.1pt"><font face="arial, helvetica, sans-serif">Höhenstrasse 55 </font><br></span><span style="letter-spacing:-0.1pt;font-family:arial,helvetica,sans-serif">D-40227 Düsseldorf <br>
</span><span style="letter-spacing:-0.1pt;font-family:arial,helvetica,sans-serif">Germany </span><br><span style="font-family:arial,helvetica,sans-serif">HRB 66772, Gerichtsstand Düsseldorf, deutsches Recht <br>
</span><span style="font-family:arial,helvetica,sans-serif">Geschäftsführung / Managing Director: Sven Lehnert <br></span><span style="letter-spacing:-0.1pt;font-family:arial,helvetica,sans-serif" lang="DE">USt-ID: </span><span style="letter-spacing:-0.1pt;font-family:arial,helvetica,sans-serif">DE282376267</span><br>
</div><div><br></div><div><br></div><div><br></div><div><br></div>
</div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
<br>_______________________________________________
theme-reviewers mailing list
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></div></div></div></div> </div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>